Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[node] correct SlowBuffer #32661

Merged
merged 1 commit into from
Feb 8, 2019
Merged

[node] correct SlowBuffer #32661

merged 1 commit into from
Feb 8, 2019

Conversation

Flarna
Copy link
Contributor

@Flarna Flarna commented Jan 31, 2019

Removed SlowBuffer from global as it doesn't exist there.
Remove non existing constructors.

@typescript-bot typescript-bot added this to Check and Merge in Pull Request Status Board Jan 31, 2019
@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Awaiting reviewer feedback Author is Owner The author of this PR is a listed owner of the package. labels Jan 31, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Jan 31, 2019

@Flarna Thank you for submitting this PR!

🔔 @microsoft @DefinitelyTyped @jkomyno @a-tarasyuk @alvis @r3nya @BrunoScheufler @smac89 @tellnes @DeividasBakanas @eyqs @Hannes-Magnusson-CK @KSXGitHub @hoo29 @kjin @ajafff @islishude @mwiktorczyk @matthieusieben @mohsen1 @n-e @octo-sniffle @parambirs @eps1lon @SimonSchick @ThomasdenH @WilcoBakker @wwwy3y3 @ZaneHannanAU @jeremiergz @samuela @kuehlein - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Contributor

Since you're a listed owner and the build passed, this PR is fast-tracked. A maintainer will merge shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@Flarna
Copy link
Contributor Author

Flarna commented Jan 31, 2019

@sandersn Seems CI for node is broken again...

Error in ledgerhq__hw-transport
Error: /home/travis/build/DefinitelyTyped/DefinitelyTyped/types/ledgerhq__hw-transport/ledgerhq__hw-transport-tests.ts:6:1
ERROR: 6:1  expect  Expected type to be:
  Promise<ReadonlyArray<string>>
got:
  Promise<readonly string[]>
    at /home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/dtslint/bin/index.js:161:19
    at Generator.next (<anonymous>)
    at fulfilled (/home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/dtslint/bin/index.js:5:58)
    at <anonymous>

Is this an expected change from typescript side? Maybe microsoft/TypeScript#29435?

@typescript-bot typescript-bot moved this from Check and Merge to Needs Author Attention in Pull Request Status Board Jan 31, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Jan 31, 2019

@Flarna The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@typescript-bot typescript-bot added Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. and removed Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. labels Feb 1, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Feb 1, 2019

@Flarna The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@typescript-bot typescript-bot moved this from Needs Author Attention to Check and Merge in Pull Request Status Board Feb 4, 2019
@typescript-bot typescript-bot moved this from Check and Merge to Needs Author Attention in Pull Request Status Board Feb 4, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Feb 4, 2019

@Flarna The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@Flarna Flarna closed this Feb 7, 2019
@Flarna Flarna reopened this Feb 7, 2019
@typescript-bot typescript-bot moved this from Needs Author Attention to Check and Merge in Pull Request Status Board Feb 7, 2019
@armanio123 armanio123 merged commit 510f813 into DefinitelyTyped:master Feb 8, 2019
@typescript-bot typescript-bot removed this from Check and Merge in Pull Request Status Board Feb 8, 2019
@typescript-bot
Copy link
Contributor

I just published @types/node@10.12.23 to npm.

@Flarna Flarna deleted the node-remove-slowbuffer-from-global branch February 8, 2019 06:54
@Flarna Flarna mentioned this pull request Feb 9, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author is Owner The author of this PR is a listed owner of the package. Popular package This PR affects a popular package (as counted by NPM download counts).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants