[qrcode] improve types: toCanvas, toFileStream #35367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add type for error correction level - change toCanvas to accept renderer options - add file stream options, and change toFileStream to use
|
@mnahkies Thank you for submitting this PR! 🔔 @plantain-00 - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
plantain-00
approved these changes
May 11, 2019
typescript-bot
added
Owner Approved
|
A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped! |
iRON5
pushed a commit
to iRON5/DefinitelyTyped
that referenced
this pull request
Aug 13, 2019
- add type for error correction level - change toCanvas to accept renderer options - add file stream options, and change toFileStream to use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill in this template.
npm test.)npm run lint package-name(ortscif notslint.jsonis present).If changing an existing definition:
toCanvas:
https://github.com/soldair/node-qrcode/blob/master/lib/renderer/canvas.js#L34
toFileStream:
https://github.com/soldair/node-qrcode/blob/master/lib/server.js#L134