[@hapi/hapi] separate server/request/response app states #36361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mikejpeters Thank you for submitting this PR! 🔔 @rafaelsouzaf @jhsimms @SimonSchick @saboya @lenovouser - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
|
👋 Hi there! I’ve run some quick performance metrics against master and your PR. This is still an experiment, so don’t panic if I say something crazy! I’m still learning how to interpret these metrics. Let’s review the numbers, shall we? Comparison details 📊
It looks like nothing changed too much. I’m pretty lenient since I’m still an experiment, so take a look anyways and make sure nothing looks out of place. If you have any questions or comments about me, you can ping |
saboya
approved these changes
Jun 22, 2019
typescript-bot
added
Owner Approved
|
A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped! |
|
I just published |
iRON5
pushed a commit
to iRON5/DefinitelyTyped
that referenced
this pull request
Aug 13, 2019
watson
added a commit
to watson/kibana
that referenced
this pull request
Mar 31, 2020
The `ApplicationState` interface has in the new version of `@types/hapi__hapi` been split up into: - `RequestApplicationState` - `ResponeApplicationState` - `ServerApplicationState` See PR for more info: DefinitelyTyped/DefinitelyTyped#36361 It looks like the one we want to use is `RequestApplicationState`.
watson
added a commit
to watson/kibana
that referenced
this pull request
Oct 14, 2020
The `ApplicationState` interface has in the new version of `@types/hapi__hapi` been split up into: - `RequestApplicationState` - `ResponeApplicationState` - `ServerApplicationState` See PR for more info: DefinitelyTyped/DefinitelyTyped#36361 It looks like the one we want to use is `RequestApplicationState`.
watson
added a commit
to watson/kibana
that referenced
this pull request
Oct 14, 2020
The `ApplicationState` interface has in the new version of `@types/hapi__hapi` been split up into: - `RequestApplicationState` - `ResponeApplicationState` - `ServerApplicationState` See PR for more info: DefinitelyTyped/DefinitelyTyped#36361 It looks like the one we want to use is `RequestApplicationState`.
watson
added a commit
to watson/kibana
that referenced
this pull request
Oct 14, 2020
The `ApplicationState` interface has in the new version of `@types/hapi__hapi` been split up into: - `RequestApplicationState` - `ResponeApplicationState` - `ServerApplicationState` See PR for more info: DefinitelyTyped/DefinitelyTyped#36361 It looks like the one we want to use is `RequestApplicationState`.
watson
added a commit
to watson/kibana
that referenced
this pull request
Oct 14, 2020
The `ApplicationState` interface has in the new version of `@types/hapi__hapi` been split up into: - `RequestApplicationState` - `ResponeApplicationState` - `ServerApplicationState` See PR for more info: DefinitelyTyped/DefinitelyTyped#36361 It looks like the one we want to use is `RequestApplicationState`.
watson
added a commit
to watson/kibana
that referenced
this pull request
Oct 27, 2020
The `ApplicationState` interface has in the new version of `@types/hapi__hapi` been split up into: - `RequestApplicationState` - `ResponeApplicationState` - `ServerApplicationState` See PR for more info: DefinitelyTyped/DefinitelyTyped#36361 It looks like the one we want to use is `RequestApplicationState`.
watson
added a commit
to watson/kibana
that referenced
this pull request
Oct 28, 2020
The `ApplicationState` interface has in the new version of `@types/hapi__hapi` been split up into: - `RequestApplicationState` - `ResponeApplicationState` - `ServerApplicationState` See PR for more info: DefinitelyTyped/DefinitelyTyped#36361 It looks like the one we want to use is `RequestApplicationState`.
watson
added a commit
to watson/kibana
that referenced
this pull request
Oct 28, 2020
The `ApplicationState` interface has in the new version of `@types/hapi__hapi` been split up into: - `RequestApplicationState` - `ResponeApplicationState` - `ServerApplicationState` See PR for more info: DefinitelyTyped/DefinitelyTyped#36361 It looks like the one we want to use is `RequestApplicationState`.
watson
added a commit
to watson/kibana
that referenced
this pull request
Oct 29, 2020
The `ApplicationState` interface has in the new version of `@types/hapi__hapi` been split up into: - `RequestApplicationState` - `ResponeApplicationState` - `ServerApplicationState` See PR for more info: DefinitelyTyped/DefinitelyTyped#36361 It looks like the one we want to use is `RequestApplicationState`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30465
npm test.)npm run lint package-name(ortscif notslint.jsonis present).tslint.jsoncontaining{ "extends": "dtslint/dt.json" }.