Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@types/utm - Make northern optional in toLatLon method #37527

Merged
merged 6 commits into from
Aug 22, 2019

Conversation

JonasTriki
Copy link
Contributor

@JonasTriki JonasTriki commented Aug 10, 2019

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).
  • Provide a URL to documentation or source code which provides context for the suggested changes: index.es.js#L36 requires northern to be undefined to not throw error.

@typescript-bot
Copy link
Contributor

typescript-bot commented Aug 10, 2019

@JonasTriki Thank you for submitting this PR!

🔔 @civilizeddev - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick performance metrics against master and your PR. This is still an experiment, so don’t panic if I say something crazy! I’m still learning how to interpret these metrics.

Let’s review the numbers, shall we?

Comparison details 📊
master #37527 diff
Batch compilation
Memory usage (MiB) 35.3 35.4 +0.2%
Type count 2025 2025 0.0%
Assignability cache size 99 99 0.0%
Subtype cache size 0 0
Identity cache size 0 0
Language service
Samples taken 43 43 0.0%
Identifiers in tests 43 43 0.0%
getCompletionsAtPosition
    Mean duration (ms) 82.9 81.6 -1.6%
    Median duration (ms) 82.2 83.2 +1.2%
    Mean CV 29.3% 29.6% +0.9%
    Worst duration (ms) 103.7 98.5 -5.1%
    Worst identifier utmCoord1 easting
getQuickInfoAtPosition
    Mean duration (ms) 78.4 79.5 +1.4%
    Median duration (ms) 77.8 78.8 +1.3%
    Mean CV 25.5% 27.4% +7.4%
    Worst duration (ms) 102.4 103.9 +1.5%
    Worst identifier northing toLatLon

It looks like nothing changed too much. I’m pretty lenient since I’m still an experiment, so take a look anyways and make sure nothing looks out of place.


If you have any questions or comments about me, you can ping @andrewbranch. Have a nice day!

@typescript-bot typescript-bot added the Unmerged The author did not merge the PR when it was ready. label Aug 15, 2019
@typescript-bot
Copy link
Contributor

After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience!

types/utm/index.d.ts Outdated Show resolved Hide resolved
@PranavSenthilnathan
Copy link
Contributor

Since this is adding an author, @civilizeddev can you take a look if you get a chance?

@typescript-bot typescript-bot added Revision needed This PR needs code changes before it can be merged. and removed Awaiting reviewer feedback Unmerged The author did not merge the PR when it was ready. labels Aug 15, 2019
@typescript-bot
Copy link
Contributor

@JonasTriki One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits or comments. Thank you!

@typescript-bot
Copy link
Contributor

@JonasTriki I haven't seen anything from you in a while and this PR currently has problems that prevent it from being merged. The PR will be closed tomorrow if there aren't new commits to fix the issues.

@typescript-bot
Copy link
Contributor

Updated numbers for you here from a3e0eac:

Comparison details 📊
master #37527 diff
Batch compilation
Memory usage (MiB) 35.3 35.4 +0.5%
Type count 2025 2026 0.0%
Assignability cache size 99 99 0.0%
Subtype cache size 0 0
Identity cache size 0 0
Language service
Samples taken 43 43 0.0%
Identifiers in tests 43 43 0.0%
getCompletionsAtPosition
    Mean duration (ms) 83.1 83.0 -0.1%
    Median duration (ms) 81.2 80.3 -1.1%
    Mean CV 25.9% 26.7% +3.1%
    Worst duration (ms) 127.1 109.3 -14.0%
    Worst identifier utmCoord2 latLon1
getQuickInfoAtPosition
    Mean duration (ms) 80.4 81.5 +1.4%
    Median duration (ms) 79.9 81.5 +2.0%
    Mean CV 26.8% 27.0% +1.0%
    Worst duration (ms) 110.8 103.9 -6.2%
    Worst identifier toLatLon fromLatLon

It looks like nothing changed too much. I’m pretty lenient since I’m still an experiment, so take a look anyways and make sure nothing looks out of place.

@typescript-bot
Copy link
Contributor

typescript-bot commented Aug 21, 2019

@JonasTriki The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@typescript-bot
Copy link
Contributor

Updated numbers for you here from 57d38f1:

Comparison details 📊
master #37527 diff
Batch compilation
Memory usage (MiB) 35.3 35.3 -0.1%
Type count 2025 2026 0.0%
Assignability cache size 99 99 0.0%
Subtype cache size 0 0
Identity cache size 0 0
Language service
Samples taken 43 43 0.0%
Identifiers in tests 43 43 0.0%
getCompletionsAtPosition
    Mean duration (ms) 81.9 77.5 -5.4%
    Median duration (ms) 77.8 77.6 -0.2%
    Mean CV 30.0% 28.1% -6.2%
    Worst duration (ms) 103.9 99.3 -4.4%
    Worst identifier easting zoneLetter
getQuickInfoAtPosition
    Mean duration (ms) 79.2 74.3 -6.2%
    Median duration (ms) 77.7 74.1 -4.7%
    Mean CV 28.2% 26.5% -6.0%
    Worst duration (ms) 98.8 93.6 -5.2%
    Worst identifier toLatLon lat

It looks like nothing changed too much. I’m pretty lenient since I’m still an experiment, so take a look anyways and make sure nothing looks out of place.

@typescript-bot
Copy link
Contributor

Updated numbers for you here from 5b16cbd:

Comparison details 📊
master #37527 diff
Batch compilation
Memory usage (MiB) 35.4 35.5 +0.1%
Type count 2025 2026 0.0%
Assignability cache size 99 99 0.0%
Subtype cache size 0 0
Identity cache size 0 0
Language service
Samples taken 43 43 0.0%
Identifiers in tests 43 43 0.0%
getCompletionsAtPosition
    Mean duration (ms) 85.5 85.8 +0.3%
    Median duration (ms) 79.7 80.7 +1.3%
    Mean CV 29.5% 27.6% -6.6%
    Worst duration (ms) 115.1 119.3 +3.6%
    Worst identifier zoneLetter northing
getQuickInfoAtPosition
    Mean duration (ms) 82.9 84.9 +2.5%
    Median duration (ms) 82.2 82.0 -0.2%
    Mean CV 26.3% 27.9% +6.0%
    Worst duration (ms) 105.5 101.5 -3.9%
    Worst identifier toLatLon lat

It looks like nothing changed too much. I’m pretty lenient since I’m still an experiment, so take a look anyways and make sure nothing looks out of place.

@typescript-bot
Copy link
Contributor

🔔 @PranavSenthilnathan - Thanks for your review of this PR! Can you please look at the new code and update your review status if appropriate?

@sheetalkamat sheetalkamat merged commit 29f705f into DefinitelyTyped:master Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Revision needed This PR needs code changes before it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants