[@testing-library/vue] New type definition

[cimbul]

This is for version 1.2. Version 2.0 was recently released two days ago, but the types will require minimal changes. I think it makes sense to get the types for this version published before making the update.

---

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change. (Run with npm test.)
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm run lint package-name (or tsc if no tslint.json is present).

If adding a new definition:

• The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration – See Add typings testing-library/vue-testing-library#74 and fix(typescript): move typings to DefinitelyTyped testing-library/react-testing-library#437
• If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
• Create it with dts-gen --dt, not by basing it on an existing project. Didn't work with scoped package, so I adapted it from other types/testing-library__* definitions.
• tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

[cimbul]

Travis build failed with an error about the dependency whitelist, but I already have a PR merged in types-publisher for that: microsoft/types-publisher#643. Is there something else that needs to happen on the DefinitelyTyped side to get that change?

Error: In package.json: Dependency @vue/test-utils not in whitelist.
If you are depending on another @types package, do not add it to a package.json. Path mapping should make the import work.
If this is an external library that provides typings, please make a pull request to types-publisher adding it to dependenciesWhitelist.txt.

[typescript-bot]

👋 Hi there! I’ve run some quick performance metrics against master and your PR. This is still an experiment, so don’t panic if I say something crazy! I’m still learning how to interpret these metrics.

Let’s review the numbers, shall we?

These typings are for a package that doesn’t yet exist on master, so I don’t have anything to compare against yet! In the future, I’ll be able to compare PRs to testing-library__vue with its source on master.

Comparison details 📊

Batch compilation
Type count	13185
Assignability cache size	34613
Subtype cache size	23
Identity cache size	3
Language service measurements
Samples taken	462
Identifiers in tests	462
getCompletionsAtPosition
Mean duration (ms)	423.0
Median duration (ms)	420.8
Mean CV	13.2%
Worst duration (ms)	569.3
Worst identifier	normalizer
getQuickInfoAtPosition
Mean duration (ms)	418.9
Median duration (ms)	416.1
Mean CV	13.7%
Worst duration (ms)	565.3
Worst identifier	x
System information
Node version	v10.16.1
CPU count	2
CPU speed	2.397 GHz
CPU model	Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz
CPU Architecture	x64
Memory	6.8 GiB
Platform	linux
Release	4.15.0-1052-azure

---

If you have any questions or comments about me, you can ping @andrewbranch. Have a nice day!

[johnnyreilly]

@sandersn would you be able to advise on the types publisher issue please?

[typescript-bot]

@cimbul Thank you for submitting this PR!

Because this is a new definition, a DefinitelyTyped maintainer will be reviewing this PR in the next few days once the Travis CI build passes.

In the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day!

[typescript-bot]

@cimbul The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

[afontcu]

edit: okay, just read your sentence of the PR. My bad!

---

AFAIK, fireEvent() is returning a Promise (source), and here it appears to be returning a boolean

disclaimer: I might be missing something basic, as I have no experience with type definitions 😇

[cimbul]

Yeah, I'll get this updated to 2.0 after we get 1.2 published. (Or I could just do that now if we want to avoid another PR—I don't feel that strongly about it.)

[sandersn]

@johnnyreilly caching on Travis isn't aware of updates from github references in package.json. So I have to manually invalidate the cache until I figure out how to to fix that.

[johnnyreilly]

So I have to manually invalidate the cache until I figure out how to to fix that.

Awesome; this just proves the truth of Phil Karlton's maxim 😁

There are only two hard things in Computer Science: cache invalidation and naming things.

[cimbul]

@sandersn @johnnyreilly It looks like basically everyone's PR builds are failing since this got merged in... 😬

[sandersn]

@cimbul thanks for the warning. Turns out my cache invalidation yesterday didn't take?? Anyway, everything should be fine now.