Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(react): Remove usage of React.Attributes #38352

Merged
merged 1 commit into from
Sep 17, 2019

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Sep 13, 2019

Spotted this during review and it kind of threw me off. React.Attributes only includes key with which you'll never deal in props validation nor see in your component implementation.

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Only includes `key` with which you'll never deal
in props validation
@typescript-bot typescript-bot added this to Check and Merge in Pull Request Status Board Sep 13, 2019
@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Awaiting reviewer feedback Author is Owner The author of this PR is a listed owner of the package. labels Sep 13, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Sep 13, 2019

@eps1lon Thank you for submitting this PR!

🔔 @johnnyreilly @bbenezech @pzavolinsky @digiguru @ericanderson @DovydasNavickas @theruther4d @guilhermehubner @ferdaber @jrakotoharisoa @pascaloliv @Hotell @franklixuefei @Jessidhia @saranshkataria @lukyth - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Contributor

Since you're a listed owner and the build passed, this PR is fast-tracked. A maintainer will merge shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick performance metrics against master and your PR. This is still an experiment, so don’t panic if I say something crazy! I’m still learning how to interpret these metrics.

Let’s review the numbers, shall we?

Comparison details 📊
master #38352 diff
Batch compilation
Type count 53266 53345 +0.1%
Assignability cache size 23771 23796 +0.1%
Subtype cache size 3886 3885 0.0%
Identity cache size 764 765 +0.1%
Language service
Samples taken 8788 2105 -76.0%
Identifiers in tests 2524 2528 +0.2%
getCompletionsAtPosition
    Mean duration (ms) 401.8 406.4 +1.1%
    Median duration (ms) 383.4 396.6 +3.4%
    Mean CV 10.1%
    Worst duration (ms) 853.0 862.0 +1.1%
    Worst identifier TransitionGroup TransitionGroup
getQuickInfoAtPosition
    Mean duration (ms) 414.2 415.2 +0.2%
    Median duration (ms) 401.5 406.5 +1.2%
    Mean CV 10.9%
    Worst duration (ms) 836.9 851.5 +1.8%
    Worst identifier component component
System information
Node version v10.15.3 v10.16.3
CPU count 2 2
CPU speed 2.294 GHz 2.294 GHz
CPU model Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
CPU Architecture x64 x64
Memory 6.8 GiB 6.8 GiB
Platform linux linux
Release 4.15.0-1041-azure 4.15.0-1055-azure

First off, note that the system varied slightly between these two runs, so you’ll have to take these measurements with a grain of salt.

It looks like nothing changed too much. I’m pretty lenient since I’m still an experiment, so take a look anyways and make sure nothing looks out of place.


If you have any questions or comments about me, you can ping @andrewbranch. Have a nice day!

@orta
Copy link
Collaborator

orta commented Sep 17, 2019

👍 looks good to me

@orta orta merged commit bcff64d into DefinitelyTyped:master Sep 17, 2019
Pull Request Status Board automation moved this from Check and Merge to Done Sep 17, 2019
@eps1lon eps1lon deleted the chore/react/test-cleanup branch September 17, 2019 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author is Owner The author of this PR is a listed owner of the package. Popular package This PR affects a popular package (as counted by NPM download counts).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants