Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version for swiper5.x - URGENT #40178

Merged
merged 3 commits into from Nov 6, 2019

Conversation

kidjp85
Copy link
Contributor

@kidjp85 kidjp85 commented Nov 6, 2019

Re-open ticket due to #40022

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

@typescript-bot typescript-bot added New Definition This PR creates a new definition package. Popular package This PR affects a popular package (as counted by NPM download counts). Awaiting reviewer feedback labels Nov 6, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Nov 6, 2019

@kidjp85 Thank you for submitting this PR!

Because this is a new definition, a DefinitelyTyped maintainer will be reviewing this PR in the next few days once the Travis CI build passes.

In the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day!

@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

swiper/v4

Comparison details for swiper/v4 📊
master #40178 diff
Batch compilation
Memory usage (MiB) 77.1 77.7 +0.7%
Type count 9479 9479 0%
Assignability cache size 33289 33289 0%
Language service
Samples taken 604 604 0%
Identifiers in tests 604 604 0%
getCompletionsAtPosition
    Mean duration (ms) 394.9 392.6 -0.6%
    Mean CV 13.3% 12.8%
    Worst duration (ms) 505.8 503.3 -0.5%
    Worst identifier appendNumber navigation
getQuickInfoAtPosition
    Mean duration (ms) 399.0 406.4 +1.9%
    Mean CV 13.1% 14.2% +8.0%
    Worst duration (ms) 519.2 511.6 -1.5%
    Worst identifier swiper slidesPerView

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

swiper/v5

These typings are for a package that doesn’t yet exist on master, so I don’t have anything to compare against yet! In the future, I’ll be able to compare PRs to swiper with its source on master.

Comparison details for swiper/v5 📊
Batch compilation
Type count 9479
Assignability cache size 33289
Language service measurements
Samples taken 604
Identifiers in tests 604
getCompletionsAtPosition
    Mean duration (ms) 395.0
    Mean CV 13.5%
    Worst duration (ms) 500.3
    Worst identifier Swiper
getQuickInfoAtPosition
    Mean duration (ms) 397.8
    Mean CV 13.4%
    Worst duration (ms) 489.5
    Worst identifier clickable
System information
Node version v10.16.3
CPU count 2
CPU speed 2.294 GHz
CPU model Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
CPU Architecture x64
Memory 6.8 GiB
Platform linux
Release 4.15.0-1059-azure

swiper/v3

Comparison details for swiper/v3 📊
master #40178 diff
Batch compilation
Memory usage (MiB) 90.9 92.3 +1.5%
Type count 15361 15361 0%
Assignability cache size 33435 33435 0%
Language service
Samples taken 518 518 0%
Identifiers in tests 518 518 0%
getCompletionsAtPosition
    Mean duration (ms) 590.2 575.6 -2.5%
    Mean CV 11.1% 10.9%
    Worst duration (ms) 694.4 766.8 +10.4%
    Worst identifier onSlideChangeStart console
getQuickInfoAtPosition
    Mean duration (ms) 592.4 573.7 -3.2%
    Mean CV 11.6% 11.5% -0.9%
    Worst duration (ms) 744.0 731.6 -1.7%
    Worst identifier Swiper log

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label Nov 6, 2019
@sandersn sandersn merged commit b32b828 into DefinitelyTyped:master Nov 6, 2019
Pull Request Status Board automation moved this from Review to Done Nov 6, 2019
@typescript-bot
Copy link
Contributor

I just published @types/swiper@5.2.0 to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Definition This PR creates a new definition package. Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. Popular package This PR affects a popular package (as counted by NPM download counts).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants