Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jszip] add string output type #41183

Merged
merged 1 commit into from Jan 8, 2020

Conversation

ffflorian
Copy link
Collaborator

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: https://stuk.github.io/jszip/documentation/api_zipobject/async.html
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

@typescript-bot typescript-bot added this to Waiting for Reviewers in Pull Request Status Board Dec 21, 2019
@typescript-bot typescript-bot added Other Approved This PR was reviewed and signed-off by a community member. Popular package This PR affects a popular package (as counted by NPM download counts). Awaiting reviewer feedback labels Dec 21, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Dec 21, 2019

@ffflorian Thank you for submitting this PR!

🔔 @mzeiher @forabi - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #41183 diff
Batch compilation
Memory usage (MiB) 100.8 102.8 +2.0%
Type count 17865 17865 0%
Assignability cache size 37564 37566 0%
Language service
Samples taken 316 316 0%
Identifiers in tests 316 316 0%
getCompletionsAtPosition
    Mean duration (ms) 577.7 575.7 -0.3%
    Mean CV 8.7% 9.1%
    Worst duration (ms) 687.5 725.8 +5.6%
    Worst identifier Array folders
getQuickInfoAtPosition
    Mean duration (ms) 574.2 574.6 +0.1%
    Mean CV 9.4% 10.0% +6.4%
    Worst duration (ms) 685.7 728.3 +6.2%
    Worst identifier catch async

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label Dec 21, 2019
@typescript-bot typescript-bot moved this from Waiting for Reviewers to Needs Author Attention in Pull Request Status Board Dec 21, 2019
@typescript-bot typescript-bot added Revision needed This PR needs code changes before it can be merged. and removed Other Approved This PR was reviewed and signed-off by a community member. Awaiting reviewer feedback labels Dec 21, 2019
@typescript-bot
Copy link
Contributor

@ffflorian One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits or comments. Thank you!

@typescript-bot
Copy link
Contributor

🔔 @peterblazejewicz - Thanks for your review of this PR! Can you please look at the new code and update your review status if appropriate?

Copy link
Member

@peterblazejewicz peterblazejewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@typescript-bot typescript-bot moved this from Needs Author Attention to Waiting for Reviewers in Pull Request Status Board Dec 21, 2019
@typescript-bot typescript-bot added Other Approved This PR was reviewed and signed-off by a community member. Awaiting reviewer feedback labels Dec 21, 2019
@typescript-bot typescript-bot moved this from Waiting for Reviewers to Other in Pull Request Status Board Dec 24, 2019
@typescript-bot
Copy link
Contributor

We've gotten sign-off from a reviewer 👏. A maintainer will soon review this PR and merge it if there are no issues. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for contributing to DefinitelyTyped!

@ffflorian
Copy link
Collaborator Author

@alloy any chance to get this merged soon? :)

@alloy
Copy link
Collaborator

alloy commented Jan 8, 2020

None of the reviewers are current maintainers of these typings, but the change seems innocuous enough and it has been a while already so I think these reviews suffice 👍

@alloy alloy merged commit f1f2a7e into DefinitelyTyped:master Jan 8, 2020
Pull Request Status Board automation moved this from Other to Done Jan 8, 2020
@ffflorian
Copy link
Collaborator Author

Thank you :)

@ffflorian ffflorian deleted the fix-jszip-string branch January 8, 2020 15:54
@typescript-bot
Copy link
Contributor

I just published @types/jszip@3.1.7 to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Other Approved This PR was reviewed and signed-off by a community member. Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. Popular package This PR affects a popular package (as counted by NPM download counts). Revision needed This PR needs code changes before it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants