Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PollyJS updates #41240

Merged
merged 5 commits into from
Dec 26, 2019
Merged

PollyJS updates #41240

merged 5 commits into from
Dec 26, 2019

Conversation

brandon-leapyear
Copy link
Contributor

@brandon-leapyear brandon-leapyear commented Dec 24, 2019

This is an old work account. Please reference @brandonchinn178 for all future communication


Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

pollyjs__adapter/v3

These typings are for a package that doesn’t yet exist on master, so I don’t have anything to compare against yet! In the future, I’ll be able to compare PRs to pollyjs__adapter with its source on master.

Comparison details for pollyjs__adapter/v3 📊
Batch compilation
Type count 2318
Assignability cache size 112
Language service measurements
Samples taken 21
Identifiers in tests 21
getCompletionsAtPosition
    Mean duration (ms) 82.9
    Mean CV 16.9%
    Worst duration (ms) 112.3
    Worst identifier result
getQuickInfoAtPosition
    Mean duration (ms) 80.9
    Mean CV 14.4%
    Worst duration (ms) 91.5
    Worst identifier result
System information
Node version v12.13.1
CPU count 2
CPU speed 2.294 GHz
CPU model Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
CPU Architecture x64
Memory 6.8 GiB
Platform linux
Release 4.15.0-1064-azure

pollyjs__core/v3

These typings are for a package that doesn’t yet exist on master, so I don’t have anything to compare against yet! In the future, I’ll be able to compare PRs to pollyjs__core with its source on master.

Comparison details for pollyjs__core/v3 📊
Batch compilation
Type count 2528
Assignability cache size 209
Language service measurements
Samples taken 267
Identifiers in tests 267
getCompletionsAtPosition
    Mean duration (ms) 85.1
    Mean CV 16.3%
    Worst duration (ms) 125.0
    Worst identifier polly
getQuickInfoAtPosition
    Mean duration (ms) 86.9
    Mean CV 16.1%
    Worst duration (ms) 128.9
    Worst identifier hash
System information
Node version v12.13.1
CPU count 2
CPU speed 2.294 GHz
CPU model Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
CPU Architecture x64
Memory 6.8 GiB
Platform linux
Release 4.15.0-1064-azure

@typescript-bot
Copy link
Contributor

typescript-bot commented Dec 25, 2019

@brandon-leapyear Thank you for submitting this PR!

🔔 @feinoujc @BoruiGu @offirgolan - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express and removed Awaiting reviewer feedback labels Dec 25, 2019
@typescript-bot
Copy link
Contributor

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@andrewbranch andrewbranch merged commit 96fc179 into DefinitelyTyped:master Dec 26, 2019
@brandon-leapyear brandon-leapyear deleted the pollyjs branch December 26, 2019 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Owner Approved A listed owner of this package signed off on the pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants