Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@types/react-native]: Update supported KeyboardType by both platforms #42376

Merged
merged 1 commit into from Feb 14, 2020
Merged

Conversation

doumart
Copy link
Contributor

@doumart doumart commented Feb 14, 2020

Reading the doc of react-native 61.0 there are more keyboard types supported by both platforms: https://facebook.github.io/react-native/docs/textinput#keyboardtype

Closes: #42375

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

Reading the doc of react-native 61.0 there are more keyboard types supported by both platforms: https://facebook.github.io/react-native/docs/textinput#keyboardtype
@doumart doumart requested a review from alloy as a code owner February 14, 2020 15:23
@typescript-bot typescript-bot added this to Waiting for Reviewers in Pull Request Status Board Feb 14, 2020
@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Awaiting reviewer feedback labels Feb 14, 2020
@typescript-bot
Copy link
Contributor

typescript-bot commented Feb 14, 2020

@doumart Thank you for submitting this PR!

🔔 @alloy @huhuanming @iRoachie @Skn0tt @timwangdev @kamal @alexdunne @swissmanu @bm-software @a-tarasyuk @mvdam @Esemesek @mrnickel @souvik-ghosh @nossbigg @saranshkataria @franzmoro @tykus160 @jakebloom @ceyhun @mcmar @theohdv @TheSavior @romain-faust @bebebebebe @Naturalclar @chinesedfan @vtolochk @SychevSP @RageBill @sasurau4 @256hz - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #42376 diff
Batch compilation
Memory usage (MiB) 97.2 97.0 -0.3%
Type count 25938 25938 0%
Assignability cache size 22913 22913 0%
Language service
Samples taken 1813 1813 0%
Identifiers in tests 1813 1813 0%
getCompletionsAtPosition
    Mean duration (ms) 334.5 340.8 +1.9%
    Mean CV 9.1% 9.0%
    Worst duration (ms) 543.0 528.5 -2.7%
    Worst identifier source ListHeaderComponentStyle
getQuickInfoAtPosition
    Mean duration (ms) 330.1 335.9 +1.8%
    Mean CV 9.0% 8.7% -2.7%
    Worst duration (ms) 512.8 477.4 -6.9%
    Worst identifier padding ListFooterComponent

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label Feb 14, 2020
@alloy
Copy link
Collaborator

alloy commented Feb 14, 2020

LGTM 👍 Thanks!

@alloy alloy merged commit f2db20e into DefinitelyTyped:master Feb 14, 2020
Pull Request Status Board automation moved this from Waiting for Reviewers to Done Feb 14, 2020
@typescript-bot
Copy link
Contributor

I just published @types/react-native@0.61.15 to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. Popular package This PR affects a popular package (as counted by NPM download counts).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[@types/react-native] KeyboardType missing keyboard supported by Android
4 participants