New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(jsdom): Fix JSDOM types in JavaScript code #43315
Conversation
@ExE-Boss Thank you for submitting this PR! Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. 🔔 @leonard-thieu @palmfjord - please review this PR in the next few days. Be sure to explicitly select Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"pr_number": 43315,
"author": "ExE-Boss",
"owners": [
"leonard-thieu",
"palmfjord",
"ExE-Boss"
],
"dangerLevel": "ScopedAndConfiguration",
"headCommitAbbrOid": "3cfa021",
"headCommitOid": "3cfa021549dc7740e1ca30745eccc6136dee55a0",
"mergeIsRequested": false,
"stalenessInDays": 0,
"lastCommitDate": "2020-03-22T18:45:17.000Z",
"reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43315/files",
"hasMergeConflict": false,
"authorIsOwner": true,
"isFirstContribution": false,
"popularityLevel": "Popular",
"anyPackageIsNew": false,
"packages": [
"jsdom"
],
"files": [
{
"filePath": "types/jsdom/index.d.ts",
"kind": "definition",
"package": "jsdom"
},
{
"filePath": "types/jsdom/package.json",
"kind": "package-meta",
"package": "jsdom"
},
{
"filePath": "types/jsdom/ts3.1/index.d.ts",
"kind": "definition",
"package": "jsdom"
},
{
"filePath": "types/jsdom/ts3.1/jsdom-tests.ts",
"kind": "test",
"package": "jsdom"
},
{
"filePath": "types/jsdom/ts3.4/index.d.ts",
"kind": "definition",
"package": "jsdom"
},
{
"filePath": "types/jsdom/ts3.4/jsdom-tests.ts",
"kind": "test",
"package": "jsdom"
},
{
"filePath": "types/jsdom/ts3.5/index.d.ts",
"kind": "definition",
"package": "jsdom"
},
{
"filePath": "types/jsdom/ts3.5/jsdom-tests.ts",
"kind": "test",
"package": "jsdom"
},
{
"filePath": "types/jsdom/ts3.6/index.d.ts",
"kind": "definition",
"package": "jsdom"
},
{
"filePath": "types/jsdom/ts3.6/jsdom-tests.ts",
"kind": "test",
"package": "jsdom"
}
],
"otherApprovalCount": 0,
"ownerApprovalCount": 0,
"maintainerApprovalCount": 0,
"hasDismissedReview": false,
"travisResult": "pass",
"reviewersWithStaleReviews": [],
"approvalFlags": 0,
"isChangesRequested": false
} |
@ExE-Boss The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
getInternalVMContext(): DOMWindow; | ||
getInternalVMContext(): Context; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The internal VM context may eventually stop being a Window
: nodejs/node#30709.
interface DOMWindow extends Pick<Window, Exclude<keyof Window, 'top' | 'self' | 'window'>>, Context { | ||
interface DOMWindow extends Pick<Window, Exclude<keyof Window, 'top' | 'self' | 'window'>> { | ||
[key: string]: any; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vm.Context
will eventually become a class: nodejs/node#30709.
@ExE-Boss Thank you for submitting this PR! 🔔 @leonard-thieu @palmfjord - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
Since you're a listed owner and the build passed, this PR is fast-tracked. A maintainer will merge shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped! |
Wow, those bots are really fighting it out |
I just published |
Please fill in this template.
npm test
.)npm run lint package-name
(ortsc
if notslint.json
is present).If changing an existing definition:
tslint.json
containing{ "extends": "dtslint/dt.json" }
. If for reason the any rule need to be disabled, disable it for that line using// tslint:disable-next-line [ruleName]
and not for whole package so that the need for disabling can be reviewed.review?(@orta, @RyanCavanaugh): The bot seems to have choked.