Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[testing-library__react] Update cleanup to return Promise #43322

Merged

Conversation

timswalling
Copy link
Contributor

Updates types @types/testing-library__react to reflect changes introduced in testing-library/react-testing-library#519


  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

@timswalling timswalling changed the title [@types/testing-library__react] Update cleanup to return Promise [testing-library__react] Update cleanup to return Promise Mar 23, 2020
@typescript-bot typescript-bot added this to Waiting for Reviewers in Pull Request Status Board Mar 23, 2020
@typescript-bot typescript-bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label Mar 23, 2020
@typescript-bot
Copy link
Contributor

typescript-bot commented Mar 23, 2020

@timswalling Thank you for submitting this PR!

🔔 @alexkrolick @kentcdodds @eps1lon @weyert @ifiokjr @danieljcafonso - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

Copy link
Collaborator

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this is already covered by #43108 I approve to improve chances of getting a faster merge for v10. #43108 needs to be rebased anyway.

@typescript-bot typescript-bot moved this from Waiting for Reviewers to Check and Merge in Pull Request Status Board Mar 23, 2020
@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express and removed Awaiting reviewer feedback labels Mar 23, 2020
@typescript-bot
Copy link
Contributor

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@orta orta merged commit d1581b6 into DefinitelyTyped:master Mar 27, 2020
Pull Request Status Board automation moved this from Check and Merge to Done Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants