New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update(puppeteer): product
option support
#43716
update(puppeteer): product
option support
#43716
Conversation
@peterblazejewicz Thank you for submitting this PR! 🔔 @marvinhagemeister @cdeutsch @ksm2 @SimonSchick @serbanghita @JasonKaz @davecardwell @angrykoala - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience! |
types/puppeteer/index.d.ts
Outdated
* At this time, this is either `chrome` or `firefox`. See also `PUPPETEER_PRODUCT`. | ||
* @default 'chrome' | ||
*/ | ||
product?: 'chrome' | 'firefox'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move this to a union string. eg. ProductType = 'chrome' | 'firefox';
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SimonSchick
Done, amended!
@peterblazejewicz One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits or comments. Thank you! |
4d4ca94
to
d8104ef
Compare
🔔 @SimonSchick - Thanks for your review of this PR! Can you please look at the new code and update your review status if appropriate? |
- product option support as per 2.1 - version bump - test updated https://github.com/puppeteer/puppeteer/releases/tag/v2.1.0 puppeteer/puppeteer#5137 Thanks!
d8104ef
to
716f774
Compare
@peterblazejewicz Thank you for submitting this PR! Code ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 43716,
"author": "peterblazejewicz",
"owners": [
"marvinhagemeister",
"cdeutsch",
"ksm2",
"SimonSchick",
"SerbanGhita",
"JasonKaz",
"davecardwell",
"angrykoala"
],
"dangerLevel": "ScopedAndTested",
"headCommitAbbrOid": "716f774",
"headCommitOid": "716f774e60db972586897df9b6ae51409d954300",
"mergeIsRequested": true,
"stalenessInDays": 12,
"lastCommitDate": "2020-04-29T20:22:27.000Z",
"lastCommentDate": "2020-05-11T21:02:52.000Z",
"reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43716/files",
"hasMergeConflict": false,
"authorIsOwner": false,
"isFirstContribution": false,
"popularityLevel": "Popular",
"anyPackageIsNew": false,
"packages": [
"puppeteer"
],
"files": [
{
"filePath": "types/puppeteer/index.d.ts",
"kind": "definition",
"package": "puppeteer"
},
{
"filePath": "types/puppeteer/puppeteer-tests.ts",
"kind": "test",
"package": "puppeteer"
}
],
"hasDismissedReview": false,
"travisResult": "pass",
"lastReviewDate": "2020-05-11T20:56:56.000Z",
"reviewersWithStaleReviews": [
{
"reviewedAbbrOid": "4d4ca94",
"reviewer": "SimonSchick"
}
],
"approvalFlags": 4,
"isChangesRequested": false
} |
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? Comparison details 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
@SimonSchick Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
🔔 @marvinhagemeister @cdeutsch @ksm2 @SimonSchick @serbanghita @JasonKaz @davecardwell @angrykoala - please review this PR in the next few days. Be sure to explicitly select |
@peterblazejewicz Everything looks good here. Great job! I am ready to merge this PR on your behalf. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
Ready to merge |
I just published |
…support by @peterblazejewicz - product option support as per 2.1 - version bump - test updated https://github.com/puppeteer/puppeteer/releases/tag/v2.1.0 puppeteer/puppeteer#5137 Thanks!
…support by @peterblazejewicz - product option support as per 2.1 - version bump - test updated https://github.com/puppeteer/puppeteer/releases/tag/v2.1.0 puppeteer/puppeteer#5137 Thanks!
https://github.com/puppeteer/puppeteer/releases/tag/v2.1.0
puppeteer/puppeteer#5137
Thanks!
npm test
.)npm run lint package-name
(ortsc
if notslint.json
is present).