Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: headers are optional #44263

Merged
merged 1 commit into from
May 12, 2020
Merged

fix: headers are optional #44263

merged 1 commit into from
May 12, 2020

Conversation

edewit
Copy link
Contributor

@edewit edewit commented Apr 27, 2020

for references see: https://github.com/vert-x3/vertx-web/blob/14d183b9e79f568e69fe7c5b683e61a833e6829f/vertx-web/src/client/vertx-eventbus.js#L282-L284

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #44263 diff
Batch compilation
Memory usage (MiB) 36.1 36.1 +0.1%
Type count 2145 2148 0%
Assignability cache size 110 110 0%
Language service
Samples taken 3 3 0%
Identifiers in tests 3 3 0%
getCompletionsAtPosition
    Mean duration (ms) 95.4 90.9 -4.7%
    Mean CV 31.0% 35.9%
    Worst duration (ms) 104.6 95.6 -8.6%
    Worst identifier EventBus EventBus
getQuickInfoAtPosition
    Mean duration (ms) 76.0 79.0 +3.9%
    Mean CV 25.0% 17.5% -30.0%
    Worst duration (ms) 79.7 86.3 +8.2%
    Worst identifier EventBus EventBus

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label Apr 27, 2020
@typescript-bot typescript-bot added this to Waiting for Reviewers in Pull Request Status Board Apr 27, 2020
@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 28, 2020

@edewit Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 - keep an eye on this comment as I'll be updating it with information as things progress.

This PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Have you considered adding tests to cover the change you're making? Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you.

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ❌ Only a DT maintainer can merge changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 44263,
  "author": "edewit",
  "owners": [
    "oddeirik"
  ],
  "dangerLevel": "ScopedAndUntested",
  "headCommitAbbrOid": "27c6bbe",
  "headCommitOid": "27c6bbe9cacffe92a0b276d6640ba36a94a8f03f",
  "mergeIsRequested": false,
  "stalenessInDays": 14,
  "lastCommitDate": "2020-04-27T09:43:08.000Z",
  "lastCommentDate": "2020-04-30T22:47:16.000Z",
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44263/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": true,
  "popularityLevel": "Well-liked by everyone",
  "anyPackageIsNew": false,
  "packages": [
    "vertx3-eventbus-client"
  ],
  "files": [
    {
      "filePath": "types/vertx3-eventbus-client/index.d.ts",
      "kind": "definition",
      "package": "vertx3-eventbus-client"
    }
  ],
  "hasDismissedReview": false,
  "travisResult": "pass",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 0,
  "isChangesRequested": false
}

@typescript-bot
Copy link
Contributor

🔔 @oddeirik - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board May 12, 2020
@sandersn sandersn merged commit c333203 into DefinitelyTyped:master May 12, 2020
@typescript-bot typescript-bot removed this from Needs Maintainer Review in New Pull Request Status Board May 12, 2020
@edewit edewit deleted the patch-1 branch June 17, 2020 11:56
@elibarzilay elibarzilay removed this from Waiting for Reviewers in Pull Request Status Board Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants