-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable noUnusedLocals #44272
Enable noUnusedLocals #44272
Conversation
@jablko Thank you for submitting this PR! 🔔 @Tanandara @MathiasPaumgarten @Goyatuzo @BendingBender @AyaMorisawa @LiamMartens @MeirionHughes @danwbyrne @cyrilschumacher @feinoujc @Kampfgnom @chatoo2412 @Bomret @brikou @gerich-home @chrisleck @grayrattus @Diullei @Innovation-Team @tkqubo @RReverser @e-cloud @zhu1230 @szechyjs @PAStheLoD @cbothner @zspitz @unindented @aciccarello @Roaders @skymunn @Esri @MikeTschudi @jvilk @abner @mattsains @peterblazejewicz @s0m3on3 @maxveres @federicobond @devpaul @bertoritger @twastvedt @DanielRose @meirgottlieb @princjef @Shinigami92 @NoxHarmonium @ArrieAgilite @johnjardin @agilitehub @menthays @scaret @wangjie-agora @ysclyy @milesj @bvalosek @maxchehab @dmitriismitnov @afshawnlotfi @lochiego @littlepiggy03 @qm3ster @ChristianMurphy @evan-hughes @akumina @jasonarden @MarshHawk @msn0 @jjeffery @petebeegle @hoo29 @pascalwhoop @blforce @rk-7 @alexmalcoci @dolanmiu @CaselIT @cbaptiste @haroenv @samouss @keichinger @neryortez @antoinerousseau @lucapasquale @adeve @dan-grayson @PeterEsenwa @bodinsamuel @rscotten @kopertio @gburgett @taoqf @ptrdu @claasahl @matthoang08 @sandersn @appcelerator @ffMathy @zaqqaz @cmaddalozzo @garyking @Shearerbeard @breeze9527 @agasbzj @scottescue @andyhopp @MattiLehtinen @alien35 @ldrick @grothem @jewbre @kevincharm @joeriks @superheri @laurentiustamate94 @Asido @danmana @HintikkaKimmo @seikho @jonnysparkplugs @rogierschouten @tstelzer @wokim @mnahkies @abreits @nfantone @zelein @fongandrew @thomasthiebaud @xt0rted @diegovilar @thorn0 @calebstdenis @leonard-thieu @scipper @rolandzwaga @michelsalib @adidahiya @rasch @codyschaaf @chivesrs @lassebn @sclassen @renjfk @Odrin @marctalary @bradfordwagner @borislavjivkov @Ritzlgrmft @Dona278 @wcomartin @terrawheat @mbutsykin @deenairn @cyrilgandon @scatcher @julienpa @AkosLukacs @Toxantron @jpmnteiro @mkp05 @jlz27 @reppners @vvakame @Kukks @mthamil @rerezz @david-gang @stephenlautier @tyronedougherty @kenfdev @dona278 @nkovacic @blbigelow @PeterHajdu @geertjansen @eknowles @pgrm @daltin @paullessing @anteriovieira @bastienmoulia @vmishevski @rufusl @mistic100 @rafw87 @miffels @park9140 @gkalpak @falsyvalues @RomanoLindano @samherrmann @AdamSantaniello @Biegal @mdekrey @mkannwischer @trodi @muenchdo @GabrielGil @yrtimiD @ry8806 @alfiej @Igorbek @matiishyn @mikehaas763 @marknadig @thgreasi @CalvinFernandez @nickveys @mjurisic @rwwilden @ranndev @thSoft @horiuchi @bateast2 @qinfchen @A-Babin @supaiku0 @southrock @hisham @theluk @Gustavo6046 @aomarks @brynbellomy @plylrnsdy @balupton @mcchatman8009 @jonfreedman @SomaticIT @roland-reed @shermendev @matheusgrieger @y13i @tkrotoff @danielsogl @susam-projects @CasperSkydt @uchilaka @bradleyayers @kostspielig @Slessi @afholderman @darkwebdev @chenyang-biu @shantmarouti @ffflorian @kyo-ago @kilghaz @wsmd @chrisdrackett @nchase @useffc @voidpumpkin @martincostello @brainded @markwolff @jpiyali @barustum @rlbaxter @Athenkosi-Mase @pluma @arash16 @bsvensson @JeffJacobson @greuze @crevil @brianloveswords @ivangabriele @mymindstorm @arcticwaters @tlaziuk @eps1lon @cakoose @ondkloss @hookclaw @dioris-moreno @me @mrmlnc @hvoecking @samverschueren @skysteve @Richienb @DanielMSchmidt @CSLTech @ExE-Boss @kylejlin @ljharb @hallettj @kmccoan-allocadia @tkqubo @tasyp @filipposarzana @fpascutti @lukaselmer @RagibHasin @DefinitelyTyped @remisery @jgeurts @microshine @jt000 @nicoabie @LinusU @seryl @KostyaTretyak @brunolm @kryops @nkappler @borisyankov @kern0 @Penryn @fenying @pascalmartin @Dmitri1337 @erossignon @Juliiii @brendtumi @hirochachacha @patarapolw @elisee @afharo @rhymmor @humulus @Goldsmith42 @albertywu @MeLlamoPablo @rafsawicki @JakubJirutka @pyrho @rubensworks @warpdesign @dijimsta @lstanden @leedrick @benhjames @mtgto @toedter @Mory1879 @Scipion @johngeorgewright @gr2m @GlenCFL @smhxx @lierdakil @aminya @soywiz @bdjeffyp @ra-gg @Perlmint @ForbesLindesay @westy92 @ianhowe76 @dauledk @dancrumb @pwrnrd @CatGuardian @neshanjo @homesar @adrianchia @mdurrant @bkotrys @marknelissen @tylerlindell @advancedrei @carusology @goldcaddy77 @lfaudreejr @willcaul @wilfredtan @rhysd @janwo @darkl @a904guy @valepu @glenroy37 @spcfran @jeremyben @odnamrataizem @murt @slavafomin @kingdango @keika299 @NeekSandhu @senukartur @szhu @webbiesdk @bmdixon @tbekolay @chrislopresto @niik @mlamp @vshlos @foqal @darbio @skarum @StefH @tobyhede @buggy @wwwy3y3 @OrthoDex @MichaelMarner @daniel-cottone @kostya-misura @coderbyheart @palmithor @daniloraisi @simonbuchan @Haydabase @repl-chris @aneilbaboo @jeznag @louislarry @dpapukchiev @ohookins @trevor-leach @jagregory @dalen @loikg @skyzenr @redlickigrzegorz @juancarbonel @pwmcintyre @alex-bolenok-centralreach @marianzange @apepper @apalumbo @jasonthomasgray @nathanoertel @Deadarius @threesquared @jcaffey @mattmeye @albertovasquez @ajcrites @JoshuaKGoldberg @tylerkrupicka @ruslan-molodyko @TheDSCPL @dkniffin @stevenhankin @mgdodge @Charles-Gagnon @anthonydresser @kburtram @kenvanhyning @AndrewGaspar @antiveeranna @armanio123 @dmorosinotto @Azure @Rupertofly @PatPL @JasonHK @outring @mohsen1 @yortus @marvinhagemeister @johnnyestilles @billykwok @coffee-cup @jpap @rpetrich @baxtersa @bcherny @j-f1 @mgroenhoff @Jessidhia @khell @Lyanbin @PlayMa256 @dlgrit @TeamworkGuy2 @czbuchi @cdiddy77 @nvivo @kenjiru @jjoekoullas @jgonggrijp @zieka @craigbrett17 @delphinus35 @eirikhm @hejiang2000 @lgrignon @zhamid @sventschui @razorness @confususs @Nyamazing @alphaleonis @jlujan @vvatanabe @Retsam @darioblanco @minddocdev @micmro @ipcjs @adamzerella @Acidic9 @evelijn @pvomhoff @TepigMC @roryokane @alechill @jbencook @pe8ter @s73obrien @urish @lucasriondel @harikv @moonpyk @vesse @nwtgck @nchaulet @adrianhopebailie @drudge @jasonharrison @alexndlm @ealmansi @cjbarth @codeanimal @IOAyman @dstapleton92 @DavidBR-SW @RafaelKr @branoholy @jeremejevs @xinxinran0221010 @micksatana @carrrywu @SimonSchick @tobenna @Ovyerus @pocesar @maozedong @stoneChen @cnjack @Morfent @matrumz @sant123 @loghorn @andykais @mrkstwrt @danmarshall @Epskampie @sumegizoltan @helenanderson @nycdotnet @googol @mhegazy @Evgenus @Patman64 @dduugg @orentrutner @riggs @yuhr @caguiclajmg @CjS77 @stefanhuber @mudkipme @lautarodragan @feross @Bartvds @reconbot @beaulac @skellock @mamachanko @TooTallNate @danikaze @jeffhuys @henriquetorquato @fskorzec @erichillah @nrlquaker @l-jonas @LogvinovLeon @ksmigiel @slawiko @sodatea @lhecker @falsandtru @d-ph @ebk46 @KonstantinLukaschenko @moeinio @rmartone @mkohlmyr @rksm @HenryNguyen5 @Gilthoniel @santialbo @vilic @dreampulse @blendsdk @jwalton @tbounsiar @kimcoder @quentin-ol @octo-sniffle @rogatty @AJamesPhillips @jineshshah36 @TimonVS @danielmachado @vbortone @konpikwastaken @kanup @icereed @stannynuytkens @rdeneau @denisname @AndersonFriaca @aleksandar-manukov @jannikkeye @CheCoxshall @mustafasalahuldin @niemyjski @mouse0270 @robert-voica @LKay @dbeckwith @johnmbaughman @gricey432 @albinsunnanbo @jbtronics @BradyLiles @derikwhittaker @heatherbooker @katonap @bayitajesi @nakupanda @cnboland @cherrry @sankaku-deltalab @jbaldwin @haydos89 @vemoo @jackall3n @sinchang @smrubin @sharno @acdr @sedenardi @chlela @saoudrizwan @krzysztofzuraw @Chnapy @kondi @eheikes @ElliottCampbellJHA @chrootsu @karol-majewski @PaulLockwood @scriby @Donaldcwl @jussikinnula @JTOne123 @marionebl @joeskeen @aznnomness @yuma84 @dsifford @davecardwell @AndrewLeedham @nju33 @justingrant @lirbank @bricka @Kocal @zaneli @burnnat @chroventer @ciffelia @VladimirGrenaderov @maxbogus @rhencke @bgrieder @JProgrammer @marshall007 @weeco @blaugold @iamolegga @koblas @bondz @wuha-team @aleccool213 @kjellmorten @pc-jedi @lenovouser @hados99 @borys-kupar @remko79 @levibostian @kevenleone @remcohaszing @silkentrance @amikhalev @olivr70 @dex4er @ashpabb @jasonswearingen @enlight @raybooysen @stevehipwell @timolinn @jacobbaskin @rsamec @MugeSo @gvanderest @cappellin @danny8002 @believer @mcliment @gerinjacob @denyo @dmitryshindin @timn @natemara @iansan5653 @GausSim @dominikeinkemmer @paulmelnikow @Delagen @kmvi @RetroChrisB @ArrayKnight @ignocide @newclear @englund0110 @lucasmciruzzi @MacRusher @vborodulin @Vincent-Pang @mutech @clark-stevenson @Gelio @matracey @joshbatley @Mikhus @brutalimp @ashlanderr @frederickfogerty @AustonZ @kalbert312 @sgregoire @matchilling @vpicone @metonym @apatryda @ChanceM @adierkens @r3nya @downace @mastermatt @forivall @akvlko @jedmao @urielch @QuangDuong120198 @bioball @saboya @tyler-hoffman @AbigailMcP @pushplay @boromisp @samalexander @twooster @Zuzon @hnipps @golyalpha @KeyboardSounds @soyarsauce @jrafidi @morgansierrasnyder @crocsx @jordanadams @ivoisbelongtous @AGBrown @mwistrand @joshuakgoldberg @shaunluttin @Naktibalda @ErikSchierboom @bparan @CXuesong @joeykilpatrick @kclnn @clementprevot @Kuniwak @lazerwalker @mattbishop @cliffburger @mattlewis92 @asvetliakov @dimitardanailov @adjerbetian @mattvperry @kazimanzurrashid @ulrichheiniger @chrisgodsey @mizunashi-mana @swist @kuzn-ilya @harm-less @jounisuo @nmalaguti @AviVahl @delta62 @jedigo @cbowdon @cafesanu @colbywhite @NewDark90 @jacobez @jameschao @iskandersierra @Gebatzens @samhinshaw @Xananax @cspotcode @anuti @FabienLavocat @KentarouTakeda @larrybahr @mernen @josefpaij @guillaume-ro-fr @archy-bold @braincore @frabnt @alexdor @mahnuh @Conrad777 @adripanico @wertzui @lekoaf @ElianCordoba @indigolain @ricardo-mello @rnicholus @mrjack88 @canoceto @nobu222 @Marcoru97 @tonybadguy @mtgibbs @psimonski @affilnost @sunnyrjuneja @raudabaugh @borrajo @chartmogul @HenningKuehl @Seally @idchlife @blittle @wmaurer @umarniz @LiJinyao @chennakrishna8 @AzSiAz @trevorhreed @JacobFischer @zacnomore @sliverb @davidmpaz @adamsbloom @invliD @mpacholec @matthewkimber @otiai10 @couven92 @RReverser @sreimer15 @MatCarlson @ekinsol @tregagnon @echoabstract @spasma @niikoo @AdamLay @pine613 @mzsm @pyle @Serabe @craigrbruce @brandonrisell @samuelmaddock @malob @DeTeam @jpevarnek @wittwert @stuartlong @viktorpegy @Hikariii @sinziananicolae @corno @JKillian @mradamczyk @joshmccullough @uhyo @RamanBut-Husaim @gcastre @GolaWaya @JamieMagee @connorjayfitzgerald @ClearBlade @clentfort @jasongi-at-sportsbet @sashashakun @kayahr @athasach @ChaosinaCan @OpportunityLiu @alvaromartmart @janslow @arylo @netroy @icopp @impworks @markwongsk @hellochar @jasperjn @jfcere @tanfonto @qlonik @vaskevich @mprobst @favna @MartynasZilinskas @JLuboff @marckassay @tpluscode @aleung @farzadmf @Pr1st0n @migueldevmt @doniyor2109 @geoffreak @devlee @prashaantt @holwech @charlee @mihailik @nrbernard @rileymiller @toddself @ysulyma @azoson @kylesferrazza @morphatic @JorgenVatle @scarabedore @jaymeh @Airlun @jameswlane @BeeeQueue @ecraig12345 @katsanva @JohannesHoppe @ksocha @Ailrun @in19farkt @Yavanosta @mtraynham @manuth @blturner @gilleswaeber @akarienta @zbarbuto @rafamel @felixge @iclanton @derekcicerone @alxHenry @hagl @swese44 @75lb @CzBuCHi @Dvorsky @hiraash @Jason3S @screendriver @martinmcwhorter @seangenabe @zuzusik @tzupengwang @nicojs @fennibay @wolfgang42 @goblindegook @pavasich @psnider @denis-sokolov @yurist38 @rburgt @neilbryson @dublicator @rhys-vdw @EricCrosson @jmarianer @DenisCarriere @Blasz @rzhw @jppellerin @RWander @forrestbice @jndonald3 @Arylo @anton-drobot @ArcticLight @ethanresnick @EvanHahn @mikaelbr @pinguet62 @chrisgedrim @moshegood @xzyfer @lewisvail3 @0x6368656174 @AndreasGassmann @douglasduteil @tonystonee @tinganho @NattapongSiri @pasieronen @xstoudi @sbutler2901 @JipSterk @ofrobots @ericbyers @guusdegraeve @dfreeman @theosherry @nicolashenry @vadim-v @antonkarsten @domness @kernhanda @rath @heycalmdown @aboveyou00 @cag @xeningem @hmajid2301 @vladkampov @ben-ng @Nemo157 @elyscape @vanthiyathevan @pine @btomw @lith-light-g @Rokt33r @paroxp @WangZishi @jkeylu @SrTobi @flying-sheep @avin-kavish @hendrikmaus @Lordnoname @timbru31 @gjunge @peitschie @tuvokki @lordazzi @jkfb @KaiWalter @lobo87 @Justin-Credible @bitjson @jab @broder @rbuckton @mfdeveloper @makepost @roblabat @maouida @fluggo @gjuchault @Ionaru @santiagodoldan @zero51 @pokonski @lukyth @biltongza @iRoachie @Kimahriman @humrochagf @bevalorous @alan-agius4 @blissi @panuhorsmalahti @YuJianrong @gallowsmaker @jordansexton @jgoz @Asana @vsiao @evilangelist @gyohk @phuvo @JuanJoseGonGi @winup @koooge @DouglasAntunes @connor4312 @dklmuc @sarunint @knuthelgesen @Alorel @schmuli @iebaker @nordfjord @TijmenW @Diullei @0xdeafcafe @brownstein @awendland @misak113 @maximlysenko @giabao @rrogowski @stpettersens @winksaville @markis @ilich @slikts @skovy @bengry @erik-kallen @rictic @djcsdy @EricByers @wcarson @abraaoalves @jan-molak @isoung @petermorlion @DonJayamanne @davidjgoss @albertossilva @ltetzlaff @thmiceli @OfficeDev @akrantz @mscharlock @davidchesnut @cyberblast @wKovacs64 @falconertc @jp7677 @Keysox @phreed @wy193777 @ypconstante @janniclas @cerberuser @gsbelarus @peterjferrarotto @spaxe @appleparan @pipboy3000 @tomwanzek @gustavderdrache @MatthiasJobst @vbinithyanandamv @cronco @ledragon @lk-chen @hansrwindhoff @locknono @Ledragon @BTOdell @DomParfitt @uncovertruth @arrayjam @paolostyle @kindy @rulonder @henriquefm @johnwalley @brspnnggrt @robertmoura @mc-petry @Frankrike @vilterp @rustedgrail @rokt33r @sonic3d @rroylance @singuerinc @teoxoy @mrhen @dineshsaravanan @mhintzke13 @Silver-Connection @omidkrad @pragmatrix @CNBoland @andy-maca @SammyG4Free @jimhartford @Arik-neKrol @maixiu @baywet @RohdeK @danplisetsky @HeeL @balrob @aicest @rupertavery @SirMartin @smasala @nertzy @ToastHawaii @samhh @hustonf @nickiannone @cgwrench @lal12 @privateOmega @Sicilica @ckknight @vkorehov @whtsky @swook @galtalmor @zamb3zi @brasten @npenin @kristianmitk @enaeseth @waspothegreat @plantain-00 @jbethke @dflor003 @souldreamer @ZauberNerd @remojansen @bcaudan @aluanhaddad @marco-eckstein @ArcaneDiver @IbtihelCHNAB @niklasf @saadq @pocka @tobiaskraus @iarroyo5 @vdh @Diasiare @joaomoreno @joscha @Toilal @jacobbubu @adam-hanna @thomastilkema @TareqElMasri @stevechun @hammadj @santiagofm @maxkomarychev @mike-engel @devexpress @skubarenko @Litee @mkozhukh @chriscamicas @johnjbarton @dcrusader @otociulis @rubenswieringa @nightillusions @slowtick @diegodalbosco @MTRNord @nicholaiii @GoupilRobin @jamesgeorge007 @szdc @moc-yuto @rtfpessoa @majames @werewolfe @nyancodeid @juandaco @bangbang93 @andy-ms @aynurin @andrew--r @OiCMudkips @jasonhaxstuff @lolPants @dylhack @k3rn31p4nic @championswimmer @Ragg- @marcolanaro @sangaman @JRegimbal @ryansonshine @angelmerino @Maxr1998 @jonegerton @nlaplante @isac322 @lazarusx @meisenzahl @thegecko @CameronDiver @p4sca1 @stuartthomson @giggio @Jack-Works @NoelAbrahams @brettferdosi @ctstone @yifanwu @DanielRosenwasser @olebedev @vansimke @43081j @diagramatics @eliasmeire @AppLover69 @gbidkar @giladgray @johandavidson @Steve-Fenton @bazuzi @FlowCrypt @Exigerr @dotnetnerd @swanest @ZombieHunter @brussee @milanjaros @vincentlanglet @kerimdzhanov @krenor @domarmstrong @dsagal @parzh @steven-joyce @joeflateau @vanessa-lyn @krishnaglick @cwmoo740 @josuedevmark @Lunrtick @Guanyunhan @MunifTanjim @dmitryrogozhny @eelco @ghotiphud @schwers @michael-yx-wu @willisplummer @smvilar @sulf @pablopunk @claudiopro @khawkinson @1cheese @chinkan @jaydubu @spkellydev @zskovacs @pwelter34 @abruzzihraig @dandelany @WholeMilk @quas94 @xperiments @VorobeY1326 @renuo @tedbcsgpro @dwaxweiler @PikachuEXE @arnederuwe @crycode-de @bartduisters @lhhong @AlphaHydrae @strax @kinwa91 @BlueSpire @andrycodestuffs @mdezem @Ptival @namerci @yushulx @jbh @lincoln2018 @Tom-Dynamsoft @dsueltenfuss @danvk @thijskuipers @francoismassart @alvaro450 @SpartanLabs @ramondeklein @stephentuso @NaridaL @DeadAlready @nikeee @satyarohith @Ebongarde @randomnerd @xieisabug @AntiMoron @liveangela @Ovilia @iRON5 @bilalucar @tmtron @dwhitney @ruixuel @robert-wettstaedt @ksm2 @michael-whi @erikma @johnridesabike @magonzalez9 @sheperdwind @naver @syncfusion @benliddicott @shantanubhadoria @bfsmith @ddunkin @ahmadferdous @brabster @deerawan @YonatanKiron @dasdachs @Jungwoo-An @gamesmaxed @mfatihmar @jbw91 @djpereira @cortopy @jkleinsc @shiftkey @malept @hikiko4ern @saranshkataria @franklixuefei @plgregoire @dwieeb @arbuztw @apavlinovic @garyaparker @gurisko @blankstar85 @qqilihq @bttf @dwickern @chriskrycho @theroncross @mfeckie @alexlafroscia @mike-north @BryanCrotaz @jamescdavis @tansongyang @simonihmig @scalvert @tdukart @jasondibenedetto @Nicell @elvis-wolcott @seoyunho @iKBAHT @ifiokjr @dbrgn @sliker @zakki @periklis @kbumsik @jgeth @onigoetz @johnnyreilly @konne @aliceklipper @renanmav @MarianPalkus @NoHomey @jwbay @huhuanming @thovden @hotell @mateuszsokola @braidencutforth @erickzhao @jtomaszewski @nali @kimehrenpohl @mateusz-meller @knegusen @julien-c @fitbit @NotWoods @harryshipton @bschlenk @zozoens31 @dlimkin @olsio @simondel @rayosu @g3rrydanc3 @pmdartus @bradzacher @ikatyang @JounQin @mysticatea @teppeis @peter-scott @tswaters @stasberkov @createdbyjurand @cherryblossom000 @tuttieee @strajuser @sanex3339 @antross @quezak @doppio @Schnillz @karl-run @tombarton @jpsullivan @imsuwj @kookster @chrisrhoden @ahstro @flcdrg @yasupeke @weareoutman @0x326 @scottleedavis @afroozeh @snakedrak @Akuukis @corps @fcastilloec @SanderDeWaal1992 @christianchown @carnesen @jfm710 @intolerance @martintreurnicht @dawnmist @incleaf @robertying @CMUH @puneetar @dfrankland @etruta @remyoudemans @Nox-404 @scottharwell @shreyjain1994 @nenadalm @kevinstubbs @silkimen @vosatom @iMobs @mathsalmi @Mister4Eyes @NomNes @tdolsen @evanshortiss @yhaskell @dcbartlett @ulrichb @Danscho @carboneater @niekvb @jsinglet @lindsaykwardell @atd-schubert @kacepe @Sl1MBoy @milan-mimra @xieyubo @sjoseph7 @Cellule @Akim95 @mathe42 @AmirTugi @tough-griff @jdforsythe @ajliv @kripod @weffe @19majkel94 @samijaber @aereal @JoseLion @dwrss @andoshin11 @jacobbogers @builtinnya @ry7n @fiznool @joshhendo @AylaJK @xiaohanzhang @joaovieira @michal-b-kaminski @isman-usoh @inglec-arista @simmons8616 @gstamac @noticeMaker @macedigital @brian428 @katyo @AlexHankins @neolwc @oklemencic @joewashear007 @mrand01 @bmartinson @RogerioTeixeira @BradleyHill @bmkrol823 @glenngartner @codertx @mike667 @nataliemarleny @menushka @oyvindjam @nialna @amritk @mahmoudzohdi @fluidsonic @CvX @noctishsu @VictorHom @DogPawHat @antonsamper @timswalling @stackbuilders @sestrella @elcuy @OlivierKamers @bensw @basp @testica @TastefulElk @delprzemo @Quramy @lukerielley @cdhgee @borisvasilenko @SPWizard01 @EnableSoftware @yoursunny @rollercodester @RobinTail @rarmatei @shinnn @leomelzer @tuelsch @drowse314-dev-ymat @metsawyr @arturovt @pmeller @kmxz @sHooKDT @xStrom @AbraaoAlves @j2L4e @NickBolles @RazzM13 @DadUndead @TimMensch @jordanbtucker @deskoh @nikewu @tamird @merrywhether @chrissinclair @matttennison @quentinbouygues @mtsmfm @captain-igloo @ChenNima @dobogo @newraina @loyd @waitingsong @keerthi16 @KiranNiranjan @Buzzertech @weslenng @iamstevetran @rmchndrng @yinzara @smac89 @richardo2016 @rudi-c @g-rath @DaIgeb @chrismbarr @HitkoDev @huan086 @hbomark @DavidSichau @andypyrope @itslukej @ngbrown @kotarella1110 @curtstate @fpsscarecrow @dotdotcommadot @karak @jsmnbom @troywweber7 @pepaar @stephenjelfs @ilivit @thewizarodofoz @kevinpollet @mfedderly @Uaman @iansadovy @flexmonsterowner @flexmonsterteam @irakulchytska @clmcgrath @wagich @aheber @PabloDiablo @jonathanhedren @kubosho @gsino @mayuki @dmurvihill @wanganjun @burlandm @Anticom @admiralsmaster @animify @ryan10132 @martinnuc @huy-nguyen @jamesnimlos @tcaesvk @DingWeizhe @mabidina @buzzertech @blushingpenguin @pash90 @stkb @GiedriusGrabauskas @xbim @mrk21 @markusmauch @grabofus @marcind @eramdam @RandScullard @Teoxoy @p-kimberley @Strum355 @yavanosta @shuntksh @wrboyce @Autodesk-Forge @dukedhx @alansmithnbs @tyler-johnson @flqw @alepee @amitbeck @thewilkybarkid @kruncher @today- @suXinjke @endel @alampros @kbukum @wlegate @pmccloghrylaing @sw-yx @oleavr @bahlo @cwoodland @johnny4753 @glenndierckx @mike-marcacci @OguzhanE @ikokostya @midknight41 @mees- @jrockwood @sangdth @HiromiShikata @pscanf @mtsg @terrymun @locke23rus @chrispanag @nadershamma @jodiwarren @Feinbube @milanpro @skvale @rohitkr @shivarajkv @jeancroy @jkillian @reyronald @alex-deas @narainsagar @load28 @charrondev @ivansieder @Lange @Laubi @sgtfrankieboy @grant @gatsbimantico @flawless2011 @Maxim-Mazurok @Bolisov @joshuaobrien @scttcper @vfernandestoptal @andreidigori @MendyBerger @CodeAnimal @rynclark @jerray @bonnici @HandyG52 @excelulous @cobster @icholy @nakakura @Gaelan @vargind @serranoarevalo @joshgachnang @calvinchhour @zifahm @ajafff @mszczepanczyk @vincekovacs @TheMallen @impankratov @looorent @jucrouzet @FlorianSchwingenschloegl @Leko @thde @gatimus @atatanasov @darthapo @qfox @khoi-fish @andersk @BehindTheMath @sjx233 @ollien @mattijskneppers @tatchx @nbabanov @auzmartist @surtr-isaz @qcz @voy @whatasoda @afromogli @bryanforbes @durad @garfty @gjednaszewski @maartenvanvliet @mlejva @mrcageman @NorthwoodsSoftware @wkl007 @jafaircl @PopGoesTheWza @dhayab @ogawa0071 @ThomasdenH @ben-tbotlabs @caiertl @carboncollins @mickdekkers @leonyu @winfinit @honzabrecka @DeividasBakanas @jpowell @PaitoAnderson @marcuslongmuir @kamthamc @abonander @maple3142 @tyler-murphy @RodneyJT @grapswiz @clomie @danludwig @gmoore-sjcorg @mlcheng @IvanBisultanov @glebm @shrujalshah28 @dckorben @indrimuska @enanox @mxl @xaolas @mrmcnerd @svenkreiss @bolatovumar @gauthierm @demensky @life777 @simonhaenisch @gshigeto @Bat-Orshikh @Dashue @Fluccioni @Radu-Raicea @fstanis @ozotek @mumpo @socsieng @stijnvn @wingsbob @ryanwilsonperkin @phawxby @ivywit @Huachao @hberntsen @claude @ctumolosus @proudrain @lfades @eritikass @MatiasOlivera @jwaldrip @filipows @arvitaly @nitintutlani @Grelinfo @nayni @aecorredor @schfkt @runk @mhfrantz @agnoster @scalder27 @kotas @nikolay-borzov @DethAriel @rafaeltavares @RohrerF @vkrol @brentj73 @cwalv @matt-sungwook @keith1024 @7jpsan @liorm @Forzoom @jeffmay @basarat @codebelt @ProbablePrime @philipbulley @leomeloxp @AdemHodzic @dddotsev @maroy1986 @amanmahajan7 @jordyvandortmont @alvarollmenezes @vizeke @aravindarun @tomc974 @Aankhen @k-kagurazaka @andrewiggins @ntnyq @maxfouquet @TokugawaTakesi @peterjuras @romain-faust @berwyn @tscpp @aankhen @agnislav @Aqours @ChristopherHaws @dudeofawesome @robertbullen @hexf @garthk @dherges @steller @WeslleyNasRocha @milkisevil @codler @rafaelsouzaf @jhsimms @Mutmatt @kenhowardpdx @todd @BlooJeans @btmorex @laurence-myers @cglantschnig @GaelMagnan @ralekna @rokoroku @dankraus @rafaelkallis @aconanlai @zaphoyd @thewillg @AnandChowdhary @myovchev @RecuencoJones @freisenhauer @legraphista @SimchaWood @akashishu777 @woitechen @Yama-Tomo @baiyufei @micronaut @flyfishMT @rafalwrzeszcz @dodomorandi @medns @diogofcunha @lukeggchapman @tup1tsa @davidm77 @msutkowski @TvrtkoM @sedwards2009 @lokidokicoki @hakubo @weekens @lookuptable @jim-at-jibba @dborysov @PavelPZ @vuorinem @batuhanw @bluehatbrit @chdanielmueller @Josh-ES @fx88 @DaSchTour @kylevogt @AlejandroMoran @kentarouTakeda @segayuu @TotomInc @matthewbryant95 @hgwood @iwllyu @alvis @notbobthebuilder @jlismore @sourrust @titan @sergey-buturlakin @danielnixon @h-shiratsuki @crunchie84 @cmanou @jgainfort @brookback @beraliv @drax98 @jamesreggio @rskrz @mcaneris @pimterry @Aurimas1 @dintopple @OiyouYeahYou @nicholashza @cjurango @TrueLecter @rikuayanokozy @erykwarren @CarsonF @deevus @bumbleblym @rwhepburn @tan9 @sschocke @Ristaaf @dcloudio @staticfunction @paambaati @stripedpajamas @sapfear @marcogrcr @alexu740 @nloomans @lummish @Raigen @jabreu610 @steprescott @zebMcCorkle @L2jLiga @dirk @KeesCBakker @eeemil @jphenow @ricosandyca @jmvrbanac @stof @RigoTheDev @MichalPodeszwa @she11sh0cked @sebastinez @mrcabellom @bambutz @spacejack @jmfirth @maks3w @igorsechyn @FindQ @smbell @ypresto @101100 @kou029w @dippi @nacho4d @agov @nickbclifford @iammatis @tobico @bmatcuk @D0miH @iocat @arminbaljic @IgniteUI @tai2 @MasterOdin @noamalffasy @hkjeffchan @brettm12345 @coldacid @apexskier @iaarnio @lukewestby @gaetansenn @deanpienaar @Jimexist @IchordeDionysos @Baskerville42 @kikuchy @rdoursenaud @amiram @Antoine38660 @lanthaler @omaishar @evolkmann @dsci @shiwano @solkaz @marcinporebski @kfarnung @lukostry @shatodj @justinanastos @MancunianSam @philipisapain @ahz @dpetrezselyova @timia2109 @dmester @ppathan @jouderianjr @bang88 @synarque @kwkelly @chigix @idmadj @aimee-gm @pdcastro @peping @mikhail-monchak @cdoe @malithrw @salbahra @onatm @bingo4508 @spencerwi @voxylu @fdnhkj @molnarm @shalomdotnet @anahkiasen @LeonMontealegre @bennett000 @dtinth @turadg @inversify @AlCalzone @Karel-van-de-Plassche @JamesJGoodwin @javonharper @aliarham11 @br8h @shaharmor @palindrom615 @funthing @tingwai-to @pettyalex @tianlinle @demian85 @monaka @fogsh @dahool @phillips1012 @simonschick @cabralRodrigo @vutran @heygambo @nieltg @VitorLuizC @termosa @shawnkoon @evangeloszotos @petester42 @kalley @jedster1111 @wbhob @RyotaMurohoshi @tedre191 @mo @elhaard @csrakowski @devlato @sicilica @avielfedida @toddlucas @avidenic @malinushj @jason0x43 @loryman @zache @sridharmallela @nlisgo @elvisvoer @tsachis @alitaheri @syamatoo @theodorejb @davidparsson @gmoothart @lukas-zech-software @Engineer2B @cyungmann @devoto13 @fdim @kolodny @stephenfarrar @zvirja @djungowski @AnthonyMacKinnon @sgravrock @shairez @DmitryEfimenko @svi3c @matthewjh @sjelin @jimlloyd @hrl7 @darti @ptlis @mdocter @MrBigDog2U @samael65535 @erikburt @zaguiini @tbureck @alexjoverm @epicallan @JamieMason @ahnpnl @UselessPickles @sebald @andys8 @antoinebrault @quassnoi @Belco90 @tonyhallett @ycmjason @devanshj @pawfa @regevbr @erbridge @pjoe @mike-d-davydov @geovanisouza92 @deadNightTiger @lvl99 @joemitchard @jonasheinrich @seidelmartin @aldentaylor @immanuel192 @sehsyha @arx-8 @m-tomczyk @KOPTE3 @orta @rkesters @rlidwka @ujvzolee @workshop2 @xtrimsystems @marcinobiedz @HipsterBrown @nflaig @boothwhack @vichyssoise @pandawood @hikoma @github-account-because-they-want-it @lokeshpeta @choffmeister @tasoili @jasons-novaleaf @seanski @Guuz @ksummerlin @nwolverson @seikichi @benjaminjackman @s093294 @JoshStrobl @DickvdBrink @King2500 @martin-badin @humana-fragilitas @stever @dkulyk @PerKastman @TekuConcept @patsissons @rimig @intelorca @Ty3uK @iain8 @kbytesys @laszlojakab @vladeck @hasaki @Promact @Seltzer @jblank @nickwph @viqashussain @astegmaier @HamidTheGeek @martinduparc @mardaneus86 @sunetos @dennisahlin @RoyGoode @BenLorantfy @adamcoulombe @dnadolny @fdecampredon @abedi-ir @Nitecube @hosni @totpero @maxackley @felipedgarcia @piraveen @yeganemehr @Pro @jamescurran @pjmagee @FinelySliced @Wkalmar @evil-shrike @thelfensdrfer @ejsmith @johnrutherford @lijunle @majorsilence @FUNExtreme @pgaske @vinayak-garg @nestalk @ForNeVeR @tigerxy @anwarjaved @bdukes @JeremyCBrooks @Jhsosa @dougajmcdonald @drarmstr @tlent @pikachuexe @omni360 @yutod @nreynis @Kallu609 @naftis @mwmccarthy @kanatkubash @ethanfrey @wrummler @guoyunhe @viralpickaxe @skyitachi @pbalogh @sclausen @al2xed @yitzchok @McFlat @brieb @bjacobel @willtn @minodisk @palmfjord @netes @amphro @tnoonan-salesforce @whiteabelincoln @catalandres @kenhuman @douglascayers @Arlodotexe @xyleen @rosinbum @dharkness @gunnim @shiver-me-timbers @DovydasNavickas @superhawk610 @NN--- @senyaarseniy @micahriggan @cyrilletuzi @lucianbuzzo @rolandjitsu @juanjoDiaz @dangoo @denisyilmaz @ZhangYiJiang @Esemesek @peterkooijmans @chiangf @alejo90 @errietta @adamvig @joepkockelkorn @dbowring @jason076 @no23reason @surenkov @vladjerca @WesselKuipers @JimmyBoh @many20 @benstevens48 @danielheim @vpk @rlgod @kettil @RunAge @amberjs @lleios @jemerald @frankbrullo @leonmontealegre @auriou @kamakiri01 @randombk @mauimauer @HookyQR @olamothe - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
Most of the const dev = cd.ShowSelectDevice();
if (dev && dev.Type === WIA.WiaDeviceType.CameraDeviceType) {
const item = dev.ExecuteCommand(WIA.CommandID.wiaCommandTakePicture);
} is taken from the MS documentation sample here, written for VB6: Dim dev 'As Device
Set dev = CommonDialog1.ShowSelectDevice
If dev.Type = CameraDeviceType Then
Dim itm 'As Item
Set itm = dev.ExecuteCommand(wiaCommandTakePicture)
End If
|
Not sure. You could be doing
precisely to test (the typings of) |
@jablko Thank you for submitting this PR! This PR touches some part of DefinitelyTyped infrastructure, so a maintainer will need to review it. This is rare - did you mean to do this? Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. 🔔 @Tanandara @MathiasPaumgarten @Goyatuzo @BendingBender @LiamMartens @AyaMorisawa @MeirionHughes @danwbyrne @cyrilschumacher @Kampfgnom @chatoo2412 @feinoujc @Bomret @brikou @gerich-home @chrisleck @grayrattus @Innovation-Team @Diullei @tkqubo @RReverser @e-cloud @zhu1230 @szechyjs @PAStheLoD @cbothner @zspitz @unindented @aciccarello @Roaders @skymunn @Esri @MikeTschudi @jvilk @abner @mattsains @peterblazejewicz @s0m3on3 @maxveres @federicobond @devpaul @bertoritger @twastvedt @DanielRose @meirgottlieb @princjef @Shinigami92 @NoxHarmonium @ArrieAgilite @johnjardin @agilitehub @menthays @scaret @wangjie-agora @ysclyy @milesj @bvalosek @maxchehab @dmitriismitnov @afshawnlotfi @lochiego @littlepiggy03 @qm3ster @ChristianMurphy @evan-hughes @akumina @jasonarden @MarshHawk @msn0 @jjeffery @petebeegle @hoo29 @pascalwhoop @blforce @rk-7 @alexmalcoci @dolanmiu @CaselIT @gburgett @haroenv @samouss @cbaptiste @keichinger @neryortez @antoinerousseau @lucapasquale @adeve @dan-grayson @PeterEsenwa @bodinsamuel @rscotten @kopertio @taoqf @ptrdu @claasahl @matthoang08 @sandersn @appcelerator @ffMathy @zaqqaz @cmaddalozzo @garyking @Shearerbeard @breeze9527 - please review this PR in the next few days. Be sure to explicitly select Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"pr_number": 44272,
"author": "jablko",
"owners": [
"Tanandara",
"MathiasPaumgarten",
"Goyatuzo",
"BendingBender",
"LiamMartens",
"AyaMorisawa",
"MeirionHughes",
"danwbyrne",
"cyrilschumacher",
"kampfgnom",
"chatoo2412",
"feinoujc",
"bomret",
"brikou",
"gerich-home",
"chrisleck",
"grayrattus",
"innovation-team",
"Diullei",
"tkQubo",
"RReverser",
"e-cloud",
"zhu1230",
"szechyjs",
"pasthelod",
"cbothner",
"zspitz",
"unindented",
"aciccarello",
"Roaders",
"skymunn",
"Esri",
"MikeTschudi",
"jvilk",
"abner",
"mattsains",
"peterblazejewicz",
"s0m3on3",
"maxveres",
"federicobond",
"devpaul",
"bertoritger",
"twastvedt",
"DanielRose",
"meirgottlieb",
"princjef",
"Shinigami92",
"NoxHarmonium",
"ArrieAgilite",
"johnjardin",
"agilitehub",
"menthays",
"scaret",
"wangjie-agora",
"ysclyy",
"milesj",
"bvalosek",
"maxchehab",
"dmitriismitnov",
"afshawnlotfi",
"lochiego",
"littlepiggy03",
"qm3ster",
"ChristianMurphy",
"evan-hughes",
"akumina",
"jasonarden",
"MarshHawk",
"msn0",
"jjeffery",
"petebeegle",
"hoo29",
"pascalwhoop",
"blforce",
"rk-7",
"alexmalcoci",
"dolanmiu",
"CaselIT",
"gburgett",
"haroenv",
"samouss",
"cbaptiste",
"keichinger",
"neryortez",
"antoinerousseau",
"lucapasquale",
"adeve",
"dan-grayson",
"PeterEsenwa",
"bodinsamuel",
"rscotten",
"kopertio",
"taoqf",
"ptrdu",
"claasahl",
"matthoang08",
"sandersn",
"appcelerator",
"ffMathy",
"zaqqaz",
"cmaddalozzo",
"garyking",
"Shearerbeard",
"breeze9527"
],
"dangerLevel": "Infrastructure",
"headCommitAbbrOid": "02fff42",
"headCommitOid": "02fff42f39ff9f33bedff2a36d5a2120aac8020c",
"mergeIsRequested": false,
"stalenessInDays": 0,
"lastCommitDate": "2020-04-27T17:19:49.000Z",
"reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44272/files",
"hasMergeConflict": false,
"authorIsOwner": false,
"isFirstContribution": false,
"popularityLevel": "Popular",
"anyPackageIsNew": false,
"packages": [
"7zip-min",
"a-big-triangle",
"a11y-dialog",
"abbrev",
"abs-svg-path",
"abs",
"absolute",
"abstract-leveldown",
"acc-wizard",
"accept-language-parser",
"accept",
"accepts",
"accounting",
"accurate-interval",
"ace-diff",
"ace",
"acl",
"acorn",
"actioncable",
"activedirectory2",
"activestorage",
"activex-access",
"activex-adodb",
"activex-adox",
"activex-dao",
"activex-diskquota",
"activex-excel",
"activex-faxcomexlib",
"activex-infopath",
"activex-interop",
"activex-iwshruntimelibrary",
"activex-libreoffice",
"activex-msforms",
"activex-mshtml",
"activex-msxml2",
"activex-office",
"activex-outlook",
"activex-powerpoint",
"activex-scripting",
"activex-shdocvw",
"activex-shell",
"activex-stdole",
"activex-vbide",
"activex-wia",
"activex-word",
"adal-angular",
"add-zero",
"add2home",
"adhan",
"adlib",
"adm-zip",
"adobe__es-modules-middleware",
"adone",
"aes-js",
"aframe",
"ag-channel",
"ag-simple-broker",
"agenda",
"agent-base",
"agiledigital__mule-preview",
"agilite",
"agora-rtc-sdk",
"airbnb-prop-types",
"airtable",
"ajv-async",
"ajv-errors",
"ajv-keywords",
"ajv-merge-patch",
"ajv-pack",
"akamai-edgeworkers",
"akumina-core",
"ale-url-parser",
"alertify",
"alex",
"alexa-sdk",
"alexa-voice-service",
"algebra.js",
"algoliasearch-helper",
"algoliasearch",
"ali-app",
"ali-oss",
"align-text",
"alks-node",
"all-the-package-names",
"alloy",
"allure-js-commons",
"almost-equal",
"alpha-bravo",
"alt",
"amap-js-api-arrival-range",
"amap-js-api-autocomplete",
"amap-js-api-city-search",
"amap-js-api-control-bar",
"amap-js-api-district-search",
"amap-js-api-driving",
"amap-js-api-geocoder",
"amap-js-api-geolocation",
"amap-js-api-heatmap",
"amap-js-api-indoor-map"
],
"files": [
{
"filePath": "scripts/tsconfig.json",
"kind": "infrastructure"
},
{
"filePath": "types/7zip-min/tsconfig.json",
"kind": "package-meta",
"package": "7zip-min"
},
{
"filePath": "types/a-big-triangle/tsconfig.json",
"kind": "package-meta",
"package": "a-big-triangle"
},
{
"filePath": "types/a11y-dialog/tsconfig.json",
"kind": "package-meta",
"package": "a11y-dialog"
},
{
"filePath": "types/abbrev/tsconfig.json",
"kind": "package-meta",
"package": "abbrev"
},
{
"filePath": "types/abs-svg-path/tsconfig.json",
"kind": "package-meta",
"package": "abs-svg-path"
},
{
"filePath": "types/abs/tsconfig.json",
"kind": "package-meta",
"package": "abs"
},
{
"filePath": "types/absolute/tsconfig.json",
"kind": "package-meta",
"package": "absolute"
},
{
"filePath": "types/abstract-leveldown/tsconfig.json",
"kind": "package-meta",
"package": "abstract-leveldown"
},
{
"filePath": "types/acc-wizard/tsconfig.json",
"kind": "package-meta",
"package": "acc-wizard"
},
{
"filePath": "types/accept-language-parser/tsconfig.json",
"kind": "package-meta",
"package": "accept-language-parser"
},
{
"filePath": "types/accept/tsconfig.json",
"kind": "package-meta",
"package": "accept"
},
{
"filePath": "types/accepts/tsconfig.json",
"kind": "package-meta",
"package": "accepts"
},
{
"filePath": "types/accounting/tsconfig.json",
"kind": "package-meta",
"package": "accounting"
},
{
"filePath": "types/accurate-interval/tsconfig.json",
"kind": "package-meta",
"package": "accurate-interval"
},
{
"filePath": "types/ace-diff/tsconfig.json",
"kind": "package-meta",
"package": "ace-diff"
},
{
"filePath": "types/ace/tsconfig.json",
"kind": "package-meta",
"package": "ace"
},
{
"filePath": "types/acl/tsconfig.json",
"kind": "package-meta",
"package": "acl"
},
{
"filePath": "types/acorn/tsconfig.json",
"kind": "package-meta",
"package": "acorn"
},
{
"filePath": "types/actioncable/tsconfig.json",
"kind": "package-meta",
"package": "actioncable"
},
{
"filePath": "types/activedirectory2/tsconfig.json",
"kind": "package-meta",
"package": "activedirectory2"
},
{
"filePath": "types/activestorage/tsconfig.json",
"kind": "package-meta",
"package": "activestorage"
},
{
"filePath": "types/activex-access/tsconfig.json",
"kind": "package-meta",
"package": "activex-access"
},
{
"filePath": "types/activex-adodb/tsconfig.json",
"kind": "package-meta",
"package": "activex-adodb"
},
{
"filePath": "types/activex-adox/tsconfig.json",
"kind": "package-meta",
"package": "activex-adox"
},
{
"filePath": "types/activex-dao/tsconfig.json",
"kind": "package-meta",
"package": "activex-dao"
},
{
"filePath": "types/activex-diskquota/tsconfig.json",
"kind": "package-meta",
"package": "activex-diskquota"
},
{
"filePath": "types/activex-excel/tsconfig.json",
"kind": "package-meta",
"package": "activex-excel"
},
{
"filePath": "types/activex-faxcomexlib/tsconfig.json",
"kind": "package-meta",
"package": "activex-faxcomexlib"
},
{
"filePath": "types/activex-infopath/tsconfig.json",
"kind": "package-meta",
"package": "activex-infopath"
},
{
"filePath": "types/activex-interop/tsconfig.json",
"kind": "package-meta",
"package": "activex-interop"
},
{
"filePath": "types/activex-iwshruntimelibrary/tsconfig.json",
"kind": "package-meta",
"package": "activex-iwshruntimelibrary"
},
{
"filePath": "types/activex-libreoffice/tsconfig.json",
"kind": "package-meta",
"package": "activex-libreoffice"
},
{
"filePath": "types/activex-msforms/tsconfig.json",
"kind": "package-meta",
"package": "activex-msforms"
},
{
"filePath": "types/activex-mshtml/tsconfig.json",
"kind": "package-meta",
"package": "activex-mshtml"
},
{
"filePath": "types/activex-msxml2/tsconfig.json",
"kind": "package-meta",
"package": "activex-msxml2"
},
{
"filePath": "types/activex-office/tsconfig.json",
"kind": "package-meta",
"package": "activex-office"
},
{
"filePath": "types/activex-outlook/tsconfig.json",
"kind": "package-meta",
"package": "activex-outlook"
},
{
"filePath": "types/activex-powerpoint/tsconfig.json",
"kind": "package-meta",
"package": "activex-powerpoint"
},
{
"filePath": "types/activex-scripting/tsconfig.json",
"kind": "package-meta",
"package": "activex-scripting"
},
{
"filePath": "types/activex-shdocvw/tsconfig.json",
"kind": "package-meta",
"package": "activex-shdocvw"
},
{
"filePath": "types/activex-shell/tsconfig.json",
"kind": "package-meta",
"package": "activex-shell"
},
{
"filePath": "types/activex-stdole/tsconfig.json",
"kind": "package-meta",
"package": "activex-stdole"
},
{
"filePath": "types/activex-vbide/tsconfig.json",
"kind": "package-meta",
"package": "activex-vbide"
},
{
"filePath": "types/activex-wia/tsconfig.json",
"kind": "package-meta",
"package": "activex-wia"
},
{
"filePath": "types/activex-word/tsconfig.json",
"kind": "package-meta",
"package": "activex-word"
},
{
"filePath": "types/adal-angular/tsconfig.json",
"kind": "package-meta",
"package": "adal-angular"
},
{
"filePath": "types/add-zero/tsconfig.json",
"kind": "package-meta",
"package": "add-zero"
},
{
"filePath": "types/add2home/tsconfig.json",
"kind": "package-meta",
"package": "add2home"
},
{
"filePath": "types/adhan/tsconfig.json",
"kind": "package-meta",
"package": "adhan"
},
{
"filePath": "types/adlib/tsconfig.json",
"kind": "package-meta",
"package": "adlib"
},
{
"filePath": "types/adm-zip/tsconfig.json",
"kind": "package-meta",
"package": "adm-zip"
},
{
"filePath": "types/adobe__es-modules-middleware/tsconfig.json",
"kind": "package-meta",
"package": "adobe__es-modules-middleware"
},
{
"filePath": "types/adone/tsconfig.json",
"kind": "package-meta",
"package": "adone"
},
{
"filePath": "types/aes-js/tsconfig.json",
"kind": "package-meta",
"package": "aes-js"
},
{
"filePath": "types/aframe/tsconfig.json",
"kind": "package-meta",
"package": "aframe"
},
{
"filePath": "types/ag-channel/tsconfig.json",
"kind": "package-meta",
"package": "ag-channel"
},
{
"filePath": "types/ag-simple-broker/tsconfig.json",
"kind": "package-meta",
"package": "ag-simple-broker"
},
{
"filePath": "types/agenda/tsconfig.json",
"kind": "package-meta",
"package": "agenda"
},
{
"filePath": "types/agent-base/tsconfig.json",
"kind": "package-meta",
"package": "agent-base"
},
{
"filePath": "types/agiledigital__mule-preview/tsconfig.json",
"kind": "package-meta",
"package": "agiledigital__mule-preview"
},
{
"filePath": "types/agilite/tsconfig.json",
"kind": "package-meta",
"package": "agilite"
},
{
"filePath": "types/agora-rtc-sdk/tsconfig.json",
"kind": "package-meta",
"package": "agora-rtc-sdk"
},
{
"filePath": "types/airbnb-prop-types/tsconfig.json",
"kind": "package-meta",
"package": "airbnb-prop-types"
},
{
"filePath": "types/airtable/tsconfig.json",
"kind": "package-meta",
"package": "airtable"
},
{
"filePath": "types/ajv-async/tsconfig.json",
"kind": "package-meta",
"package": "ajv-async"
},
{
"filePath": "types/ajv-errors/tsconfig.json",
"kind": "package-meta",
"package": "ajv-errors"
},
{
"filePath": "types/ajv-keywords/tsconfig.json",
"kind": "package-meta",
"package": "ajv-keywords"
},
{
"filePath": "types/ajv-merge-patch/tsconfig.json",
"kind": "package-meta",
"package": "ajv-merge-patch"
},
{
"filePath": "types/ajv-pack/tsconfig.json",
"kind": "package-meta",
"package": "ajv-pack"
},
{
"filePath": "types/akamai-edgeworkers/tsconfig.json",
"kind": "package-meta",
"package": "akamai-edgeworkers"
},
{
"filePath": "types/akumina-core/tsconfig.json",
"kind": "package-meta",
"package": "akumina-core"
},
{
"filePath": "types/ale-url-parser/tsconfig.json",
"kind": "package-meta",
"package": "ale-url-parser"
},
{
"filePath": "types/alertify/tsconfig.json",
"kind": "package-meta",
"package": "alertify"
},
{
"filePath": "types/alex/tsconfig.json",
"kind": "package-meta",
"package": "alex"
},
{
"filePath": "types/alexa-sdk/tsconfig.json",
"kind": "package-meta",
"package": "alexa-sdk"
},
{
"filePath": "types/alexa-voice-service/tsconfig.json",
"kind": "package-meta",
"package": "alexa-voice-service"
},
{
"filePath": "types/algebra.js/tsconfig.json",
"kind": "package-meta",
"package": "algebra.js"
},
{
"filePath": "types/algoliasearch-helper/tsconfig.json",
"kind": "package-meta",
"package": "algoliasearch-helper"
},
{
"filePath": "types/algoliasearch/tsconfig.json",
"kind": "package-meta",
"package": "algoliasearch"
},
{
"filePath": "types/ali-app/tsconfig.json",
"kind": "package-meta",
"package": "ali-app"
},
{
"filePath": "types/ali-oss/tsconfig.json",
"kind": "package-meta",
"package": "ali-oss"
},
{
"filePath": "types/align-text/tsconfig.json",
"kind": "package-meta",
"package": "align-text"
},
{
"filePath": "types/alks-node/tsconfig.json",
"kind": "package-meta",
"package": "alks-node"
},
{
"filePath": "types/all-the-package-names/tsconfig.json",
"kind": "package-meta",
"package": "all-the-package-names"
},
{
"filePath": "types/alloy/tsconfig.json",
"kind": "package-meta",
"package": "alloy"
},
{
"filePath": "types/allure-js-commons/tsconfig.json",
"kind": "package-meta",
"package": "allure-js-commons"
},
{
"filePath": "types/almost-equal/tsconfig.json",
"kind": "package-meta",
"package": "almost-equal"
},
{
"filePath": "types/alpha-bravo/tsconfig.json",
"kind": "package-meta",
"package": "alpha-bravo"
},
{
"filePath": "types/alt/tsconfig.json",
"kind": "package-meta",
"package": "alt"
},
{
"filePath": "types/amap-js-api-arrival-range/tsconfig.json",
"kind": "package-meta",
"package": "amap-js-api-arrival-range"
},
{
"filePath": "types/amap-js-api-autocomplete/tsconfig.json",
"kind": "package-meta",
"package": "amap-js-api-autocomplete"
},
{
"filePath": "types/amap-js-api-city-search/tsconfig.json",
"kind": "package-meta",
"package": "amap-js-api-city-search"
},
{
"filePath": "types/amap-js-api-control-bar/tsconfig.json",
"kind": "package-meta",
"package": "amap-js-api-control-bar"
},
{
"filePath": "types/amap-js-api-district-search/tsconfig.json",
"kind": "package-meta",
"package": "amap-js-api-district-search"
},
{
"filePath": "types/amap-js-api-driving/tsconfig.json",
"kind": "package-meta",
"package": "amap-js-api-driving"
},
{
"filePath": "types/amap-js-api-geocoder/tsconfig.json",
"kind": "package-meta",
"package": "amap-js-api-geocoder"
},
{
"filePath": "types/amap-js-api-geolocation/tsconfig.json",
"kind": "package-meta",
"package": "amap-js-api-geolocation"
},
{
"filePath": "types/amap-js-api-heatmap/tsconfig.json",
"kind": "package-meta",
"package": "amap-js-api-heatmap"
},
{
"filePath": "types/amap-js-api-indoor-map/tsconfig.json",
"kind": "package-meta",
"package": "amap-js-api-indoor-map"
}
],
"otherApprovalCount": 0,
"ownerApprovalCount": 0,
"maintainerApprovalCount": 0,
"hasDismissedReview": false,
"travisResult": "unknown",
"reviewersWithStaleReviews": [],
"approvalFlags": 0,
"isChangesRequested": false
} |
Old PR, but I'm going to close this in favor of microsoft/DefinitelyTyped-tools#968; I do think this makes sense to try for declaration files only, but this PR won't be the place for it, and it'll be via a lint (which isn't yet ready). |
What do you think about enabling
noUnusedLocals
?It would have caught e.g. #44213, thereby pruning a dependency.
Like #43637,
tsconfig.json
isn't distributed along with the types, so this only affects the automated tests, not the types themselves. It makes the tests slightly stricter.Unlike
strictNullChecks
however, there isn't an existing recommendation to enablenoUnusedLocals
. Are there practical/philosophical objections widespread enablingnoUnusedLocals
?npm test
.)npm run lint package-name
(ortsc
if notslint.json
is present).