Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[benchmark] Adding typings for event.target #44282

Merged
merged 6 commits into from
May 12, 2020

Conversation

fishcharlie
Copy link
Contributor

@fishcharlie fishcharlie commented Apr 27, 2020

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: https://benchmarkjs.com/docs#Event_prototype_target
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • Include tests for your changes
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 27, 2020

@fishcharlie Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 - keep an eye on this comment as I'll be updating it with information as things progress.

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ❌ Most recent commit is approved by type definition owners, DT maintainers or others

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 44282,
  "author": "fishcharlie",
  "owners": [],
  "dangerLevel": "ScopedAndTested",
  "headCommitAbbrOid": "2579430",
  "headCommitOid": "25794304acf8c1fd70712bd068beb07b0e09755e",
  "mergeIsRequested": false,
  "stalenessInDays": 14,
  "lastCommitDate": "2020-04-27T23:58:24.000Z",
  "lastCommentDate": "2020-04-28T20:10:59.000Z",
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44282/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": true,
  "popularityLevel": "Well-liked by everyone",
  "anyPackageIsNew": false,
  "packages": [
    "benchmark"
  ],
  "files": [
    {
      "filePath": "types/benchmark/benchmark-tests.ts",
      "kind": "test",
      "package": "benchmark"
    },
    {
      "filePath": "types/benchmark/index.d.ts",
      "kind": "definition",
      "package": "benchmark"
    }
  ],
  "hasDismissedReview": false,
  "travisResult": "pass",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 0,
  "isChangesRequested": false
}

@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 27, 2020

@fishcharlie The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #44282 diff
Batch compilation
Memory usage (MiB) 80.7 80.8 +0.1%
Type count 9273 9276 0%
Assignability cache size 33144 33144 0%
Language service
Samples taken 205 205 0%
Identifiers in tests 205 205 0%
getCompletionsAtPosition
    Mean duration (ms) 304.9 305.9 +0.3%
    Mean CV 11.4% 11.8%
    Worst duration (ms) 390.5 415.4 +6.4%
    Worst identifier document run
getQuickInfoAtPosition
    Mean duration (ms) 294.0 292.3 -0.6%
    Mean CV 11.6% 10.6% -8.7%
    Worst duration (ms) 376.0 383.3 +1.9%
    Worst identifier lastChild createElement

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. and removed The Travis CI build failed labels Apr 27, 2020
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Apr 27, 2020
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Apr 27, 2020
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Apr 27, 2020
@fishcharlie
Copy link
Contributor Author

@RyanCavanaugh

@typescript-bot - Please bother @RyanCavanaugh if I appear to be misbehaving.

It looks like @typescript-bot didn't update this comment #44282 (comment) or the labels on this PR now that all checks are now passing.

Anyway to have @typescript-bot relook at this PR (since it didn't automatically)?

@fishcharlie
Copy link
Contributor Author

fishcharlie commented Apr 28, 2020

This also doesn't make sense at all... am I allowed to merge this? Not all the items are green, but it says they are.

image

@fishcharlie
Copy link
Contributor Author

@orta Is the The Travis CI build failed supposed to be showing in this case? Even after editing the original comment?

@orta
Copy link
Collaborator

orta commented Apr 28, 2020

We're looking into that ATM DefinitelyTyped/dt-mergebot#14

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board May 12, 2020
@sandersn sandersn merged commit 6ec8307 into DefinitelyTyped:master May 12, 2020
@typescript-bot typescript-bot removed this from Needs Maintainer Review in New Pull Request Status Board May 12, 2020
@typescript-bot
Copy link
Contributor

I just published @types/benchmark@1.0.32 to npm.

deviation?: number;
mean?: number;
sample?: any[];
variances?: number;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this block isn't replaced with Stats, then variances should be variance, the word variances doesn't appear in benchmark's source code.

name?: string;
fn?: Function;
id: number;
stats?: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use the Stats type here instead?

jjballano-qatium pushed a commit to jjballano-qatium/DefinitelyTyped that referenced this pull request Jun 16, 2020
* [benchmark] Adding typings for event.target

* [benchmark] Moving definition authors onto two lines

* [benchmark] Changing project URL to use https

* [benchmark] Removing extra whitespace

* [benchmark] Adding missing semicolon

* [benchmark] Updating tests for Benchmark.Target
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants