-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[benchmark] Adding typings for event.target #44282
Conversation
@fishcharlie Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 - keep an eye on this comment as I'll be updating it with information as things progress. Code ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 44282,
"author": "fishcharlie",
"owners": [],
"dangerLevel": "ScopedAndTested",
"headCommitAbbrOid": "2579430",
"headCommitOid": "25794304acf8c1fd70712bd068beb07b0e09755e",
"mergeIsRequested": false,
"stalenessInDays": 14,
"lastCommitDate": "2020-04-27T23:58:24.000Z",
"lastCommentDate": "2020-04-28T20:10:59.000Z",
"reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44282/files",
"hasMergeConflict": false,
"authorIsOwner": false,
"isFirstContribution": true,
"popularityLevel": "Well-liked by everyone",
"anyPackageIsNew": false,
"packages": [
"benchmark"
],
"files": [
{
"filePath": "types/benchmark/benchmark-tests.ts",
"kind": "test",
"package": "benchmark"
},
{
"filePath": "types/benchmark/index.d.ts",
"kind": "definition",
"package": "benchmark"
}
],
"hasDismissedReview": false,
"travisResult": "pass",
"reviewersWithStaleReviews": [],
"approvalFlags": 0,
"isChangesRequested": false
} |
@fishcharlie The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? Comparison details 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
@typescript-bot - It looks like @typescript-bot didn't update this comment #44282 (comment) or the labels on this PR now that all checks are now passing. Anyway to have @typescript-bot relook at this PR (since it didn't automatically)? |
@orta Is the |
We're looking into that ATM DefinitelyTyped/dt-mergebot#14 |
I just published |
deviation?: number; | ||
mean?: number; | ||
sample?: any[]; | ||
variances?: number; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this block isn't replaced with Stats, then variances
should be variance
, the word variances
doesn't appear in benchmark's source code.
name?: string; | ||
fn?: Function; | ||
id: number; | ||
stats?: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use the Stats type here instead?
* [benchmark] Adding typings for event.target * [benchmark] Moving definition authors onto two lines * [benchmark] Changing project URL to use https * [benchmark] Removing extra whitespace * [benchmark] Adding missing semicolon * [benchmark] Updating tests for Benchmark.Target
Please fill in this template.
npm test
.)npm run lint package-name
(ortsc
if notslint.json
is present).Select one of these and delete the others:
If changing an existing definition:
tslint.json
containing{ "extends": "dtslint/dt.json" }
. If for reason the any rule need to be disabled, disable it for that line using// tslint:disable-next-line [ruleName]
and not for whole package so that the need for disabling can be reviewed.