-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update support schedule in READMEs #44402
Conversation
@sandersn Thank you for submitting this PR! This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare - did you mean to do this? Code ReviewsThere aren't any other owners of this package, so a DT maintainer will review it. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 44402,
"author": "sandersn",
"owners": [],
"dangerLevel": "Infrastructure",
"headCommitAbbrOid": "5dfb994",
"headCommitOid": "5dfb9945fc5c243f011a9436cbcc12d1ad12b012",
"mergeIsRequested": false,
"stalenessInDays": 0,
"lastCommitDate": "2020-04-30T23:17:43.000Z",
"lastAuthorCommentDate": "2020-04-30T23:21:44.000Z",
"reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44402/files",
"hasMergeConflict": false,
"authorIsOwner": false,
"isFirstContribution": false,
"popularityLevel": "Well-liked by everyone",
"anyPackageIsNew": false,
"packages": [],
"files": [
{
"filePath": "README.cn.md",
"kind": "infrastructure"
},
{
"filePath": "README.es.md",
"kind": "infrastructure"
},
{
"filePath": "README.ko.md",
"kind": "infrastructure"
},
{
"filePath": "README.md",
"kind": "infrastructure"
},
{
"filePath": "README.ru.md",
"kind": "infrastructure"
}
],
"hasDismissedReview": false,
"travisResult": "pass",
"lastReviewDate": "2020-05-01T05:46:07.000Z",
"reviewersWithStaleReviews": [],
"approvalFlags": 5,
"isChangesRequested": false
} |
I guess I can't add non-DT members as reviewers? So here's a manual ping: @galkin @saschanaz @Kingwl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@sandersn Everything looks good here. Great job! I am ready to merge this PR on your behalf. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
I'm pretty sure I didn't mess up the non-English readmes, but it might be nice to have some other people look.