Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update support schedule in READMEs #44402

Merged
merged 1 commit into from
May 1, 2020
Merged

Conversation

sandersn
Copy link
Contributor

I'm pretty sure I didn't mess up the non-English readmes, but it might be nice to have some other people look.

@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Apr 30, 2020
@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 30, 2020

@sandersn Thank you for submitting this PR!

This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare - did you mean to do this?

Code Reviews

There aren't any other owners of this package, so a DT maintainer will review it.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Only a DT maintainer can merge changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 44402,
  "author": "sandersn",
  "owners": [],
  "dangerLevel": "Infrastructure",
  "headCommitAbbrOid": "5dfb994",
  "headCommitOid": "5dfb9945fc5c243f011a9436cbcc12d1ad12b012",
  "mergeIsRequested": false,
  "stalenessInDays": 0,
  "lastCommitDate": "2020-04-30T23:17:43.000Z",
  "lastAuthorCommentDate": "2020-04-30T23:21:44.000Z",
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44402/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": false,
  "popularityLevel": "Well-liked by everyone",
  "anyPackageIsNew": false,
  "packages": [],
  "files": [
    {
      "filePath": "README.cn.md",
      "kind": "infrastructure"
    },
    {
      "filePath": "README.es.md",
      "kind": "infrastructure"
    },
    {
      "filePath": "README.ko.md",
      "kind": "infrastructure"
    },
    {
      "filePath": "README.md",
      "kind": "infrastructure"
    },
    {
      "filePath": "README.ru.md",
      "kind": "infrastructure"
    }
  ],
  "hasDismissedReview": false,
  "travisResult": "pass",
  "lastReviewDate": "2020-05-01T05:46:07.000Z",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 5,
  "isChangesRequested": false
}

@sandersn
Copy link
Contributor Author

I guess I can't add non-DT members as reviewers? So here's a manual ping: @galkin @saschanaz @Kingwl

Copy link
Contributor

@saschanaz saschanaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@typescript-bot typescript-bot added the Other Approved This PR was reviewed and signed-off by a community member. label Apr 30, 2020
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in New Pull Request Status Board Apr 30, 2020
@typescript-bot
Copy link
Contributor

@sandersn Everything looks good here. Great job! I am ready to merge this PR on your behalf.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

@orta orta moved this from Waiting for Author to Merge to Needs Maintainer Review in New Pull Request Status Board May 1, 2020
@orta orta moved this from Needs Maintainer Review to Other in New Pull Request Status Board May 1, 2020
@sandersn sandersn merged commit e3f5f98 into master May 1, 2020
@sandersn sandersn deleted the update-unsupported-in-readmes branch May 1, 2020 15:34
jjballano-qatium pushed a commit to jjballano-qatium/DefinitelyTyped that referenced this pull request Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintainer Approved Other Approved This PR was reviewed and signed-off by a community member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants