-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[detect-port]: add PortConfig type for first argument from default function #44439
[detect-port]: add PortConfig type for first argument from default function #44439
Conversation
@ivandevp Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 - keep an eye on this comment as I'll be updating it with information as things progress. Code ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 44439,
"author": "ivandevp",
"owners": [
"lith-light-g"
],
"dangerLevel": "ScopedAndTested",
"headCommitAbbrOid": "7175178",
"headCommitOid": "717517805e8a928d3c2f126893d8063017259663",
"mergeIsRequested": true,
"stalenessInDays": 0,
"lastCommitDate": "2020-05-02T14:58:42.000Z",
"lastAuthorCommentDate": "2020-05-03T13:38:46.000Z",
"reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44439/files",
"hasMergeConflict": false,
"authorIsOwner": false,
"isFirstContribution": true,
"popularityLevel": "Well-liked by everyone",
"anyPackageIsNew": false,
"packages": [
"detect-port"
],
"files": [
{
"filePath": "types/detect-port/detect-port-tests.ts",
"kind": "test",
"package": "detect-port"
},
{
"filePath": "types/detect-port/index.d.ts",
"kind": "definition",
"package": "detect-port"
}
],
"hasDismissedReview": false,
"travisResult": "pass",
"lastReviewDate": "2020-05-03T11:58:37.000Z",
"reviewersWithStaleReviews": [],
"approvalFlags": 1,
"isChangesRequested": false
} |
🔔 @lith-light-g - please review this PR in the next few days. Be sure to explicitly select |
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? Comparison details 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
I think you accidentally included the .tgz in this PR |
Thanks @orta! I didn't see it. I've just removed it. |
@orta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@ivandevp thx for contribution!
@ivandevp Everything looks good here. Great job! I am ready to merge this PR on your behalf. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
This prevents accidental inclusion of common artefact: see: https://github.com/github/gitignore/blob/master/Node.gitignore#L65 DefinitelyTyped#44439 (comment) Thanks!
Ready to merge |
I just published |
This prevents accidental inclusion of common artefact: see: https://github.com/github/gitignore/blob/master/Node.gitignore#L65 #44439 (comment) Thanks! Co-authored-by: PiotrB <pblazejewicz@appriss.com>
…or first argument from default function by @ivandevp * Add portconfig type for detect port first argument * Update detect-port version * Fix version format * Remove autogenerated bin
This prevents accidental inclusion of common artefact: see: https://github.com/github/gitignore/blob/master/Node.gitignore#L65 DefinitelyTyped#44439 (comment) Thanks! Co-authored-by: PiotrB <pblazejewicz@appriss.com>
Please fill in this template.
npm test
.)npm run lint package-name
(ortsc
if notslint.json
is present).Select one of these and delete the others:
tslint.json
containing{ "extends": "dtslint/dt.json" }
. If for reason the any rule need to be disabled, disable it for that line using// tslint:disable-next-line [ruleName]
and not for whole package so that the need for disabling can be reviewed.