-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pino): remedy destination static method and add missing option prettifier #44642
fix(pino): remedy destination static method and add missing option prettifier #44642
Conversation
Fix `destination` static method parameter to reflect pino’s documentation (https://getpino.io/#/docs/api?id=statics). This parameter should have already been typed this way for the current type version (v6.0.0), so no version change is required.
This option is documented in pino’s docs to support the `prettyPrint` options.
@emilio-martinez Thank you for submitting this PR! Code ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 44642,
"author": "emilio-martinez",
"owners": [
"psnider",
"BendingBender",
"screendriver",
"paambaati",
"alferpal",
"mortiy",
"lummish",
"raoulus",
"Cooryd",
"AdamVig",
"austin-beer",
"Pegase745"
],
"dangerLevel": "ScopedAndTested",
"headCommitAbbrOid": "32d09db",
"headCommitOid": "32d09dbf6d0fffe2944ccb33f396a86424ddf284",
"mergeIsRequested": true,
"stalenessInDays": 0,
"lastCommitDate": "2020-05-11T12:02:24.000Z",
"lastCommentDate": "2020-05-11T20:44:40.000Z",
"reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44642/files",
"hasMergeConflict": false,
"authorIsOwner": false,
"isFirstContribution": false,
"popularityLevel": "Popular",
"anyPackageIsNew": false,
"packages": [
"pino"
],
"files": [
{
"filePath": "types/pino/index.d.ts",
"kind": "definition",
"package": "pino"
},
{
"filePath": "types/pino/pino-tests.ts",
"kind": "test",
"package": "pino"
}
],
"hasDismissedReview": false,
"travisResult": "pass",
"lastReviewDate": "2020-05-11T20:40:36.000Z",
"reviewersWithStaleReviews": [],
"approvalFlags": 2,
"isChangesRequested": false
} |
🔔 @psnider @BendingBender @screendriver @paambaati @alferpal @mortiy @lummish @raoulus @Cooryd @AdamVig @austin-beer @Pegase745 - please review this PR in the next few days. Be sure to explicitly select |
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? Comparison details 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@emilio-martinez Everything looks good here. Great job! I am ready to merge this PR on your behalf. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
Ready to merge |
I just published |
… method and add missing option prettifier by @emilio-martinez * fix(pino): remedy destination static method param Fix `destination` static method parameter to reflect pino’s documentation (https://getpino.io/#/docs/api?id=statics). This parameter should have already been typed this way for the current type version (v6.0.0), so no version change is required. * fix(pino): add missing option prettifier This option is documented in pino’s docs to support the `prettyPrint` options.
… method and add missing option prettifier by @emilio-martinez * fix(pino): remedy destination static method param Fix `destination` static method parameter to reflect pino’s documentation (https://getpino.io/#/docs/api?id=statics). This parameter should have already been typed this way for the current type version (v6.0.0), so no version change is required. * fix(pino): add missing option prettifier This option is documented in pino’s docs to support the `prettyPrint` options.
Please fill in this template.
npm test
.)npm run lint package-name
(ortsc
if notslint.json
is present).Select one of these and delete the others:
If changing an existing definition:
tslint.json
containing{ "extends": "dtslint/dt.json" }
. If for reason the any rule need to be disabled, disable it for that line using// tslint:disable-next-line [ruleName]
and not for whole package so that the need for disabling can be reviewed.PR Summary
destination
static method parameter to reflectpino
’s documentation (https://getpino.io/#/docs/api?id=statics). This parameter should have already been typed this way for the current type version (v6.0.0), so no version change is required. As such, source code linked above refers to that version; no changes have been made to this portion of the API since then.prettifier
. This was also available in current type version (v6.0.0).