[gapi.client.classroom] automatic update

[Maxim-Mazurok]

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change. (Run with npm test.)
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/Maxim-Mazurok/google-api-typings-generator#google-api-typings-generator
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
• Include tests for your changes
• If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

---

🤖 This pull request was automatically created by Maxim-Mazurok/google-api-typings-generator which generates types from Google API Discovery Service. Types were linted and tested before submission.

If there is an issue with this pull request, consider submitting a new issue.

Note you can also use these types from our types branch which is updated hourly.

[typescript-bot]

@Maxim-Mazurok Thank you for submitting this PR!

Code Reviews

There aren't any other owners of this package, so a DT maintainer will review it.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ❌ A DT maintainer can merge changes when there are no other reviewers

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 45165,
  "author": "Maxim-Mazurok",
  "owners": [
    "Maxim-Mazurok"
  ],
  "dangerLevel": "ScopedAndConfiguration",
  "headCommitAbbrOid": "42967db",
  "headCommitOid": "42967dba1b32d0a27eab7dd8aeb689946a0e1845",
  "mergeIsRequested": false,
  "stalenessInDays": 0,
  "lastCommitDate": "2020-06-12T03:19:39.000Z",
  "lastCommentDate": "2020-06-12T18:05:05.000Z",
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45165/files",
  "hasMergeConflict": false,
  "authorIsOwner": true,
  "isFirstContribution": false,
  "popularityLevel": "Well-liked by everyone",
  "anyPackageIsNew": false,
  "packages": [
    "gapi.client.classroom"
  ],
  "files": [
    {
      "filePath": "types/gapi.client.classroom/index.d.ts",
      "kind": "definition",
      "package": "gapi.client.classroom"
    },
    {
      "filePath": "types/gapi.client.classroom/readme.md",
      "kind": "package-meta",
      "package": "gapi.client.classroom"
    }
  ],
  "hasDismissedReview": false,
  "ciResult": "pass",
  "reviewersWithStaleReviews": [
    {
      "reviewedAbbrOid": "fa127a7",
      "reviewer": "peterblazejewicz",
      "date": "2020-06-11T09:00:28Z"
    },
    {
      "reviewedAbbrOid": "0d1c7b8",
      "reviewer": "peterblazejewicz",
      "date": "2020-06-10T18:56:05Z"
    },
    {
      "reviewedAbbrOid": "1606f90",
      "reviewer": "peterblazejewicz",
      "date": "2020-06-09T08:28:08Z"
    },
    {
      "reviewedAbbrOid": "cd1fb80",
      "reviewer": "peterblazejewicz",
      "date": "2020-06-05T15:22:57Z"
    },
    {
      "reviewedAbbrOid": "120658d",
      "reviewer": "peterblazejewicz",
      "date": "2020-06-03T08:09:12Z"
    },
    {
      "reviewedAbbrOid": "47cecdb",
      "reviewer": "peterblazejewicz",
      "date": "2020-05-31T21:08:49Z"
    }
  ],
  "approvalFlags": 0,
  "isChangesRequested": false
}

[typescript-bot]

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊

	master	#45165	diff
Batch compilation
Memory usage (MiB)	86.5	81.8	-5.4%
Type count	12624	12624	0%
Assignability cache size	34694	34694	0%
Language service
Samples taken	8258	8258	0%
Identifiers in tests	8258	8258	0%
getCompletionsAtPosition
Mean duration (ms)	368.7	351.6	-4.6%
Mean CV	1.2%	1.4%
Worst duration (ms)	670.5	721.5	+7.6%
Worst identifier	driveFile	courseId
getQuickInfoAtPosition
Mean duration (ms)	372.1	355.0	-4.6%
Mean CV	1.2%	1.4%	+16.8%
Worst duration (ms)	764.8	638.5	-16.5%
Worst identifier	driveFile	announcements

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

[peterblazejewicz]

LGTM!

[typescript-bot]

@peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

[typescript-bot]

Updated numbers for you here from 7a61cd2.

Comparison details 📊

	master	#45165	diff
Batch compilation
Memory usage (MiB)	81.6	92.8	+13.7%
Type count	12624	12624	0%
Assignability cache size	34694	34694	0%
Language service
Samples taken	8258	8258	0%
Identifiers in tests	8258	8258	0%
getCompletionsAtPosition
Mean duration (ms)	398.4	396.1	-0.6%
Mean CV	0.6%	0.6%
Worst duration (ms)	670.3	650.1	-3.0%
Worst identifier	title	courseId
getQuickInfoAtPosition
Mean duration (ms)	401.8	397.6	-1.0%
Mean CV	0.6%	0.6%	+6.6%
Worst duration (ms)	792.9	957.0	+20.7% 🔸
Worst identifier	url	pointsEarned

Looks like there were a couple significant differences—take a look at worst-case duration for getting quick info at a position to make sure everything looks ok.

[typescript-bot]

Updated numbers for you here from f7d4643. Nice job, these numbers look better.

Comparison details 📊

	master	#45165	diff
Batch compilation
Memory usage (MiB)	93.7	92.7	-1.1%
Type count	12624	12624	0%
Assignability cache size	34694	34694	0%
Language service
Samples taken	8258	8258	0%
Identifiers in tests	8258	8258	0%
getCompletionsAtPosition
Mean duration (ms)	427.2	431.5	+1.0%
Mean CV	0.1%	0.0%
Worst duration (ms)	856.1	1001.0	+16.9%
Worst identifier	topics	topics
getQuickInfoAtPosition
Mean duration (ms)	430.4	434.9	+1.0%
Mean CV	0.1%	0.0%	-71.9%
Worst duration (ms)	871.6	811.5	-6.9%
Worst identifier	courseId	shortAnswerSubmission

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

[typescript-bot]

Updated numbers for you here from 58d5bf5.

Comparison details 📊

	master	#45165	diff
Batch compilation
Memory usage (MiB)	80.1	80.0	-0.2%
Type count	12712	12712	0%
Assignability cache size	3648	3648	0%
Language service
Samples taken	8258	8258	0%
Identifiers in tests	8258	8258	0%
getCompletionsAtPosition
Mean duration (ms)	391.7	391.0	-0.2%
Mean CV	0.5%	0.5%
Worst duration (ms)	691.2	828.6	+19.9%
Worst identifier	teachers	classroom
getQuickInfoAtPosition
Mean duration (ms)	406.5	404.9	-0.4%
Mean CV	0.5%	0.5%	-6.4%
Worst duration (ms)	755.6	921.2	+21.9% 🔸
Worst identifier	attachments	courses

Looks like there were a couple significant differences—take a look at worst-case duration for getting quick info at a position to make sure everything looks ok.

[orta]

Heh, wow - OK, looks good.

[typescript-bot]

I just published @types/gapi.client.classroom@1.0.5 to npm.

[Maxim-Mazurok]

Heh, wow - OK, looks good.

Can you explain your reaction, please? :)

[orta]

just a lot of bot action in this PR

…

-- [·/ ] Orta Therox w/ Microsoft on TypeScript CocoaPods <http://cocoapods.org/> / Danger <https://danger.systems> @orta / orta.github.com

On Sat, Jun 13, 2020 at 12:24 AM Maxim Mazurok ***@***.***> wrote: Heh, wow - OK, looks good. Can you explain your reaction, please? :) — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#45165 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAL7DRCFFVGJHLD6W77EETRWL5QTANCNFSM4NOQZHNQ> .