-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(mui-datatables): updated for v3.1.x #45306
refactor(mui-datatables): updated for v3.1.x #45306
Conversation
@favna Thank you for submitting this PR! This is a live comment which I will keep updated. Code ReviewsBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 45306,
"author": "Favna",
"owners": [
"favna",
"ankithkonda",
"hwatersiv",
"souppower",
"byrekt"
],
"dangerLevel": "ScopedAndConfiguration",
"headCommitAbbrOid": "3d028d0",
"headCommitOid": "3d028d0d76c07f735296344ac0cbeb34bcbfe0db",
"mergeIsRequested": false,
"stalenessInDays": 0,
"lastCommitDate": "2020-07-06T22:49:06.000Z",
"reopenedDate": "2020-06-12T22:54:26.000Z",
"lastCommentDate": "2020-07-07T18:23:31.000Z",
"maintainerBlessed": false,
"reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45306/files",
"hasMergeConflict": false,
"authorIsOwner": true,
"isFirstContribution": false,
"popularityLevel": "Well-liked by everyone",
"anyPackageIsNew": false,
"packages": [
"mui-datatables"
],
"files": [
{
"filePath": "types/mui-datatables/index.d.ts",
"kind": "definition",
"package": "mui-datatables"
},
{
"filePath": "types/mui-datatables/mui-datatables-tests.tsx",
"kind": "test",
"package": "mui-datatables"
},
{
"filePath": "types/mui-datatables/tsconfig.json",
"kind": "package-meta",
"package": "mui-datatables"
}
],
"hasDismissedReview": false,
"ciResult": "pass",
"lastReviewDate": "2020-07-06T23:35:23.000Z",
"reviewersWithStaleReviews": [],
"approvalFlags": 1,
"isChangesRequested": false
} |
🔔 @ankithkonda @hwatersiv @souppower @byrekt - please review this PR in the next few days. Be sure to explicitly select |
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? Comparison details 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
Drafting this so I can include the changes made in mui-datatables v3.0 before it gets merged. That way it's all inclusive. Changes to cover: https://github.com/gregnb/mui-datatables/blob/master/docs/v2_to_v3_guide.md |
Undrafted, PR now covers the changes for version 3.0.0 as well. |
@favna The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
@favna The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
Since this PR was drafted then undrafted it seems like it got reset for the 7 day turn around cycle, seeing its status on the project board. Just going to ping the other maintainers in here like @typescript-bot does for review so this can get merged: 🔔 @ankithkonda @hwatersiv @souppower @byrekt - please review this PR in the next few days. Be sure to explicitly select |
@favna The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
@favna
(so it rebases cleanly)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I've tried samples from v3.* README
@favna thx for the update!
@peterblazejewicz rebased on master and squashed |
@favna The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
Thank you so much! It will help out a lot. LGTM :) |
LGTM! |
I just published |
👯 |
fixed #45909 |
* refactor(mui-datatables): updated for v3.1.x * fix stuff
* refactor(mui-datatables): updated for v3.1.x * fix stuff
textLabels.body
, this PR adds itmui-datatables
version 3.1.xPlease fill in this template.
Use a meaningful title for the pull request. Include the name of the package modified.
Test the change in your own code. (Compile and run.)
Add or edit tests to reflect the change. (Run with
npm test
.)Follow the advice from the readme.
Avoid common mistakes.
Run
npm run lint package-name
(ortsc
if notslint.json
is present).Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/gregnb/mui-datatables/#localization & https://github.com/gregnb/mui-datatables/blob/master/docs/v2_to_v3_guide.md
If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
Include tests for your changes