Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@types/dockerode] Use correct data structures for Config and Options in IPAM definition #45441

Merged
merged 1 commit into from Jun 12, 2020

Conversation

digijap
Copy link
Contributor

@digijap digijap commented Jun 12, 2020

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot typescript-bot added the Where is GH Actions? GH Actions didn't give a response to this PR label Jun 12, 2020
@typescript-bot
Copy link
Contributor

typescript-bot commented Jun 12, 2020

@digijap Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 - keep an eye on this comment as I'll be updating it with information as things progress.

This PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Have you considered adding tests to cover the change you're making? Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you.

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ❌ Only a DT maintainer can merge changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 45441,
  "author": "digijap",
  "owners": [
    "seikho",
    "nlaplante",
    "isac322",
    "lazarusx",
    "meisenzahl",
    "thegecko",
    "CameronDiver",
    "p4sca1",
    "stuartthomson"
  ],
  "dangerLevel": "ScopedAndUntested",
  "headCommitAbbrOid": "ba00b0b",
  "headCommitOid": "ba00b0b97ffc1bf49fc6f070eb30bf3750469b5d",
  "mergeIsRequested": false,
  "stalenessInDays": 0,
  "lastCommitDate": "2020-06-12T07:37:18.000Z",
  "lastCommentDate": "2020-06-12T18:01:32.000Z",
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45441/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": true,
  "popularityLevel": "Well-liked by everyone",
  "anyPackageIsNew": false,
  "packages": [
    "dockerode"
  ],
  "files": [
    {
      "filePath": "types/dockerode/index.d.ts",
      "kind": "definition",
      "package": "dockerode"
    }
  ],
  "hasDismissedReview": false,
  "ciResult": "pass",
  "lastReviewDate": "2020-06-12T08:35:13.000Z",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 2,
  "isChangesRequested": false
}

@typescript-bot
Copy link
Contributor

🔔 @Seikho @nlaplante @isac322 @LazarusX @meisenzahl @thegecko @CameronDiver @P4sca1 @stuartthomson - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot removed the Where is GH Actions? GH Actions didn't give a response to this PR label Jun 12, 2020
@typescript-bot typescript-bot moved this from Other to Needs Maintainer Review in New Pull Request Status Board Jun 12, 2020
@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #45441 diff
Batch compilation
Memory usage (MiB) 69.2 70.0 +1.2%
Type count 8805 8805 0%
Assignability cache size 855 855 0%
Language service
Samples taken 323 323 0%
Identifiers in tests 323 323 0%
getCompletionsAtPosition
    Mean duration (ms) 312.6 310.7 -0.6%
    Mean CV 9.1% 10.1%
    Worst duration (ms) 411.2 418.0 +1.6%
    Worst identifier then containers
getQuickInfoAtPosition
    Mean duration (ms) 315.3 311.0 -1.4%
    Mean CV 9.2% 9.8% +6.1%
    Worst duration (ms) 398.8 407.2 +2.1%
    Worst identifier then containers

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label Jun 12, 2020
Copy link
Contributor

@thegecko thegecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Jun 12, 2020
Copy link
Contributor

@stuartthomson stuartthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@orta
Copy link
Collaborator

orta commented Jun 12, 2020

Nice, cool, verified with the docs 👍

@orta orta merged commit f3227e8 into DefinitelyTyped:master Jun 12, 2020
@typescript-bot typescript-bot removed this from Needs Maintainer Review in New Pull Request Status Board Jun 12, 2020
@typescript-bot
Copy link
Contributor

I just published @types/dockerode@2.5.32 to npm.

jjballano-qatium pushed a commit to jjballano-qatium/DefinitelyTyped that referenced this pull request Jun 16, 2020
ngbrown pushed a commit to ngbrown-forks/DefinitelyTyped that referenced this pull request Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Owner Approved A listed owner of this package signed off on the pull request. Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants