Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[arcgis-js-api] Update for version 4.16 #45983

Merged
merged 1 commit into from
Jul 10, 2020

Conversation

dasa
Copy link
Contributor

@dasa dasa commented Jul 9, 2020

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: https://developers.arcgis.com/javascript/latest/guide/release-notes/
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • Include tests for your changes
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

@typescript-bot typescript-bot added Where is GH Actions? GH Actions didn't give a response to this PR Untested Change This PR does not touch tests labels Jul 9, 2020
@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 9, 2020

@dasa Thank you for submitting this PR!

This is a live comment which I will keep updated.

This PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Have you considered adding tests to cover the change you're making? Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you.

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ❌ Only a DT maintainer can merge changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 45983,
  "author": "dasa",
  "owners": [
    "Esri",
    "bsvensson"
  ],
  "dangerLevel": "ScopedAndUntested",
  "headCommitAbbrOid": "45ed011",
  "headCommitOid": "45ed01143384a3e60cc37f2905d495bb03bdb7cb",
  "mergeIsRequested": false,
  "stalenessInDays": 0,
  "lastPushDate": "2020-07-09T19:06:54.000Z",
  "lastCommentDate": "2020-07-09T19:06:54.000Z",
  "maintainerBlessed": false,
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45983/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": false,
  "popularityLevel": "Well-liked by everyone",
  "anyPackageIsNew": false,
  "packages": [
    "arcgis-js-api"
  ],
  "files": [
    {
      "path": "types/arcgis-js-api/index.d.ts",
      "kind": "definition",
      "package": "arcgis-js-api"
    }
  ],
  "hasDismissedReview": false,
  "ciResult": "pass",
  "lastReviewDate": "2020-07-09T20:10:10.000Z",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 2,
  "isChangesRequested": false
}

@typescript-bot
Copy link
Contributor

🔔 @Esri @bsvensson - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot removed the Where is GH Actions? GH Actions didn't give a response to this PR label Jul 9, 2020
@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #45983 diff
Batch compilation
Memory usage (MiB) 123.3 125.1 +1.5%
Type count 19595 20299 +4%
Assignability cache size 5917 6078 +3%
Language service
Samples taken 25 25 0%
Identifiers in tests 25 25 0%
getCompletionsAtPosition
    Mean duration (ms) 1068.8 1112.3 +4.1%
    Mean CV 7.0% 6.4%
    Worst duration (ms) 1181.0 1249.1 +5.8%
    Worst identifier map zoom
getQuickInfoAtPosition
    Mean duration (ms) 1055.0 1106.3 +4.9%
    Mean CV 5.3% 4.9% -8.0%
    Worst duration (ms) 1164.0 1239.0 +6.4%
    Worst identifier zoom MapView

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label Jul 9, 2020
Copy link

@bsvensson bsvensson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good :)

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Jul 9, 2020
@weswigham weswigham merged commit 0d4dbb9 into DefinitelyTyped:master Jul 10, 2020
@typescript-bot
Copy link
Contributor

I just published @types/arcgis-js-api@4.16.0 to npm.

ngbrown pushed a commit to ngbrown-forks/DefinitelyTyped that referenced this pull request Jul 11, 2020
@dasa dasa deleted the arcgis-js-api-4 branch July 13, 2020 16:19
danielrearden pushed a commit to danielrearden/DefinitelyTyped that referenced this pull request Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Owner Approved A listed owner of this package signed off on the pull request. Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants