[tabulator-tables] findTable returns Tabulator[] instead of single Ta…

[simusr2]

…bulator object

In Tabulator 4.7 findTable returns Tabulator[] instead of single Tabulator object.

'The findTable function will return an array of matching tables.'

Ref: http://tabulator.info/docs/4.7/options#find-table

[typescript-bot]

@simusr2 Thank you for submitting this PR!

This is a live comment which I will keep updated.

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 46229,
  "author": "simusr2",
  "owners": [
    "jojoshua"
  ],
  "dangerLevel": "ScopedAndTested",
  "headCommitAbbrOid": "f6fbc30",
  "headCommitOid": "f6fbc3099e7aed17e6a7c63cc0ff1df3752f67dc",
  "mergeIsRequested": true,
  "stalenessInDays": 0,
  "lastPushDate": "2020-07-21T13:50:22.000Z",
  "lastCommentDate": "2020-07-22T15:54:20.000Z",
  "maintainerBlessed": false,
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/46229/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": false,
  "popularityLevel": "Well-liked by everyone",
  "anyPackageIsNew": false,
  "packages": [
    "tabulator-tables"
  ],
  "files": [
    {
      "path": "types/tabulator-tables/index.d.ts",
      "kind": "definition",
      "package": "tabulator-tables"
    },
    {
      "path": "types/tabulator-tables/tabulator-tables-tests.ts",
      "kind": "test",
      "package": "tabulator-tables"
    }
  ],
  "hasDismissedReview": false,
  "ciResult": "pass",
  "lastReviewDate": "2020-07-22T01:57:47.000Z",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 2,
  "isChangesRequested": false
}

[typescript-bot]

🔔 @Jojoshua — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

@simusr2 The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

[typescript-bot]

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊

	master	#46229	diff
Batch compilation
Memory usage (MiB)	75.1	78.2	+4.1%
Type count	11982	11983	0%
Assignability cache size	3781	3781	0%
Language service
Samples taken	921	921	0%
Identifiers in tests	921	921	0%
getCompletionsAtPosition
Mean duration (ms)	310.0	346.9	+11.9%
Mean CV	10.4%	9.6%
Worst duration (ms)	412.7	441.8	+7.0%
Worst identifier	row	response
getQuickInfoAtPosition
Mean duration (ms)	313.6	350.1	+11.7%
Mean CV	10.7%	9.5%	-10.9%
Worst duration (ms)	426.1	444.6	+4.3%
Worst identifier	headerFilterLiveFilterDelay	table

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

[typescript-bot]

@simusr2 Everything looks good here. Great job! I am ready to merge this PR on your behalf.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@Jojoshua: you can do this too.)

[Jojoshua]

Ready to merge

[Jojoshua]

@RyanCavanaugh , is the bot misbehaving? It looked like the owner can 'Ready to merge' but no instant merge happening.

[simusr2]

Should I try to post the merge command?

[Jojoshua]

Yea go ahead it will probably work for you

[simusr2]

Ready to merge

[orta]

I've got a PR sent to the bot which I think would fix it, but for now I'll hit the merge button for you - thanks!