react-native-calendars: Add missing enableSwipeMonths prop

[jdmunro]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change. (Run with npm test.)
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm run lint package-name (or tsc if no tslint.json is present).
• Provide a URL to documentation or source code which provides context for the suggested changes:
• https://github.com/wix/react-native-calendars/search?q=enableSwipeMonths&unscoped_q=enableSwipeMonths
• Include tests for your changes

A little more explanation for the changes:

• We cannot simply use CalendarBaseProps for CalendarListBaseProps directly anymore because enableSwipeMonths is not compatible with CalendarList. Therefore I opted to pick the properties we actually want, rather than trying to exclude only the one we don't - it's a bit safer this way for future versions. Happy to reimplement this if other's disagree though 😄

[typescript-bot]

@jdmunro Thank you for submitting this PR!

This is a live comment which I will keep updated.

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 46376,
  "author": "jdmunro",
  "owners": [
    "Tyler-Zhang",
    "DavidNorena",
    "FabianMeul"
  ],
  "dangerLevel": "ScopedAndTested",
  "headCommitAbbrOid": "96d7063",
  "headCommitOid": "96d7063b1b6df70a76194ea88d719639adb4ff65",
  "mergeIsRequested": true,
  "stalenessInDays": 0,
  "lastPushDate": "2020-07-28T07:46:45.000Z",
  "lastCommentDate": "2020-07-30T16:20:28.000Z",
  "maintainerBlessed": false,
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/46376/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": false,
  "popularityLevel": "Well-liked by everyone",
  "anyPackageIsNew": false,
  "packages": [
    "react-native-calendars"
  ],
  "files": [
    {
      "path": "types/react-native-calendars/index.d.ts",
      "kind": "definition",
      "package": "react-native-calendars"
    },
    {
      "path": "types/react-native-calendars/react-native-calendars-tests.tsx",
      "kind": "test",
      "package": "react-native-calendars"
    }
  ],
  "hasDismissedReview": false,
  "ciResult": "pass",
  "lastReviewDate": "2020-07-30T16:18:00.000Z",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 2,
  "isChangesRequested": false
}

[typescript-bot]

🔔 @Tyler-Zhang @DavidNorena @FabianMeul — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊

	master	#46376	diff
Batch compilation
Memory usage (MiB)	91.5	92.7	+1.4%
Type count	20973	21014	0%
Assignability cache size	4404	4404	0%
Language service
Samples taken	354	355	0%
Identifiers in tests	354	355	0%
getCompletionsAtPosition
Mean duration (ms)	427.1	439.0	+2.8%
Mean CV	7.8%	8.0%
Worst duration (ms)	653.7	638.2	-2.4%
Worst identifier	firstDay	monthFormat
getQuickInfoAtPosition
Mean duration (ms)	421.9	431.3	+2.2%
Mean CV	8.3%	8.0%	-2.9%
Worst duration (ms)	615.4	657.3	+6.8%
Worst identifier	date	style

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

[Tyler-Zhang]

@jdmunro Perhaps it would be cleaner to extend the CalendarProps?

I.e

type CalendarProps = CalendarMarkingProps & CalendarBaseProps & {
    enableSwipeMonths?: boolean;
}

export class Calendar extends React.Component<CalendarProps> { }

[jdmunro]

Indeed that's much simpler @Tyler-Zhang - I've made the changes thanks!

[Tyler-Zhang]

LGTM

[typescript-bot]

@jdmunro Everything looks good here. Great job! I am ready to merge this PR on your behalf.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@Tyler-Zhang, @DavidNorena, @FabianMeul: you can do this too.)

[jdmunro]

Ready to merge