[ember-data/model] Support @attr without invoking

[wagenet]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change. (Run with npm test YOUR_PACKAGE_NAME.)
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: @attr decorator cannot be used without invoking it (@attr() works) typed-ember/ember-cli-typescript#1291

[typescript-bot]

@wagenet Thank you for submitting this PR!

This is a live comment which I will keep updated.

2 packages in this PR

• ember-data on npm, on unpkg
• ember-data__model on npm, on unpkg

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 48654,
  "author": "wagenet",
  "owners": [
    "dwickern",
    "mike-north",
    "chriskrycho",
    "jamescdavis",
    "dfreeman"
  ],
  "dangerLevel": "ScopedAndTested",
  "headCommitAbbrOid": "ffe7167",
  "headCommitOid": "ffe7167f2f3813a436bb2a0401ad36e323126588",
  "mergeIsRequested": true,
  "stalenessInDays": 0,
  "lastPushDate": "2020-10-09T18:41:52.000Z",
  "lastCommentDate": "2020-10-13T15:59:55.000Z",
  "maintainerBlessed": false,
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/48654/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": false,
  "popularityLevel": "Well-liked by everyone",
  "newPackages": [],
  "packages": [
    "ember-data",
    "ember-data__model"
  ],
  "files": [
    {
      "path": "types/ember-data/index.d.ts",
      "kind": "definition",
      "package": "ember-data"
    },
    {
      "path": "types/ember-data__model/test/model.ts",
      "kind": "test",
      "package": "ember-data__model"
    }
  ],
  "hasDismissedReview": false,
  "ciResult": "pass",
  "lastReviewDate": "2020-10-10T12:50:12.000Z",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 2,
  "isChangesRequested": false
}

[typescript-bot]

🔔 @dwickern @mike-north @chriskrycho @jamescdavis @dfreeman — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

ember-data/v*

Comparison details for ember-data/* 📊

	master	#48654	diff
Batch compilation
Memory usage (MiB)	122.6	132.3	+7.9%
Type count	32908	32908	0%
Assignability cache size	8079	8079	0%
Language service
Samples taken	1079	1079	0%
Identifiers in tests	1463	1463	0%
getCompletionsAtPosition
Mean duration (ms)	659.8	656.5	-0.5%
Mean CV	6.2%	7.1%
Worst duration (ms)	834.9	865.6	+3.7%
Worst identifier	T	polymorphic
getQuickInfoAtPosition
Mean duration (ms)	697.0	683.8	-1.9%
Mean CV	9.6%	9.5%	-1.6%
Worst duration (ms)	984.9	964.5	-2.1%
Worst identifier	hasMany	findAll

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

ember-data__model/v*

Comparison details for ember-data__model/* 📊

	master	#48654	diff
Batch compilation
Memory usage (MiB)	111.3	112.8	+1.3%
Type count	24507	24507	0%
Assignability cache size	5548	5549	0%
Language service
Samples taken	148	148	0%
Identifiers in tests	148	148	0%
getCompletionsAtPosition
Mean duration (ms)	660.0	678.1	+2.7%
Mean CV	8.7%	9.0%
Worst duration (ms)	798.2	844.3	+5.8%
Worst identifier	T	T
getQuickInfoAtPosition
Mean duration (ms)	683.9	688.6	+0.7%
Mean CV	9.0%	8.0%	-10.9%
Worst duration (ms)	958.6	839.6	-12.4%
Worst identifier	hasMany	hasMany

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

[jamescdavis]

Thank you!

[typescript-bot]

@wagenet Everything looks good here. Great job! I am ready to merge this PR on your behalf.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@dwickern, @mike-north, @chriskrycho, @jamescdavis, @dfreeman: you can do this too.)

[wagenet]

Ready to merge

[typescript-bot]

I just published @types/ember-data@3.16.6 to npm.