-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[accept] Remove types #48826
[accept] Remove types #48826
Conversation
0170a2b
to
3822031
Compare
@jablko Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 48826,
"author": "jablko",
"owners": [
"feinoujc"
],
"dangerLevel": "ScopedAndConfiguration",
"headCommitAbbrOid": "3822031",
"headCommitOid": "3822031f3a956a326d1563c301b4cf5bb024344f",
"mergeIsRequested": false,
"stalenessInDays": 0,
"lastPushDate": "2020-10-15T18:39:45.000Z",
"reopenedDate": "2020-10-15T18:49:19.000Z",
"lastCommentDate": "2020-10-15T18:39:45.000Z",
"maintainerBlessed": false,
"reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/48826/files",
"hasMergeConflict": false,
"authorIsOwner": false,
"isFirstContribution": false,
"popularityLevel": "Well-liked by everyone",
"newPackages": [],
"packages": [
"accept"
],
"files": [
{
"path": "types/accept/accept-tests.ts",
"kind": "test",
"package": "accept"
},
{
"path": "types/accept/index.d.ts",
"kind": "definition",
"package": "accept"
},
{
"path": "types/accept/tsconfig.json",
"kind": "package-meta",
"package": "accept",
"suspect": "couldn't fetch contents"
},
{
"path": "types/accept/tslint.json",
"kind": "package-meta",
"package": "accept",
"suspect": "couldn't fetch contents"
}
],
"hasDismissedReview": false,
"ciResult": "pass",
"lastReviewDate": "2020-10-15T18:54:30.000Z",
"reviewersWithStaleReviews": [],
"approvalFlags": 2,
"isChangesRequested": false
} |
🔔 @feinoujc — please review this PR in the next few days. Be sure to explicitly select |
Cool, thanks |
Removed in #48826, not sure whether it's possible to properly deprecate it, so I'm going to try.
Removed in #48826, not sure whether it's possible to properly deprecate it, so I'm going to try.
These types appear to be for a deprecated npm package:
Can they be removed?
npm test YOUR_PACKAGE_NAME
.)npm run lint package-name
(ortsc
if notslint.json
is present).