Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[accept] Remove types #48826

Merged
merged 1 commit into from
Oct 16, 2020
Merged

[accept] Remove types #48826

merged 1 commit into from
Oct 16, 2020

Conversation

jablko
Copy link
Contributor

@jablko jablko commented Oct 15, 2020

These types appear to be for a deprecated npm package:

This module has moved and is now available at @hapi/accept. Please update your dependencies as this version is no longer maintained an may contain bugs and security issues.

Can they be removed?

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test YOUR_PACKAGE_NAME.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

@typescript-bot typescript-bot added this to Needs Author Action in New Pull Request Status Board Oct 15, 2020
@jablko jablko marked this pull request as ready for review October 15, 2020 18:49
@typescript-bot typescript-bot added the Check Config Changes a module config files label Oct 15, 2020
@typescript-bot typescript-bot moved this from Needs Author Action to Needs Maintainer Review in New Pull Request Status Board Oct 15, 2020
@typescript-bot
Copy link
Contributor

typescript-bot commented Oct 15, 2020

@jablko Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ❌ A DT maintainer needs to approve changes which affect module config files
    • accept/tsconfig.json: couldn't fetch contents
    • accept/tslint.json: couldn't fetch contents

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 48826,
  "author": "jablko",
  "owners": [
    "feinoujc"
  ],
  "dangerLevel": "ScopedAndConfiguration",
  "headCommitAbbrOid": "3822031",
  "headCommitOid": "3822031f3a956a326d1563c301b4cf5bb024344f",
  "mergeIsRequested": false,
  "stalenessInDays": 0,
  "lastPushDate": "2020-10-15T18:39:45.000Z",
  "reopenedDate": "2020-10-15T18:49:19.000Z",
  "lastCommentDate": "2020-10-15T18:39:45.000Z",
  "maintainerBlessed": false,
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/48826/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": false,
  "popularityLevel": "Well-liked by everyone",
  "newPackages": [],
  "packages": [
    "accept"
  ],
  "files": [
    {
      "path": "types/accept/accept-tests.ts",
      "kind": "test",
      "package": "accept"
    },
    {
      "path": "types/accept/index.d.ts",
      "kind": "definition",
      "package": "accept"
    },
    {
      "path": "types/accept/tsconfig.json",
      "kind": "package-meta",
      "package": "accept",
      "suspect": "couldn't fetch contents"
    },
    {
      "path": "types/accept/tslint.json",
      "kind": "package-meta",
      "package": "accept",
      "suspect": "couldn't fetch contents"
    }
  ],
  "hasDismissedReview": false,
  "ciResult": "pass",
  "lastReviewDate": "2020-10-15T18:54:30.000Z",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 2,
  "isChangesRequested": false
}

@typescript-bot
Copy link
Contributor

🔔 @feinoujc — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Oct 15, 2020
@orta
Copy link
Collaborator

orta commented Oct 16, 2020

Cool, thanks

@orta orta merged commit 239d180 into DefinitelyTyped:master Oct 16, 2020
@typescript-bot typescript-bot removed this from Needs Maintainer Review in New Pull Request Status Board Oct 16, 2020
sandersn added a commit that referenced this pull request Oct 16, 2020
Removed in #48826, not sure whether it's possible to properly deprecate
it, so I'm going to try.
@sandersn sandersn mentioned this pull request Oct 16, 2020
sandersn added a commit that referenced this pull request Oct 16, 2020
Removed in #48826, not sure whether it's possible to properly deprecate
it, so I'm going to try.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Check Config Changes a module config files Owner Approved A listed owner of this package signed off on the pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants