Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-native: add deprecation notice for deprecated components/modules #48869

Conversation

Naturalclar
Copy link
Contributor

Added @deprecated to components/modules that has been deprecated/removed from react-native.

It's set up so that those modules would show up as deprecated with a linethrough when you see it on vscode

Screen Shot 2020-10-17 at 17 14 29

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test YOUR_PACKAGE_NAME.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/facebook/react-native/blob/master/index.js
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • Include tests for your changes
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

@typescript-bot typescript-bot added Critical package Author is Owner The author of this PR is a listed owner of the package. labels Oct 17, 2020
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Oct 17, 2020
@typescript-bot
Copy link
Contributor

typescript-bot commented Oct 17, 2020

@Naturalclar Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 48869,
  "author": "Naturalclar",
  "owners": [
    "alloy",
    "huhuanming",
    "iRoachie",
    "timwangdev",
    "kamal",
    "alexdunne",
    "swissmanu",
    "bm-software",
    "a-tarasyuk",
    "mvdam",
    "esemesek",
    "mrnickel",
    "souvik-ghosh",
    "nossbigg",
    "saranshkataria",
    "franzmoro",
    "tykus160",
    "jakebloom",
    "ceyhun",
    "mcmar",
    "theohdv",
    "TheSavior",
    "romain-faust",
    "bebebebebe",
    "Naturalclar",
    "chinesedfan",
    "vtolochk",
    "SychevSP",
    "RageBill",
    "sasurau4",
    "256hz",
    "doumart",
    "drmas",
    "akrger",
    "jeremybarbet",
    "ca057",
    "ds300",
    "natsathorn",
    "connectdotz",
    "TheWirv",
    "alexeymolchan",
    "alexbrazier"
  ],
  "dangerLevel": "ScopedAndTested",
  "headCommitAbbrOid": "cb859f9",
  "headCommitOid": "cb859f9c9a527a350a8185716115952270ba79eb",
  "mergeIsRequested": true,
  "stalenessInDays": 0,
  "lastPushDate": "2020-10-17T08:15:26.000Z",
  "lastCommentDate": "2020-10-20T14:49:07.000Z",
  "maintainerBlessed": true,
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/48869/files",
  "hasMergeConflict": false,
  "authorIsOwner": true,
  "isFirstContribution": false,
  "popularityLevel": "Critical",
  "newPackages": [],
  "packages": [
    "react-native"
  ],
  "files": [
    {
      "path": "types/react-native/index.d.ts",
      "kind": "definition",
      "package": "react-native"
    },
    {
      "path": "types/react-native/test/index.tsx",
      "kind": "test",
      "package": "react-native"
    }
  ],
  "hasDismissedReview": false,
  "ciResult": "pass",
  "lastReviewDate": "2020-10-18T09:12:36.000Z",
  "firstApprovalDate": "2020-10-18T09:12:36.000Z",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 2,
  "isChangesRequested": false
}

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Oct 17, 2020
@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #48869 diff
Batch compilation
Memory usage (MiB) 106.6 105.1 -1.4%
Type count 32444 32444 0%
Assignability cache size 8653 8653 0%
Language service
Samples taken 2119 2124 0%
Identifiers in tests 2785 2790 0%
getCompletionsAtPosition
    Mean duration (ms) 384.7 384.0 -0.2%
    Mean CV 7.1% 6.8%
    Worst duration (ms) 603.1 563.8 -6.5%
    Worst identifier style undefined
getQuickInfoAtPosition
    Mean duration (ms) 381.9 381.1 -0.2%
    Mean CV 6.9% 6.8% -0.7%
    Worst duration (ms) 548.3 526.5 -4.0%
    Worst identifier flattenStyle value

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label Oct 17, 2020
@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Oct 18, 2020
@elibarzilay elibarzilay moved this from Needs Maintainer Review to Waiting for Author to Merge in New Pull Request Status Board Oct 20, 2020
@typescript-bot typescript-bot added the Self Merge This PR can now be self-merged by the PR author or an owner label Oct 20, 2020
@typescript-bot
Copy link
Contributor

@Naturalclar Everything looks good here. Great job! I am ready to merge this PR on your behalf.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@alloy, @huhuanming, @iRoachie, @timwangdev, @kamal, @alexdunne, @swissmanu, @bm-software, @a-tarasyuk, @mvdam, @Esemesek, @mrnickel, @souvik-ghosh, @nossbigg, @saranshkataria, @franzmoro, @tykus160, @jakebloom, @ceyhun, @mcmar, @theohdv, @TheSavior, @romain-faust, @bebebebebe, @chinesedfan, @vtolochk, @SychevSP, @RageBill, @sasurau4, @256hz, @doumart, @drmas, @akrger, @jeremybarbet, @ca057, @ds300, @natsathorn, @connectdotz, @TheWirv, @alexeymolchan, @alexbrazier: you can do this too.)

@Naturalclar
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Oct 20, 2020
@typescript-bot typescript-bot merged commit cc68288 into DefinitelyTyped:master Oct 20, 2020
@typescript-bot
Copy link
Contributor

I just published @types/react-native@0.63.27 to npm.

@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author is Owner The author of this PR is a listed owner of the package. Critical package Owner Approved A listed owner of this package signed off on the pull request. Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants