Upgrade temp package to 0.9 (Add Promise return types for async functions)

[abettadapur]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change. (Run with npm test YOUR_PACKAGE_NAME.)
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: <bruce/node-temp@e649841>
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
• Include tests for your changes
• If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

[typescript-bot]

@abettadapur Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• temp on npm, on unpkg

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Inactive

This PR has been inactive for 31 days — closed because it wasn't merged for a long time!

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 49028,
  "author": "abettadapur",
  "headCommitAbbrOid": "3194d7f",
  "headCommitOid": "3194d7f79a00f3c5158ba467d8ad0f04ef8494a6",
  "lastPushDate": "2020-10-22T19:24:54.000Z",
  "lastActivityDate": "2020-12-03T23:04:35.000Z",
  "maintainerBlessed": false,
  "mergeOfferDate": "2020-12-02T23:32:43.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "temp",
      "kind": "edit",
      "files": [
        {
          "path": "types/temp/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/temp/temp-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "DanielRosenwasser"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "amcasey",
      "date": "2020-12-02T23:32:07.000Z",
      "isMaintainer": true
    }
  ],
  "ciResult": "pass"
}

[typescript-bot]

🔔 @DanielRosenwasser — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊

	master	#49028	diff
Batch compilation
Memory usage (MiB)	72.3	73.1	+1.0%
Type count	9183	9188	0%
Assignability cache size	1635	1630	0%
Language service
Samples taken	117	126	+8%
Identifiers in tests	117	126	+8%
getCompletionsAtPosition
Mean duration (ms)	359.0	363.3	+1.2%
Mean CV	10.3%	10.5%
Worst duration (ms)	432.0	435.6	+0.8%
Worst identifier	path	cleanupSync
getQuickInfoAtPosition
Mean duration (ms)	358.3	358.6	+0.1%
Mean CV	10.3%	10.5%	+2.5%
Worst duration (ms)	428.9	435.2	+1.5%
Worst identifier	testCleanupSync	testMkdirSync

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

[abettadapur]

@DanielRosenwasser who should I ask for a review on this?

[typescript-bot]

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @abettadapur.

(Ping @DanielRosenwasser.)

[amcasey]

Optional suggestion.

[amcasey]

Looks like callback is actually non-optional in this overload then?

[typescript-bot]

@abettadapur Everything looks good here. Great job! I am ready to merge this PR (at 3194d7f) on your behalf.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@DanielRosenwasser: you can do this too.)

[DanielRosenwasser]

@abettadapur sorry for the delay. I actually don't use this package much anymore, so if you'd be open to it, you can add yourself as a maintainer by adding yourself to the file header.

[typescript-bot]

Re-ping @abettadapur / @DanielRosenwasser:

This PR has been ready to merge for over a week, and I haven't seen any requests to merge it. I will close it in three weeks if this doesn't happen.

(If there's no reason to avoid merging it, please do so. Otherwise, if it shouldn't be merged or if it needs more time, please close it or turn it into a draft.)

[typescript-bot]

After a month, no one has requested merging the PR 😞. I'm going to assume that the change is not wanted after all, and will therefore close it.