Serverless awsProvider.d.ts fix + addition

[Namstel]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change. (Run with npm test YOUR_PACKAGE_NAME.)
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: https://www.serverless.com/framework/docs/providers/aws/guide/layers/ & https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-sns-subscription.html
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
• Include tests for your changes
• If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

[typescript-bot]

@Namstel Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

• serverless on npm, on unpkg

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ❌ Most recent commit is approved by type definition owners, DT maintainers or others

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 26 days — it is still unreviewed!

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 49104,
  "author": "Namstel",
  "headCommitAbbrOid": "8005d95",
  "headCommitOid": "8005d959e83d7fc778be4b6c50b23646fcc16c5d",
  "lastPushDate": "2020-11-26T12:52:29.000Z",
  "lastActivityDate": "2020-11-26T12:52:29.000Z",
  "maintainerBlessed": false,
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "serverless",
      "kind": "edit",
      "files": [
        {
          "path": "types/serverless/plugins/aws/provider/awsProvider.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/serverless/serverless-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "hassankhan",
        "JonathanWilbur",
        "a-pavlenko",
        "fredericbarthelet",
        "bryan-hunter",
        "thomasaribart"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "stale",
      "reviewer": "fredericbarthelet",
      "date": "2020-11-20T19:50:07.000Z",
      "abbrOid": "10691c6"
    }
  ],
  "ciResult": "pass"
}

[typescript-bot]

🔔 @hassankhan @JonathanWilbur @a-pavlenko @fredericbarthelet @bryan-hunter @ThomasAribart — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊

	master	#49104	diff
Batch compilation
Memory usage (MiB)	38.4	45.3	+18.0%
Type count	3020	3023	0%
Assignability cache size	290	290	0%
Language service
Samples taken	470	470	0%
Identifiers in tests	470	470	0%
getCompletionsAtPosition
Mean duration (ms)	88.8	89.4	+0.7%
Mean CV	14.4%	14.4%
Worst duration (ms)	159.1	171.3	+7.6%
Worst identifier	layers	resources
getQuickInfoAtPosition
Mean duration (ms)	88.4	89.2	+1.0%
Mean CV	14.4%	14.5%	+1.2%
Worst duration (ms)	129.9	129.8	0.0%
Worst identifier	testFunction	identitySource

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

[Namstel]

I've also added the type property to the Stream interface according to the following specs:
https://www.serverless.com/framework/docs/providers/aws/events/streams/

[Namstel]

🔔 @hassankhan @JonathanWilbur @a-pavlenko @fredericbarthelet @bryan-hunter @ThomasAribart — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

Hi, I would love to hear from any of you.

Sincerely,
Niels

[fredericbarthelet]

filterPolicy is an object of attributes to be filtered against string, numeric or boolean value. It can also contain exists, anything-but... filters. (cf https://docs.aws.amazon.com/sns/latest/dg/sns-subscription-filter-policies.html)
If you agree, I'd rather go for the filterPolicy?: Record<string, unknown> type

[fredericbarthelet]

Thank you for your contribution @Namstel and sorry for the late reploy :) I made a few comments on your PR. Let me know if you agree. Thanks

[typescript-bot]

@Namstel One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits or comments. If you disagree with the reviewer's comments, you can "dismiss" the review using GitHub's review UI. Thank you!

[typescript-bot]

@fredericbarthelet Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

[typescript-bot]

@Namstel The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

[Namstel]

Thanks @fredericbarthelet ! I've applied the suggestions.

[typescript-bot]

@Namstel The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

[typescript-bot]

Re-ping @hassankhan, @JonathanWilbur, @a-pavlenko, @fredericbarthelet, @bryan-hunter, @ThomasAribart:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

[typescript-bot]

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @Namstel.

(Ping @hassankhan, @JonathanWilbur, @a-pavlenko, @fredericbarthelet, @bryan-hunter, @ThomasAribart.)

[orta]

Cool, thanks, this looks like it fits the docs - let's get it in

[typescript-bot]

I just published @types/serverless@1.78.16 to npm.