Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bookshelf] Add autoRefresh and update knex #49360

Merged

Conversation

OlivierKamers
Copy link
Contributor

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test YOUR_PACKAGE_NAME.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

@typescript-bot
Copy link
Contributor

typescript-bot commented Nov 4, 2020

@OlivierKamers Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 49360,
  "author": "OlivierKamers",
  "dangerLevel": "ScopedAndTested",
  "headCommitAbbrOid": "61e8039",
  "headCommitOid": "61e8039be9ca731f4c16a6da9687251c40fb8de8",
  "mergeIsRequested": true,
  "stalenessInDays": 0,
  "lastPushDate": "2020-11-04T16:54:39.000Z",
  "lastCommentDate": "2020-11-05T09:37:15.000Z",
  "maintainerBlessed": false,
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49360/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "bookshelf",
      "files": [
        {
          "path": "types/bookshelf/bookshelf-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/bookshelf/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/bookshelf/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "arcticwaters",
        "vesse"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "hasDismissedReview": false,
  "ciResult": "pass",
  "lastReviewDate": "2020-11-04T19:17:35.000Z",
  "firstApprovalDate": "2020-11-04T19:17:35.000Z",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 2,
  "isChangesRequested": false
}

@typescript-bot
Copy link
Contributor

🔔 @arcticwaters @vesse — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #49360 diff
Batch compilation
Memory usage (MiB) 131.1 137.8 +5.1%
Type count 39567 40152 +1%
Assignability cache size 8947 9044 +1%
Language service
Samples taken 1360 1361 0%
Identifiers in tests 1360 1361 0%
getCompletionsAtPosition
    Mean duration (ms) 636.6 638.3 +0.3%
    Mean CV 7.3% 7.3%
    Worst duration (ms) 922.3 945.0 +2.5%
    Worst identifier fetch Book
getQuickInfoAtPosition
    Mean duration (ms) 637.1 638.8 +0.3%
    Mean CV 7.5% 7.7% +3.0%
    Worst duration (ms) 901.1 941.8 +4.5%
    Worst identifier belongsTo belongsTo

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label Nov 4, 2020
Copy link
Contributor

@vesse vesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner labels Nov 4, 2020
@typescript-bot
Copy link
Contributor

@OlivierKamers Everything looks good here. Great job! I am ready to merge this PR on your behalf.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@arcticwaters, @vesse: you can do this too.)

@OlivierKamers
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot merged commit cd1973a into DefinitelyTyped:master Nov 5, 2020
@OlivierKamers OlivierKamers deleted the update-bookshelf-knex branch November 5, 2020 09:38
@typescript-bot
Copy link
Contributor

I just published @types/bookshelf@1.2.0 to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Owner Approved A listed owner of this package signed off on the pull request. Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants