[types/factory_girl] Make factory can be used named import / Add override definitions for seq and sequence

[ishikawa]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

Select one of these and delete the others:

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes:
  • Named export https://github.com/simonexmachina/factory-girl/blob/2b71a77af25a5dab18e6849a389955e6d4a2ce72/src/index.js#L13
  • Function signature of seq/sequence https://github.com/simonexmachina/factory-girl/blob/2b71a77af25a5dab18e6849a389955e6d4a2ce72/src/generators/

[typescript-bot]

@ishikawa Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• factory-girl on npm, on unpkg

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 50420,
  "author": "ishikawa",
  "headCommitOid": "e8881a982e991fabc88a8299f8d1026b4908db21",
  "lastPushDate": "2021-01-09T01:08:10.000Z",
  "lastActivityDate": "2021-01-09T01:15:38.000Z",
  "maintainerBlessed": false,
  "mergeOfferDate": "2021-01-09T01:12:56.000Z",
  "mergeRequestDate": "2021-01-09T01:15:38.000Z",
  "mergeRequestUser": "ishikawa",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "factory-girl",
      "kind": "edit",
      "files": [
        {
          "path": "types/factory-girl/factory-girl-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/factory-girl/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "stackbuilders",
        "sestrella",
        "elcuy",
        "OlivierKamers"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "andrewbranch",
      "date": "2021-01-09T01:10:13.000Z",
      "isMaintainer": true
    }
  ],
  "ciResult": "pass"
}

[typescript-bot]

🔔 @stackbuilders @sestrella @elcuy @OlivierKamers — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[ishikawa]

I need this suppression for testing import * and import {...} in the same file.

[andrewbranch]

Makes sense, but can you use a comment to disable it only where needed?

[ishikawa]

@andrewbranch Thanks for your comment. I fixed it in e8881a9.

[typescript-bot]

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊

	master	#50420	diff
Batch compilation
Memory usage (MiB)	38.3	38.5	+0.4%
Type count	2536	2551	+1%
Assignability cache size	164	157	-4%
Language service
Samples taken	230	250	+9%
Identifiers in tests	230	250	+9%
getCompletionsAtPosition
Mean duration (ms)	62.1	63.7	+2.5%
Mean CV	20.9%	19.9%
Worst duration (ms)	95.9	93.6	-2.4%
Worst identifier	boss	assocMany
getQuickInfoAtPosition
Mean duration (ms)	61.8	64.1	+3.7%
Mean CV	19.3%	19.0%
Worst duration (ms)	88.5	105.6	+19.3%
Worst identifier	options	score

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

[danger-public]

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

factory-girl (unpkg)

was missing the following properties:

1. ObjectAdapter
2. BookshelfAdapter
3. DefaultAdapter
4. MongooseAdapter
5. SequelizeAdapter

as well as these 1 other properties...

ReduxORMAdapter

Generated by 🚫 dangerJS against e8881a9

[typescript-bot]

@ishikawa Everything looks good here. Great job! I am ready to merge this PR (at e8881a9) on your behalf.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@stackbuilders, @sestrella, @elcuy, @OlivierKamers: you can do this too.)

[ishikawa]

Ready to merge

[typescript-bot]

I just published @types/factory-girl@5.0.3 to npm.