Quotesy

[natesilva]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

Select one of these and delete the others:

If adding a new definition:

• The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
• If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
• Create it with dts-gen --dt, not by basing it on an existing project.
• Represents shape of module/library correctly
• tslint.json should contain { "extends": "dtslint/dt.json" }, and no additional rules.
• tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

[typescript-bot]

@natesilva Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• quotesy (new!) on npm, on unpkg
  • 1 added owner: ✎@natesilva

Code Reviews

This PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• 🕐 Only a DT maintainer can approve changes when there are new packages added

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 51764,
  "author": "natesilva",
  "headCommitOid": "32df454d17a65e72e7babb04b3f384d7f28e1f54",
  "lastPushDate": "2021-03-15T22:45:30.000Z",
  "lastActivityDate": "2021-03-16T01:24:44.000Z",
  "maintainerBlessed": false,
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "quotesy",
      "kind": "add",
      "files": [
        {
          "path": "types/quotesy/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/quotesy/quotesy-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/quotesy/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/quotesy/tslint.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [],
      "addedOwners": [
        "natesilva"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "nelsonic",
      "date": "2021-03-16T01:24:44.000Z",
      "isMaintainer": false
    },
    {
      "type": "stale",
      "reviewer": "martin-badin",
      "date": "2021-03-15T19:49:15.000Z",
      "abbrOid": "0f50ab1"
    }
  ],
  "ciResult": "pass"
}

[typescript-bot]

🔔 @natesilva — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

[typescript-bot]

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

These typings are for a package that doesn’t yet exist on master, so I don’t have anything to compare against yet! In the future, I’ll be able to compare PRs to quotesy with its source on master.

Comparison details 📊

Batch compilation
Type count	2169
Assignability cache size	95
Language service measurements
Samples taken	7
Identifiers in tests	7
getCompletionsAtPosition
Mean duration (ms)	97.4
Mean CV	28.2%
Worst duration (ms)	138.9
Worst identifier	random_by_tag
getQuickInfoAtPosition
Mean duration (ms)	90.2
Mean CV	23.6%
Worst duration (ms)	96.9
Worst identifier	quotesy
System information
Node version	v14.16.0
CPU count	2
CPU speed	2.095 GHz
CPU model	Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz
CPU Architecture	x64
Memory	6.8 GiB
Platform	linux
Release	4.15.0-1108-azure

[nelsonic]

@natesilva LGTM. 👍
Could be worth adding source and tags to the interface, but otherwise all good.

[natesilva]

Merged suggested changes by @nelsonic.

[typescript-bot]

@natesilva The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

[typescript-bot]

@martin-badin, @nelsonic Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

[nelsonic]

Nice additions @natesilva 👍

[typescript-bot]

@martin-badin Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

[typescript-bot]

I just published @types/quotesy@1.0.0 to npm.