Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move templates which should redirect folks to discussions #53606

Merged
merged 2 commits into from
Jun 10, 2021
Merged

Conversation

orta
Copy link
Collaborator

@orta orta commented Jun 4, 2021

As a part of #53377

@typescript-bot
Copy link
Contributor

typescript-bot commented Jun 4, 2021

@orta Thank you for submitting this PR!

This is a live comment which I will keep updated.

This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?

0 packages in this PR (and infra files)

Code Reviews

There aren't any other owners of this package, so a DT maintainer will review it.

You can test the changes in this PR in the Playground.

Status

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 53606,
  "author": "orta",
  "headCommitOid": "b2c7d50f65fee0ce0a6419e055f5250a69d0cf2b",
  "lastPushDate": "2021-06-04T12:37:36.000Z",
  "lastActivityDate": "2021-06-04T15:30:47.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": null,
      "kind": "edit",
      "files": [
        {
          "path": ".github/ISSUE_TEMPLATE.md",
          "kind": "infrastructure"
        },
        {
          "path": ".github/ISSUE_TEMPLATE/config.yml",
          "kind": "infrastructure"
        },
        {
          "path": ".github/ISSUE_TEMPLATE/infrastructure_issue.md",
          "kind": "infrastructure"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "changereq",
      "reviewer": "RyanCavanaugh",
      "date": "2021-06-04T15:30:47.000Z"
    }
  ],
  "mainBotCommentID": 854681712,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @orta — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in Old Pull Request Status Board Jun 4, 2021

-->

**Is your feature request related to a problem? Please describe.**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove from here down

@typescript-bot typescript-bot added the Revision needed This PR needs code changes before it can be merged. label Jun 4, 2021
@typescript-bot typescript-bot moved this from Needs Maintainer Action to Needs Author Action in Old Pull Request Status Board Jun 4, 2021
@typescript-bot
Copy link
Contributor

@orta One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

@orta orta merged commit 8fb5be0 into master Jun 10, 2021
@typescript-bot typescript-bot removed this from Needs Author Action in Old Pull Request Status Board Jun 10, 2021
@jakebailey jakebailey deleted the new_templates branch March 27, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Edits Infrastructure Revision needed This PR needs code changes before it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants