Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add undefined to optional properties, Mongo to Ol #54345

Merged
merged 3 commits into from
Jul 7, 2021

Conversation

sandersn
Copy link
Contributor

@sandersn sandersn commented Jul 7, 2021

In preparation for exactOptionalPropertyTypes in Typescript 4.4, add undefined to all optional properties. #no-publishing-comment

This PR covers widely used packages, those with more then 100,000 packages per month, from mongodb -- ol.

microsoft/dtslint#335

In preparation for exactOptionalPropertyTypes in Typescript 4.4, add undefined to all optional properties. #no-publishing-comment

This PR covers widely used packages, those with more then 100,000 packages per month, from mongodb -- ol.

microsoft/dtslint#335
@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 7, 2021

@sandersn Thank you for submitting this PR!

This is a live comment which I will keep updated.

20 packages in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ❌ Continuous integration tests have failed
  • 🕐 A DT maintainer needs to approve changes which affect more than one package

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 54345,
  "author": "sandersn",
  "headCommitOid": "36f657f9da05e895dc089fcec4d35aabfdbfeb1a",
  "lastPushDate": "2021-07-07T16:11:01.000Z",
  "lastActivityDate": "2021-07-07T16:17:59.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "mongodb",
      "kind": "edit",
      "files": [
        {
          "path": "types/mongodb/test/collection/distinct.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "CaselIT",
        "alanmarcell",
        "dante-101",
        "mcortesi",
        "EnricoPicci",
        "AJCStriker",
        "julien-c",
        "daprahamian",
        "denys-bushulyak",
        "b4nst",
        "sindbach",
        "geraldinelemeur",
        "various89",
        "angela-1",
        "hector7",
        "floric",
        "erikc5000",
        "Manc",
        "jloveridge",
        "ranguna",
        "HosseinAgha",
        "albertossilva",
        "peterblazejewicz",
        "LinusU",
        "taxilian",
        "xamgore",
        "avaly",
        "HitkoDev",
        "Celend",
        "jtassin",
        "addaleax",
        "emmanuelgautier",
        "wyattjoh",
        "borfig"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "move-concurrently",
      "kind": "edit",
      "files": [
        {
          "path": "types/move-concurrently/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "mgroenhoff"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "node-telegram-bot-api",
      "kind": "edit",
      "files": [
        {
          "path": "types/node-telegram-bot-api/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "ammuench",
        "agadar",
        "Dabolus",
        "Kallu609",
        "XC-Zhang",
        "adityathebe",
        "MiklerGM",
        "ariutin",
        "XieJiSS",
        "toniop99"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "nodemailer",
      "kind": "edit",
      "files": [
        {
          "path": "types/nodemailer/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/nodemailer/lib/base64.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/nodemailer/lib/dkim/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/nodemailer/lib/fetch/cookies.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/nodemailer/lib/fetch/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/nodemailer/lib/json-transport.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/nodemailer/lib/mailer/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/nodemailer/lib/mime-funcs/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/nodemailer/lib/mime-node/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/nodemailer/lib/qp.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/nodemailer/lib/sendmail-transport/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/nodemailer/lib/ses-transport.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/nodemailer/lib/shared.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/nodemailer/lib/smtp-connection/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/nodemailer/lib/smtp-pool/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/nodemailer/lib/smtp-transport.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/nodemailer/lib/stream-transport.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/nodemailer/lib/xoauth2.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/nodemailer/nodemailer-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/nodemailer/v3/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "rogierschouten",
        "dex4er",
        "bioball"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "nodemon",
      "kind": "edit",
      "files": [
        {
          "path": "types/nodemon/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "forivall"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "normalize-package-data",
      "kind": "edit",
      "files": [
        {
          "path": "types/normalize-package-data/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "jdxcode"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "npm-package-arg",
      "kind": "edit",
      "files": [
        {
          "path": "types/npm-package-arg/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "mgroenhoff",
        "OiYouYeahYou"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "npm-packlist",
      "kind": "edit",
      "files": [
        {
          "path": "types/npm-packlist/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "ajafff"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "npm-registry-fetch",
      "kind": "edit",
      "files": [
        {
          "path": "types/npm-registry-fetch/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/npm-registry-fetch/v4/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "ChaosinaCan"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "npm",
      "kind": "edit",
      "files": [
        {
          "path": "types/npm/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "SomaticIT"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "npmlog",
      "kind": "edit",
      "files": [
        {
          "path": "types/npmlog/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "DanielMSchmidt",
        "littlepiggy03",
        "wildlyinaccurate"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "nunjucks",
      "kind": "edit",
      "files": [
        {
          "path": "types/nunjucks/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "RubenSlabbert",
        "MatthewBurstein"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "nwsapi",
      "kind": "edit",
      "files": [
        {
          "path": "types/nwsapi/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "ExE-Boss"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "object-hash",
      "kind": "edit",
      "files": [
        {
          "path": "types/object-hash/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "misak113",
        "artdiniz",
        "martin-badin"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "object-inspect",
      "kind": "edit",
      "files": [
        {
          "path": "types/object-inspect/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "demurgos",
        "Akuukis",
        "ljharb"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "object-path",
      "kind": "edit",
      "files": [
        {
          "path": "types/object-path/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "pocesar",
        "BendingBender"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "object.getownpropertydescriptors",
      "kind": "edit",
      "files": [
        {
          "path": "types/object.getownpropertydescriptors/object.getownpropertydescriptors-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "VitorLuizC",
        "ljharb",
        "ExE-Boss"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "office-js",
      "kind": "edit",
      "files": [
        {
          "path": "types/office-js/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "OfficeDev",
        "Rick-Kirkham",
        "AlexJerabek",
        "ElizabethSamuel-MSFT",
        "alison-mk"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "offscreencanvas",
      "kind": "edit",
      "files": [
        {
          "path": "types/offscreencanvas/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "kayahr",
        "ova2"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "ol",
      "kind": "edit",
      "files": [
        {
          "path": "types/ol/Collection.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/Geolocation.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/Overlay.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/PluggableMap.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/Tile.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/View.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/control.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/control/Attribution.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/control/Control.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/control/FullScreen.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/control/MousePosition.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/control/OverviewMap.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/control/Rotate.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/control/ScaleLine.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/control/Zoom.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/control/ZoomSlider.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/control/ZoomToExtent.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/format/EsriJSON.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/format/Feature.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/format/GMLBase.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/format/GPX.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/format/GeoJSON.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/format/IGC.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/format/IIIFInfo.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/format/KML.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/format/MVT.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/format/Polyline.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/format/TopoJSON.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/format/WFS.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/format/WKT.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/format/WMSGetFeatureInfo.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/interaction.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/interaction/DoubleClickZoom.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/interaction/DragAndDrop.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/interaction/DragBox.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/interaction/DragPan.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/interaction/DragRotate.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/interaction/DragRotateAndZoom.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/interaction/DragZoom.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/interaction/Draw.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/interaction/Extent.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/interaction/KeyboardPan.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/interaction/KeyboardZoom.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/interaction/Modify.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/interaction/MouseWheelZoom.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/interaction/PinchRotate.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/interaction/PinchZoom.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/interaction/Pointer.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/interaction/Select.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/interaction/Snap.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/interaction/Translate.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/layer/Base.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/layer/BaseImage.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/layer/BaseTile.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/layer/BaseVector.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/layer/Graticule.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/layer/Group.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/layer/Heatmap.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/layer/Layer.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/layer/MapboxVector.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/layer/VectorImage.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/layer/VectorTile.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/layer/WebGLPoints.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/ol-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/ol/proj/Projection.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/render.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/render/canvas.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/renderer/webgl/Layer.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/renderer/webgl/PointsLayer.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/source/BingMaps.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/source/CartoDB.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/source/Cluster.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/source/IIIF.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/source/Image.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/source/ImageArcGISRest.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/source/ImageCanvas.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/source/ImageMapGuide.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/source/ImageStatic.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/source/ImageWMS.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/source/OSM.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/source/Raster.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/source/Source.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/source/Stamen.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/source/Tile.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/source/TileArcGISRest.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/source/TileDebug.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/source/TileImage.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/source/TileJSON.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/source/TileWMS.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/source/UTFGrid.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/source/UrlTile.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/source/Vector.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/source/VectorTile.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/source/WMTS.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/source/XYZ.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/source/Zoomify.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/style/Circle.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/style/Fill.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/style/Icon.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/style/LiteralStyle.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/style/RegularShape.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/style/Stroke.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/style/Style.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/style/Text.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/style/expressions.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/tilegrid/TileGrid.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/tilegrid/WMTS.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/Collection.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/Geolocation.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/Graticule.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/Overlay.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/PluggableMap.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/Tile.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/View.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/control/Attribution.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/control/Control.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/control/FullScreen.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/control/MousePosition.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/control/OverviewMap.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/control/Rotate.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/control/ScaleLine.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/control/Zoom.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/control/ZoomSlider.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/control/ZoomToExtent.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/control/util.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/events.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/format/EsriJSON.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/format/Feature.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/format/GMLBase.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/format/GPX.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/format/GeoJSON.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/format/IGC.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/format/KML.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/format/MVT.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/format/Polyline.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/format/TopoJSON.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/format/WFS.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/format/WKT.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/format/WMSGetFeatureInfo.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/interaction.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/interaction/DoubleClickZoom.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/interaction/DragAndDrop.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/interaction/DragBox.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/interaction/DragPan.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/interaction/DragRotate.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/interaction/DragRotateAndZoom.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/interaction/DragZoom.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/interaction/Draw.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/interaction/Extent.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/interaction/KeyboardPan.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/interaction/KeyboardZoom.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/interaction/Modify.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/interaction/MouseWheelZoom.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/interaction/PinchRotate.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/interaction/PinchZoom.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/interaction/Pointer.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/interaction/Select.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/interaction/Snap.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/interaction/Translate.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/layer/Base.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/layer/Group.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/layer/Heatmap.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/layer/Image.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/layer/Layer.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/layer/Tile.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/layer/Vector.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/layer/VectorTile.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/ol-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/ol/v5/proj/Projection.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/render.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/render/canvas.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/source/BingMaps.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/source/CartoDB.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/source/Cluster.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/source/Image.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/source/ImageArcGISRest.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/source/ImageCanvas.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/source/ImageMapGuide.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/source/ImageStatic.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/source/ImageWMS.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/source/OSM.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/source/Raster.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/source/Source.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/source/Stamen.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/source/Tile.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/source/TileArcGISRest.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/source/TileDebug.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/source/TileImage.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/source/TileJSON.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/source/TileWMS.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/source/UTFGrid.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/source/UrlTile.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/source/Vector.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/source/VectorTile.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/source/WMTS.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/source/XYZ.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/source/Zoomify.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/style/AtlasManager.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/style/Circle.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/style/Fill.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/style/Icon.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/style/RegularShape.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/style/Stroke.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/style/Style.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/style/Text.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/tilegrid/TileGrid.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/v5/tilegrid/WMTS.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ol/webgl/Helper.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "hanreev"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 875726994,
  "ciResult": "fail",
  "ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/36f657f9da05e895dc089fcec4d35aabfdbfeb1a/checks?check_suite_id=3180976124"
}

@typescript-bot
Copy link
Contributor

⚠️ There are too many reviewers for this PR change (77). Merging can only be handled by a DT maintainer.

People who would have been pinged CaselIT alanmarcell dante-101 mcortesi EnricoPicci AJCStriker julien-c daprahamian denys-bushulyak b4nst sindbach geraldinelemeur various89 angela-1 hector7 floric erikc5000 Manc jloveridge ranguna HosseinAgha albertossilva peterblazejewicz LinusU taxilian xamgore avaly HitkoDev Celend jtassin addaleax emmanuelgautier wyattjoh borfig mgroenhoff ammuench agadar Dabolus Kallu609 XC-Zhang adityathebe MiklerGM ariutin XieJiSS toniop99 rogierschouten dex4er bioball forivall jdxcode OiYouYeahYou ajafff ChaosinaCan SomaticIT DanielMSchmidt littlepiggy03 wildlyinaccurate RubenSlabbert MatthewBurstein ExE-Boss misak113 artdiniz martin-badin demurgos Akuukis ljharb pocesar BendingBender VitorLuizC OfficeDev Rick-Kirkham AlexJerabek ElizabethSamuel-MSFT alison-mk kayahr ova2 hanreev

@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Jul 7, 2021
@typescript-bot
Copy link
Contributor

@sandersn The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

1 similar comment
@typescript-bot
Copy link
Contributor

@sandersn The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Jul 7, 2021
@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Jul 7, 2021
@typescript-bot
Copy link
Contributor

@sandersn The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@sandersn
Copy link
Contributor Author

sandersn commented Jul 7, 2021

Same failures from mongoose dependents as usual.

@sandersn sandersn merged commit 6f93d35 into master Jul 7, 2021
@sandersn sandersn deleted the Mongo-Ol-add-undefined-to-optional-properties branch July 7, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants