New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[node] util
module fixes
#56435
[node] util
module fixes
#56435
Conversation
node 16.x - Add `debug` alias. - Add `getSystemErrorName`. - Add `stripVTControlCharacters`. node 14.x - Add `debug` alias. Fix `debuglog` types. - Add `getSystemErrorName`.
@Semigradsky Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 56435,
"author": "Semigradsky",
"headCommitOid": "d319cb473e7563a9367a02887c90c46027521416",
"lastPushDate": "2021-10-11T06:36:48.000Z",
"lastActivityDate": "2021-10-11T06:57:28.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "node",
"kind": "edit",
"files": [
{
"path": "types/node/index.d.ts",
"kind": "definition"
},
{
"path": "types/node/test/util.ts",
"kind": "test"
},
{
"path": "types/node/util.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/test/util.ts",
"kind": "test"
},
{
"path": "types/node/v14/util.d.ts",
"kind": "definition"
}
],
"owners": [
"Microsoft",
"DefinitelyTyped",
"jkomyno",
"alvis",
"r3nya",
"btoueg",
"smac89",
"touffy",
"DeividasBakanas",
"eyqs",
"Hannes-Magnusson-CK",
"hoo29",
"kjin",
"ajafff",
"islishude",
"mwiktorczyk",
"mohsen1",
"n-e",
"galkin",
"parambirs",
"eps1lon",
"SimonSchick",
"ThomasdenH",
"WilcoBakker",
"wwwy3y3",
"samuela",
"kuehlein",
"bhongy",
"chyzwar",
"trivikr",
"nguymin4",
"yoursunny",
"qwelias",
"ExE-Boss",
"Ryan-Willpower",
"peterblazejewicz",
"addaleax",
"victorperin",
"ZYSzys",
"NodeJS",
"LinusU",
"wafuwafu13"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [],
"mainBotCommentID": 939727407,
"ciResult": "pass"
} |
🔔 @microsoft @DefinitelyTyped @jkomyno @alvis @r3nya @btoueg @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @n-e @galkin @parambirs @eps1lon @SimonSchick @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @nguymin4 @yoursunny @qwelias @ExE-Boss @Ryan-Willpower @peterblazejewicz @addaleax @victorperin @ZYSzys @nodejs @LinusU @wafuwafu13 — please review this PR in the next few days. Be sure to explicitly select |
@@ -1,4 +1,4 @@ | |||
// Type definitions for non-npm package Node.js 16.10 | |||
// Type definitions for non-npm package Node.js 16.11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not bump this version unless you bring up the typings fully up to date.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I remove adding stripVTControlCharacters
? It was added in Node.js 16.11.
Ok, as I see my changes was moved to #56462 so I close this. |
node 16.x
debug
alias.getSystemErrorName
.stripVTControlCharacters
.node 14.x
debug
alias. Fixdebuglog
types.getSystemErrorName
.Please fill in this template.
npm test <package to test>
.Select one of these and delete the others:
If changing an existing definition: