[three] r138

[joshuaellis]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

Select one of these and delete the others:

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: <>
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

[typescript-bot]

@joshuaellis Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• three — on npm, on unpkg (author is owner)
  • owner-approval: @Methuselah96
  • Config files to check:
    • three/OTHER_FILES.txt: not the expected form and not moving towards it

Code Reviews

Because this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• 🕐 A DT maintainer needs to approve changes which affect module config files

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 59045,
  "author": "joshuaellis",
  "headCommitOid": "fdbb800623efb48e7a2451729f71df94baea47d4",
  "mergeBaseOid": "c7836422a663aab0a3406c471d2326a9b9c847c1",
  "lastPushDate": "2022-03-02T15:07:17.000Z",
  "lastActivityDate": "2022-03-02T15:24:55.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "three",
      "kind": "edit",
      "files": [
        {
          "path": "types/three/OTHER_FILES.txt",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-other_filestxt) and not moving towards it"
        },
        {
          "path": "types/three/examples/jsm/capabilities/WebGL.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/controls/OrbitControls.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/curves/CurveExtras.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/exporters/EXRExporter.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/helpers/OctreeHelper.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/interactive/HTMLMesh.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/loaders/GLTFLoader.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/loaders/LUT3dlLoader.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/loaders/LUTCubeLoader.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/loaders/VOXLoader.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/loaders/VRMLoader.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/Nodes.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/accessors/CameraNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/accessors/ColorsNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/accessors/LightNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/accessors/NormalNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/accessors/PositionNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/accessors/ReflectNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/accessors/ResolutionNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/accessors/ScreenUVNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/accessors/UVNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/core/AttributeNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/core/ConstNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/core/ExpressionNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/core/FunctionCallNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/core/FunctionNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/core/InputNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/core/Node.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/core/NodeBuilder.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/core/NodeFrame.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/core/NodeLib.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/core/NodeUniform.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/core/NodeUtils.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/core/StructNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/core/TempNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/core/VarNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/effects/BlurNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/effects/ColorAdjustmentNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/effects/LuminanceNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/inputs/BoolNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/inputs/ColorNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/inputs/CubeTextureNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/inputs/FloatNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/inputs/IntNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/inputs/Matrix3Node.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/inputs/Matrix4Node.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/inputs/PropertyNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/inputs/RTTNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/inputs/ReflectorNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/inputs/ScreenNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/inputs/TextureNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/inputs/Vector2Node.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/inputs/Vector3Node.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/inputs/Vector4Node.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/materials/BasicNodeMaterial.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/materials/MeshStandardNodeMaterial.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/materials/NodeMaterial.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/materials/PhongNodeMaterial.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/materials/SpriteNodeMaterial.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/materials/StandardNodeMaterial.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/materials/nodes/BasicNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/materials/nodes/MeshStandardNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/materials/nodes/PhongNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/materials/nodes/RawNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/materials/nodes/SpriteNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/materials/nodes/StandardNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/math/CondNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/math/MathNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/math/OperatorNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/misc/BumpMapNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/misc/NormalMapNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/misc/TextureCubeNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/misc/TextureCubeUVNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/postprocessing/NodePass.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/postprocessing/NodePostProcessing.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/procedural/CheckerNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/procedural/NoiseNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/utils/BypassNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/utils/ColorSpaceNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/utils/JoinNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/utils/MaxMIPLevelNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/utils/SpecularMIPLevelNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/utils/SubSlot.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/utils/SwitchNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/utils/TimerNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/utils/UVTransformNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/utils/VelocityNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/objects/Reflector.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/objects/ReflectorRTT.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/objects/Refractor.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/postprocessing/LUTPass.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/src/Three.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/src/constants.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/src/core/Raycaster.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/src/math/Euler.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/src/math/Vector3.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/src/renderers/WebGL3DRenderTarget.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/src/renderers/WebGLArrayRenderTarget.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/src/renderers/WebGLMultipleRenderTargets.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/src/renderers/WebGLMultisampleRenderTarget.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/src/renderers/WebGLRenderTarget.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/src/renderers/WebGLRenderer.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/src/textures/CompressedTexture.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/src/textures/Data3DTexture.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/src/textures/DataArrayTexture.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/src/textures/DataTexture.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/src/textures/DataTexture2DArray.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/src/textures/DataTexture3D.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/src/textures/DepthTexture.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/src/textures/Source.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/src/textures/Texture.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/test/geometries/geometry-parametric.ts",
          "kind": "test"
        },
        {
          "path": "types/three/test/loaders/loaders-voxloader.ts",
          "kind": "test"
        },
        {
          "path": "types/three/test/materials/materials-envmaps-hdr.ts",
          "kind": "test"
        },
        {
          "path": "types/three/test/materials/materials-texture3d-partialupdate.ts",
          "kind": "test"
        },
        {
          "path": "types/three/test/renderers/renderers-renderTarget-multiple.ts",
          "kind": "test"
        },
        {
          "path": "types/three/test/renderers/renderers-renderTarget-texture2DArray.ts",
          "kind": "test"
        },
        {
          "path": "types/three/test/textures/textures-source.ts",
          "kind": "test"
        },
        {
          "path": "types/three/tsconfig.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "joshuaellis",
        "Methuselah96"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "Methuselah96",
      "date": "2022-03-02T15:24:55.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1055173956,
  "ciResult": "pass"
}

[typescript-bot]

🔔 @Methuselah96 — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[DangerBotOSS]

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

three (unpkg)

was missing the following properties:

1. AxisHelper
2. BinaryTextureLoader
3. BoundingBoxHelper
4. CanvasRenderer
5. DynamicBufferAttribute

as well as these 27 other properties...

EdgesHelper, FaceColors, Font, FontLoader, ImmediateRenderObject, JSONLoader, LensFlare, Math, MeshFaceMaterial, MultiMaterial, NoColors, ParametricGeometry, Particle, ParticleBasicMaterial, ParticleSystem, ParticleSystemMaterial, PointCloud, PointCloudMaterial, RGBFormat, SceneUtils, TextGeometry, Vertex, VertexColors, WebGLRenderTargetCube, WebGLUtils, WireframeHelper, XHRLoader

Generated by 🚫 dangerJS against fdbb800

[joshuaellis]

@weswigham i've amended based on DangerOSS ask. Any chance of getting this merged? 👍🏼

[typescript-bot]

@Methuselah96 Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?