Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r138 #164

Closed
16 tasks done
joshuaellis opened this issue Jan 27, 2022 · 15 comments
Closed
16 tasks done

r138 #164

joshuaellis opened this issue Jan 27, 2022 · 15 comments
Labels
current release issues to do with the current release of Three

Comments

@joshuaellis
Copy link
Member

joshuaellis commented Jan 27, 2022 •
edited

Issue Tracker

This is used to track potential issues we need to investigate surrounding the r138 release.

Last checked: mrdoob/three.js@925fa24d6f (01 / 03 / 22).
@joshuaellis joshuaellis added enhancement New feature or request new release issues to do with the upcoming release of Three and removed enhancement New feature or request labels Jan 27, 2022
@joshuaellis joshuaellis pinned this issue Jan 27, 2022
@0b5vr
Copy link
Contributor

0b5vr commented Feb 22, 2022 •
edited

https://github.com/mrdoob/three.js/milestone/51

mrdoob/three.js@r137...r138

https://github.com/mrdoob/three.js/releases/tag/r138

@0b5vr
Copy link
Contributor

0b5vr commented Feb 22, 2022

addressed the mrdoob/three.js#23414.

#179

@0b5vr
Copy link
Contributor

0b5vr commented Feb 22, 2022 •
edited

gonna do mrdoob/three.js#22846 , which is going to be a moderate amount of diff.

Update: #180

@0b5vr
Copy link
Contributor

0b5vr commented Mar 1, 2022 •
edited

gonna do mrdoob/three.js#23498

Update: #183

@0b5vr
Copy link
Contributor

0b5vr commented Mar 1, 2022 •
edited

gonna do mrdoob/three.js#23494

Update: #184

@0b5vr
Copy link
Contributor

0b5vr commented Mar 1, 2022 •
edited

gonna do mrdoob/three.js#23386

Update: #185

@0b5vr
Copy link
Contributor

0b5vr commented Mar 1, 2022 •
edited

gonna do mrdoob/three.js#23420

Update: #186

@0b5vr
Copy link
Contributor

0b5vr commented Mar 1, 2022 •
edited

I have no knowledge about node material and have no idea what happened @ mrdoob/three.js#23418 ......
Is there anything we should do?

Update: mrdoob/three.js#23314 also has a lot of signature changes related to node materials

@0b5vr
Copy link
Contributor

0b5vr commented Mar 1, 2022 •
edited

have done the mrdoob/three.js#22772 : #187

@0b5vr
Copy link
Contributor

0b5vr commented Mar 1, 2022 •
edited

gonna do mrdoob/three.js#23444

Update: #188

@0b5vr
Copy link
Contributor

0b5vr commented Mar 1, 2022 •
edited

gonna do mrdoob/three.js#23455

Update: #190

@0b5vr
Copy link
Contributor

0b5vr commented Mar 1, 2022 •
edited

gonna do mrdoob/three.js#23481

Update: #191

@0b5vr
Copy link
Contributor

0b5vr commented Mar 1, 2022

I think I've seen all the signature changes in r138. 50% confidence

@joshuaellis
Copy link
Member Author

I've gone through and might have got more, but need to check the PRs in details. Lets aim 138 at master from now since it's the current release.

@joshuaellis joshuaellis added current release issues to do with the current release of Three and removed new release issues to do with the upcoming release of Three labels Mar 1, 2022
@joshuaellis
Copy link
Member Author

will be resolved by #59045

@joshuaellis joshuaellis unpinned this issue Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
current release issues to do with the current release of Three
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0b5vr @joshuaellis