Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[node] Add structuredClone global to node #59434

Merged

Conversation

josh-
Copy link
Contributor

@josh- josh- commented Mar 24, 2022

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot
Copy link
Contributor

typescript-bot commented Mar 24, 2022

@josh- Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by a DT maintainer

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 59434,
  "author": "josh-",
  "headCommitOid": "12cc02a92542397cb30c14737d8311e164f6b94a",
  "mergeBaseOid": "c3bd79e9c6624768cd35ef5ed20b4a0bd9ed72fe",
  "lastPushDate": "2022-04-26T00:15:09.000Z",
  "lastActivityDate": "2022-04-26T20:43:55.000Z",
  "mergeOfferDate": "2022-04-26T16:57:57.000Z",
  "mergeRequestDate": "2022-04-26T20:43:55.000Z",
  "mergeRequestUser": "josh-",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "node",
      "kind": "edit",
      "files": [
        {
          "path": "types/node/globals.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/test/globals.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "Microsoft",
        "DefinitelyTyped",
        "jkomyno",
        "alvis",
        "r3nya",
        "btoueg",
        "smac89",
        "touffy",
        "DeividasBakanas",
        "eyqs",
        "Hannes-Magnusson-CK",
        "hoo29",
        "kjin",
        "ajafff",
        "islishude",
        "mwiktorczyk",
        "mohsen1",
        "n-e",
        "galkin",
        "parambirs",
        "eps1lon",
        "SimonSchick",
        "ThomasdenH",
        "WilcoBakker",
        "wwwy3y3",
        "samuela",
        "kuehlein",
        "bhongy",
        "chyzwar",
        "trivikr",
        "yoursunny",
        "qwelias",
        "ExE-Boss",
        "peterblazejewicz",
        "addaleax",
        "victorperin",
        "ZYSzys",
        "NodeJS",
        "LinusU",
        "wafuwafu13"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "amcasey",
      "date": "2022-04-26T16:57:18.000Z",
      "isMaintainer": true
    },
    {
      "type": "stale",
      "reviewer": "LinusU",
      "date": "2022-03-25T13:48:12.000Z",
      "abbrOid": "efa0a4f"
    },
    {
      "type": "stale",
      "reviewer": "addaleax",
      "date": "2022-03-25T13:20:50.000Z",
      "abbrOid": "efa0a4f"
    }
  ],
  "mainBotCommentID": 1077704853,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Where is GH Actions? GH Actions didn't give a response to this PR Critical package labels Mar 24, 2022
types/node/globals.d.ts Outdated Show resolved Hide resolved
@typescript-bot typescript-bot removed the Where is GH Actions? GH Actions didn't give a response to this PR label Mar 24, 2022
@typescript-bot typescript-bot moved this from Other to Waiting for Code Reviews in New Pull Request Status Board Mar 24, 2022
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Mar 24, 2022
Copy link
Contributor

@amcasey amcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comment from @addaleax; otherwise, seems sensible to me.

@amcasey amcasey moved this from Needs Maintainer Review to Waiting for Code Reviews in New Pull Request Status Board Mar 24, 2022
@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Mar 25, 2022
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Mar 25, 2022
@typescript-bot
Copy link
Contributor

@josh- The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@josh-
Copy link
Contributor Author

josh- commented Mar 25, 2022

CI failures appear to be unrelated? Eg, running the yargs test for me locally passes:

$ npm test yargs
> definitely-typed@0.0.3 test
> dtslint types "yargs"

dtslint@0.0.111
testing from 3.9 to 4.1 in /Users/josh/Desktop/DefinitelyTyped/types/yargs/ts4.1
testing from 4.2 to 4.7 in /Users/josh/Desktop/DefinitelyTyped/types/yargs

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Mar 25, 2022
Copy link
Contributor

@LinusU LinusU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat 👍

@amcasey
Copy link
Contributor

amcasey commented Mar 25, 2022

@josh- Yeah, I'm pretty sure the CI failure is unrelated - bear with us since we have a couple of systemic issues at the moment.

@amcasey
Copy link
Contributor

amcasey commented Mar 25, 2022

Re-opening for fresh CI

@amcasey amcasey closed this Mar 25, 2022
@amcasey amcasey reopened this Mar 25, 2022
@Araxeus
Copy link

Araxeus commented Apr 3, 2022

Would love for this to get merged, this global is available in node since v17.0.0 (6 months ago)

@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Apr 24, 2022
@typescript-bot typescript-bot removed Owner Approved A listed owner of this package signed off on the pull request. The CI failed When GH Actions fails labels Apr 24, 2022
@typescript-bot typescript-bot moved this from Needs Author Action to Needs Maintainer Action in New Pull Request Status Board Apr 24, 2022
@typescript-bot
Copy link
Contributor

@typescript-bot typescript-bot removed the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Apr 24, 2022
@typescript-bot typescript-bot moved this from Needs Maintainer Action to Needs Maintainer Review in New Pull Request Status Board Apr 24, 2022
@typescript-bot
Copy link
Contributor

@LinusU, @addaleax, @amcasey Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

Copy link
Contributor

@amcasey amcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I think the bot got confused and set the status incorrectly.

types/node/globals.d.ts Outdated Show resolved Hide resolved
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Apr 26, 2022
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Author to Merge in New Pull Request Status Board Apr 26, 2022
@typescript-bot
Copy link
Contributor

@LinusU, @addaleax Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@typescript-bot typescript-bot removed Self Merge This PR can now be self-merged by the PR author or an owner Maintainer Approved labels Apr 26, 2022
@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Waiting for Code Reviews in New Pull Request Status Board Apr 26, 2022
@typescript-bot
Copy link
Contributor

@amcasey, @LinusU, @addaleax Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Apr 26, 2022
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Apr 26, 2022
@typescript-bot
Copy link
Contributor

@josh-: Everything looks good here. I am ready to merge this PR (at 12cc02a) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@microsoft, @DefinitelyTyped, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @n-e, @galkin, @parambirs, @eps1lon, @SimonSchick, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @ZYSzys, @nodejs, @LinusU, @wafuwafu13: you can do this too.)

@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Author to Merge in New Pull Request Status Board Apr 26, 2022
@josh-
Copy link
Contributor Author

josh- commented Apr 26, 2022

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Apr 26, 2022
@typescript-bot typescript-bot merged commit 1ca333e into DefinitelyTyped:master Apr 26, 2022
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical package Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants