Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react-native] Drop usage of deprecated ReactType #59519

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Mar 28, 2022

react-native uses React 17.0.2. ElementType is available starting with @types/react@17.0.0.

Required for #56210

@typescript-bot typescript-bot added this to Needs Author Action in New Pull Request Status Board Mar 28, 2022
@eps1lon eps1lon marked this pull request as ready for review March 28, 2022 20:26
@eps1lon eps1lon requested a review from alloy as a code owner March 28, 2022 20:26
@typescript-bot
Copy link
Contributor

typescript-bot commented Mar 28, 2022

@eps1lon Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ❌ Continuous integration tests have failed
  • 🕐 Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 9 days.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 59519,
  "author": "eps1lon",
  "headCommitOid": "66c10c1de2b95a15537079fca66fbf545d473642",
  "mergeBaseOid": "32fc906ac9b963c9033d9c2ea6501e3843072f3e",
  "lastPushDate": "2022-03-28T20:17:30.000Z",
  "lastActivityDate": "2022-03-28T20:26:32.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "react-native",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-native/v0.65/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "alloy",
        "huhuanming",
        "iRoachie",
        "timwangdev",
        "kamal",
        "alexdunne",
        "swissmanu",
        "bm-software",
        "mvdam",
        "esemesek",
        "mrnickel",
        "souvik-ghosh",
        "nossbigg",
        "saranshkataria",
        "tykus160",
        "jakebloom",
        "ceyhun",
        "mcmar",
        "theohdv",
        "romain-faust",
        "bebebebebe",
        "Naturalclar",
        "chinesedfan",
        "vtolochk",
        "SychevSP",
        "RageBill",
        "sasurau4",
        "256hz",
        "doumart",
        "drmas",
        "jeremybarbet",
        "ds300",
        "natsathorn",
        "connectdotz",
        "TheWirv",
        "alexeymolchan",
        "alexbrazier",
        "kuasha420",
        "phvillegas",
        "eps1lon",
        "ZihanChen-MSFT"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 1081107832,
  "ciResult": "fail",
  "ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/66c10c1de2b95a15537079fca66fbf545d473642/checks?check_suite_id=5834503068"
}

@typescript-bot typescript-bot added The CI failed When GH Actions fails Critical package Author is Owner The author of this PR is a listed owner of the package. Untested Change This PR does not touch tests labels Mar 28, 2022
@typescript-bot
Copy link
Contributor

@eps1lon The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@eps1lon
Copy link
Collaborator Author

eps1lon commented Apr 7, 2022

merged with #56210 stack.

@eps1lon eps1lon closed this Apr 7, 2022
@eps1lon eps1lon deleted the feat/react-native/deprecated-types branch April 7, 2022 17:15
@typescript-bot typescript-bot removed this from Needs Author Action in New Pull Request Status Board Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author is Owner The author of this PR is a listed owner of the package. Critical package The CI failed When GH Actions fails Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants