Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dom packages for TS 4.7 #59983

Merged
merged 1 commit into from
Apr 20, 2022
Merged

Conversation

sandersn
Copy link
Contributor

@sandersn sandersn commented Apr 20, 2022

  • dom-mediacapture-transform
  • dom-navigation-preload
  • dom-webcodecs

These types now match (or avoid redeclaring) the declarations that will ship with TS 4.7.

- dom-mediacapture-transform
- dom-navigation-preload
- dom-webcodecs

These types now match the declarations that will ship with TS 4.7.
@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 20, 2022

@sandersn Thank you for submitting this PR!

This is a live comment which I will keep updated.

3 packages in this PR

Code Reviews

Because this PR edits multiple packages, it can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 A DT maintainer needs to approve changes which affect more than one package

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 59983,
  "author": "sandersn",
  "headCommitOid": "ac28b224477a71434ba8173efa006db28b8f6c9a",
  "mergeBaseOid": "c9dc0b3d1c9821aad820911836e8339b6b76b6f1",
  "lastPushDate": "2022-04-20T22:52:15.000Z",
  "lastActivityDate": "2022-04-20T22:53:12.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "dom-mediacapture-transform",
      "kind": "edit",
      "files": [
        {
          "path": "types/dom-mediacapture-transform/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "dogben"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "dom-navigation-preload",
      "kind": "edit",
      "files": [
        {
          "path": "types/dom-navigation-preload/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "frigus02",
        "mprobst"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "dom-webcodecs",
      "kind": "edit",
      "files": [
        {
          "path": "types/dom-webcodecs/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/dom-webcodecs/webcodecs.generated.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "dogben"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 1104531107,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @dogben @frigus02 @mprobst — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@sandersn sandersn merged commit d9f6a81 into master Apr 20, 2022
@sandersn sandersn deleted the update-dom-packages-for-ts-4.7 branch April 20, 2022 22:58
@donpark
Copy link

donpark commented Apr 22, 2022

FYI, following types removed from 0.1.4 are in use by VideoColorSpaceInit and VideoColorSpace, triggering errors downstream:

  • VideoColorPrimaries
  • VideoMatrixCoefficients
  • VideoTransferCharacteristics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Edits multiple packages Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants