Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[node] Add missing type definitions for net module #61871

Closed
wants to merge 1 commit into from
Closed

[node] Add missing type definitions for net module #61871

wants to merge 1 commit into from

Conversation

motsgar
Copy link

@motsgar motsgar commented Aug 22, 2022

Please fill in this template.

If changing an existing definition:

These seem to have been added in node v16

@typescript-bot
Copy link
Contributor

typescript-bot commented Aug 22, 2022

@motsgar Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ❌ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 61871,
  "author": "motsgar",
  "headCommitOid": "7942e1aa5b746ac80a9775a52b87505686993193",
  "mergeBaseOid": "9dc27eddf926981d53b4aede5386e4b7bc082cb4",
  "lastPushDate": "2022-08-22T18:49:13.000Z",
  "lastActivityDate": "2022-08-23T20:25:16.000Z",
  "mergeOfferDate": "2022-08-23T20:25:58.000Z",
  "hasMergeConflict": true,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "node",
      "kind": "edit",
      "files": [
        {
          "path": "types/node/net.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Microsoft",
        "DefinitelyTyped",
        "jkomyno",
        "alvis",
        "r3nya",
        "btoueg",
        "smac89",
        "touffy",
        "DeividasBakanas",
        "eyqs",
        "Hannes-Magnusson-CK",
        "hoo29",
        "kjin",
        "ajafff",
        "islishude",
        "mwiktorczyk",
        "mohsen1",
        "n-e",
        "galkin",
        "parambirs",
        "eps1lon",
        "SimonSchick",
        "ThomasdenH",
        "WilcoBakker",
        "wwwy3y3",
        "samuela",
        "kuehlein",
        "bhongy",
        "chyzwar",
        "trivikr",
        "yoursunny",
        "qwelias",
        "ExE-Boss",
        "peterblazejewicz",
        "addaleax",
        "victorperin",
        "ZYSzys",
        "NodeJS",
        "LinusU",
        "wafuwafu13",
        "mcollina"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2022-08-23T20:25:16.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "mcollina",
      "date": "2022-08-22T22:10:21.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1222800731,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Edits Owners This PR adds or removes owners Critical package Untested Change This PR does not touch tests labels Aug 22, 2022
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Aug 22, 2022
@typescript-bot typescript-bot removed the Edits Owners This PR adds or removes owners label Aug 22, 2022
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Aug 22, 2022
@peterblazejewicz
Copy link
Member

Hey, there is also #61840, can you review it? thanks!

Copy link
Contributor

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Aug 22, 2022
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Aug 23, 2022
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Author to Merge in New Pull Request Status Board Aug 23, 2022
@typescript-bot typescript-bot added Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. and removed Self Merge This PR can now be self-merged by the PR author or an owner labels Aug 24, 2022
@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Needs Author Action in New Pull Request Status Board Aug 24, 2022
@typescript-bot
Copy link
Contributor

@motsgar Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!

@motsgar
Copy link
Author

motsgar commented Aug 24, 2022

Well it seems like this was solved by the other PR that was opened a few days earlier so I'm closing this one.

@motsgar motsgar closed this Aug 24, 2022
@typescript-bot typescript-bot removed this from Needs Author Action in New Pull Request Status Board Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical package Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. Maintainer Approved Owner Approved A listed owner of this package signed off on the pull request. Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants