Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add WebGLRenderingContext to gl #62647

Conversation

michaeljherrmann
Copy link
Contributor

@michaeljherrmann michaeljherrmann commented Oct 10, 2022

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot
Copy link
Contributor

typescript-bot commented Oct 10, 2022

@michaeljherrmann Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 62647,
  "author": "michaeljherrmann",
  "headCommitOid": "0ddca199d5ddc4b54051fc82ae57f8b9d90f0864",
  "mergeBaseOid": "6531b9751f58c48d548c763eb49c0e17bbd52a73",
  "lastPushDate": "2022-10-10T23:43:34.000Z",
  "lastActivityDate": "2022-10-28T21:19:51.000Z",
  "mergeOfferDate": "2022-10-28T18:48:35.000Z",
  "mergeRequestDate": "2022-10-28T21:19:51.000Z",
  "mergeRequestUser": "michaeljherrmann",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "gl",
      "kind": "edit",
      "files": [
        {
          "path": "types/gl/gl-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/gl/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "DefinitelyTyped"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2022-10-28T18:47:48.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1273919231,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Oct 10, 2022
@typescript-bot
Copy link
Contributor

🔔 @DefinitelyTyped — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Oct 22, 2022
@typescript-bot
Copy link
Contributor

Re-ping @DefinitelyTyped:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@michaeljherrmann
Copy link
Contributor Author

@peterblazejewicz are you able to review this for me? (or recommend someone to?) thanks!

Copy link
Member

@peterblazejewicz peterblazejewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@michaeljherrmann thanks!

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Oct 28, 2022
@typescript-bot
Copy link
Contributor

@michaeljherrmann: Everything looks good here. I am ready to merge this PR (at 0ddca19) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@DefinitelyTyped: you can do this too.)

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in New Pull Request Status Board Oct 28, 2022
@michaeljherrmann
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Oct 28, 2022
@typescript-bot typescript-bot merged commit 7dc8256 into DefinitelyTyped:master Oct 28, 2022
@michaeljherrmann michaeljherrmann deleted the gl-add-webgl-rendering-context branch November 10, 2022 21:01
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants