New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating WebGLRenderingContext for node #8842
Conversation
@@ -144,11 +144,11 @@ | |||
"@pixi/spritesheet": "7.1.0-alpha", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if I regenerated the lock file correctly? seems to have more changes than I expected. I just ran npm install
in the top level after updating the package.json
for node
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried npm i gl@6.0.1 @types/gl@6.0.1
in bundles/pixi.js-node
and got the same result, so I think it is OK. Possibly it is caused by the dependency change of gl
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bigtimebuddy by the way, should we have a npm audit fix
for 7.1.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we tried an audit awhile ago (#8480), but kept being blocked by various things. I'm open to doing this again.
I'm guessing @Zyie should probable review this? |
By the way, I'm making a refactor on |
I think I need to fix some more typings still in |
By the way, it seems that the extension interfaces like Trying to make a PR for |
@michaeljherrmann Now that my PR for |
@SuperSodaSea done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thank you @michaeljherrmann and @SuperSodaSea! |
Description of change
I'm following up on this PR as the ideal fix we wanted required some updates to some dependencies. I've got those updates merged in gl and for it's types.
Pre-Merge Checklist
npm run lint
)npm run test
)