-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the @types/eslint
package type for the ESLint config field globals
#62941
Fix the @types/eslint
package type for the ESLint config field globals
#62941
Conversation
…field. This fixes the `@types/eslint` package type for the ESLint config field `globals` object, which should be able to accept `"off"` values to disable certain globals. See: https://eslint.org/docs/latest/user-guide/configuring/language-options#using-configuration-files-1
@jaydenseric Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 62941,
"author": "jaydenseric",
"headCommitOid": "fdcbb24ba42cfd6f61179479974adbcb784ff4a2",
"mergeBaseOid": "fe7d7cf8b5ffa8141f5f657f25eedd7e15b17352",
"lastPushDate": "2022-10-28T04:53:01.000Z",
"lastActivityDate": "2022-10-28T20:57:51.000Z",
"mergeOfferDate": "2022-10-28T16:17:58.000Z",
"mergeRequestDate": "2022-10-28T20:57:51.000Z",
"mergeRequestUser": "jaydenseric",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "eslint",
"kind": "edit",
"files": [
{
"path": "types/eslint/eslint-tests.ts",
"kind": "test"
},
{
"path": "types/eslint/index.d.ts",
"kind": "definition"
}
],
"owners": [
"pmdartus",
"j-f1",
"saadq",
"JasonHK",
"bradzacher",
"JounQin"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "jakebailey",
"date": "2022-10-28T16:17:11.000Z",
"isMaintainer": true
},
{
"type": "approved",
"reviewer": "bradzacher",
"date": "2022-10-28T06:07:57.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1294456409,
"ciResult": "pass"
} |
🔔 @pmdartus @j-f1 @saadq @JasonHK @bradzacher @JounQin — please review this PR in the next few days. Be sure to explicitly select |
@jaydenseric: Everything looks good here. I am ready to merge this PR (at fdcbb24) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@pmdartus, @j-f1, @saadq, @JasonHK, @bradzacher, @JounQin: you can do this too.) |
Ready to merge |
This fixes the
@types/eslint
package type for the ESLint config fieldglobals
object, which should be able to accept"off"
values to disable certain globals. See:https://eslint.org/docs/latest/user-guide/configuring/language-options#using-configuration-files-1
Please fill in this template.
npm test <package to test>
.Select one of these and delete the others:
If changing an existing definition: