Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jest]: add features released in v29.5 #64601

Merged
merged 4 commits into from Mar 16, 2023
Merged

[jest]: add features released in v29.5 #64601

merged 4 commits into from Mar 16, 2023

Conversation

mrazauskas
Copy link
Contributor

@mrazauskas mrazauskas commented Mar 6, 2023

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

Summary

Jest v29.5 shipped earlier today with several new APIs: jest.runAllTimersAsync(), jest.runOnlyPendingTimersAsync(), advanceTimersByTimeAsync() and advanceTimersToNextTimerAsync(). So I try to keep @types/jest up to date.

Also I used this opportunity to polish JSDoc comments of fake timer APIs a bit.

@typescript-bot
Copy link
Contributor

typescript-bot commented Mar 6, 2023

@mrazauskas Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by a DT maintainer

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 64601,
  "author": "mrazauskas",
  "headCommitOid": "0e005428c1da1f194fd49ecaff8b07974d5c669e",
  "mergeBaseOid": "fc7ce75c70a9982a8876f6503d6d2ec0723a46ee",
  "lastPushDate": "2023-03-16T06:07:09.000Z",
  "lastActivityDate": "2023-03-16T16:34:05.000Z",
  "mergeOfferDate": "2023-03-16T16:27:10.000Z",
  "mergeRequestDate": "2023-03-16T16:34:05.000Z",
  "mergeRequestUser": "mrazauskas",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "jest",
      "kind": "edit",
      "files": [
        {
          "path": "types/jest/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/jest/jest-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "NoHomey",
        "jwbay",
        "asvetliakov",
        "alexjoverm",
        "epicallan",
        "ikatyang",
        "wsmd",
        "JamieMason",
        "douglasduteil",
        "ahnpnl",
        "UselessPickles",
        "r3nya",
        "hotell",
        "sebald",
        "andys8",
        "antoinebrault",
        "gstamac",
        "ExE-Boss",
        "quassnoi",
        "Belco90",
        "tonyhallett",
        "ycmjason",
        "pawfa",
        "gerkindev",
        "domdomegg",
        "mrazauskas"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "jakebailey",
      "date": "2023-03-16T16:26:23.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "domdomegg",
      "date": "2023-03-16T12:02:29.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1456474565,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Critical package Author is Owner The author of this PR is a listed owner of the package. labels Mar 6, 2023
@typescript-bot
Copy link
Contributor

🔔 @NoHomey @jwbay @asvetliakov @alexjoverm @epicallan @ikatyang @wsmd @JamieMason @douglasduteil @ahnpnl @UselessPickles @r3nya @Hotell @sebald @andys8 @antoinebrault @gstamac @ExE-Boss @quassnoi @Belco90 @tonyhallett @ycmjason @pawfa @GerkinDev @domdomegg — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Mar 6, 2023
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Mar 6, 2023
@jakebailey jakebailey moved this from Needs Maintainer Review to Waiting for Code Reviews in New Pull Request Status Board Mar 13, 2023
@typescript-bot typescript-bot added the Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. label Mar 16, 2023
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Mar 16, 2023
@typescript-bot
Copy link
Contributor

@mrazauskas Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Mar 16, 2023
@typescript-bot typescript-bot removed Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. Owner Approved A listed owner of this package signed off on the pull request. labels Mar 16, 2023
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Mar 16, 2023
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Mar 16, 2023
@typescript-bot
Copy link
Contributor

@domdomegg Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Code Reviews in New Pull Request Status Board Mar 16, 2023
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Mar 16, 2023
@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Mar 16, 2023
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Mar 16, 2023
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Author to Merge in New Pull Request Status Board Mar 16, 2023
@typescript-bot
Copy link
Contributor

@mrazauskas: Everything looks good here. I am ready to merge this PR (at 0e00542) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@NoHomey, @jwbay, @asvetliakov, @alexjoverm, @epicallan, @ikatyang, @wsmd, @JamieMason, @douglasduteil, @ahnpnl, @UselessPickles, @r3nya, @Hotell, @sebald, @andys8, @antoinebrault, @gstamac, @ExE-Boss, @quassnoi, @Belco90, @tonyhallett, @ycmjason, @pawfa, @GerkinDev, @domdomegg: you can do this too.)

@mrazauskas
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Mar 16, 2023
@typescript-bot typescript-bot merged commit ecbabd3 into DefinitelyTyped:master Mar 16, 2023
2 checks passed
@mrazauskas mrazauskas deleted the jest-add-v29.5-features branch March 16, 2023 16:45
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author is Owner The author of this PR is a listed owner of the package. Critical package Maintainer Approved Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants