[@types/better-sqlite3] Prefer unknown to any

[AverageHelper]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: [@types/better-sqlite3] #62205
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

[typescript-bot]

@AverageHelper Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• better-sqlite3 — on npm, on unpkg
  • owner-approval: @sant123

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 65035,
  "author": "AverageHelper",
  "headCommitOid": "ebbbbe348c49769ad7e737587a2a715677c1bf75",
  "mergeBaseOid": "ccf7ee3816e54705e01e832abf4daf1f6a89ae17",
  "lastPushDate": "2023-04-06T16:26:28.000Z",
  "lastActivityDate": "2023-04-06T16:35:53.000Z",
  "mergeOfferDate": "2023-04-06T16:35:40.000Z",
  "mergeRequestDate": "2023-04-06T16:35:53.000Z",
  "mergeRequestUser": "AverageHelper",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "better-sqlite3",
      "kind": "edit",
      "files": [
        {
          "path": "types/better-sqlite3/better-sqlite3-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/better-sqlite3/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Morfent",
        "matrumz",
        "sant123",
        "loghorn",
        "andykais",
        "mrkstwrt",
        "stamerf"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "sant123",
      "date": "2023-04-06T16:34:57.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1499287540,
  "ciResult": "pass"
}

[typescript-bot]

🔔 @Morfent @matrumz @sant123 @Loghorn @andykais @mrkstwrt @stamerf — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

@AverageHelper The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

[typescript-bot]

@AverageHelper The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

[AverageHelper]

Sorry for all the CI failures, lol. I only now figured out that I need to clear node_modules sometimes to get the tests to run locally 😅

I'm not sure quite what to do about the version number. I did have to alter the type tests slightly to clarify the type of one parameter, but I don't know whether that constitutes a "breaking" change in this context.

[sant123]

LGTM!

[typescript-bot]

@AverageHelper: Everything looks good here. I am ready to merge this PR (at ebbbbe3) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@Morfent, @matrumz, @sant123, @Loghorn, @andykais, @mrkstwrt, @stamerf: you can do this too.)

[AverageHelper]

Ready to merge