-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ramda] Bump types-ramda
package to latest
#65286
[ramda] Bump types-ramda
package to latest
#65286
Conversation
@Harris-Miller Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 65286,
"author": "Harris-Miller",
"headCommitOid": "725003382ebb7c1906a07700b1921e00d12bfcb4",
"mergeBaseOid": "8507d1ec567df3fbac1e896ec97a260cccc5910d",
"lastPushDate": "2023-04-27T03:14:55.000Z",
"lastActivityDate": "2023-04-29T01:19:21.000Z",
"mergeOfferDate": "2023-04-28T19:29:00.000Z",
"mergeRequestDate": "2023-04-29T01:19:21.000Z",
"mergeRequestUser": "Harris-Miller",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "ramda",
"kind": "edit",
"files": [
{
"path": "types/ramda/OTHER_FILES.txt",
"kind": "package-meta",
"suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-other_filestxt) and not moving towards it"
},
{
"path": "types/ramda/es/modifyPath.d.ts",
"kind": "definition"
},
{
"path": "types/ramda/index.d.ts",
"kind": "definition"
},
{
"path": "types/ramda/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/ramda/src/modifyPath.d.ts",
"kind": "definition"
},
{
"path": "types/ramda/test/find-tests.ts",
"kind": "test"
},
{
"path": "types/ramda/test/findIndex-tests.ts",
"kind": "test"
},
{
"path": "types/ramda/test/findLast-tests.ts",
"kind": "test"
},
{
"path": "types/ramda/test/findLastIndex-tests.ts",
"kind": "test"
},
{
"path": "types/ramda/test/propEq-tests.ts",
"kind": "test"
}
],
"owners": [
"TheHandsomeCoder",
"donnut",
"mdekrey",
"sbking",
"afharo",
"teves-castro",
"hojberg",
"samsonkeung",
"angeloocana",
"raynerd",
"moshensky",
"ethanresnick",
"deftomat",
"blimusiek",
"biern",
"rayhaneh",
"rgm",
"drewwyatt",
"jottenlips",
"minitesh",
"krantisinh",
"nemo108",
"jituanlin",
"Philippe-mills",
"Saul-Mirone",
"Nicholaiii",
"LORDBABUINO",
"couzic",
"NEWESTERS",
"adispring",
"essenmitsosse",
"harris-miller"
],
"addedOwners": [
"kedashoe"
],
"deletedOwners": [
"TheHandsomeCoder",
"donnut",
"mdekrey",
"sbking",
"afharo",
"teves-castro",
"hojberg",
"samsonkeung",
"angeloocana",
"raynerd",
"moshensky",
"ethanresnick",
"deftomat",
"blimusiek",
"biern",
"rayhaneh",
"rgm",
"drewwyatt",
"jottenlips",
"minitesh",
"krantisinh",
"nemo108",
"jituanlin",
"Philippe-mills",
"Saul-Mirone",
"LORDBABUINO",
"couzic",
"NEWESTERS",
"essenmitsosse"
],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "gabritto",
"date": "2023-04-28T19:28:16.000Z",
"isMaintainer": true
},
{
"type": "approved",
"reviewer": "afharo",
"date": "2023-04-28T14:32:44.000Z",
"isMaintainer": false
},
{
"type": "approved",
"reviewer": "Nicholaiii",
"date": "2023-04-28T05:46:22.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1522796759,
"ciResult": "pass"
} |
🔔 @TheHandsomeCoder @donnut @mdekrey @sbking @afharo @teves-castro @hojberg @samsonkeung @angeloocana @raynerd @moshensky @ethanresnick @deftomat @blimusiek @biern @rayhaneh @rgm @drewwyatt @jottenlips @minitesh @Krantisinh @Nemo108 @jituanlin @Philippe-mills @Saul-Mirone @Nicholaiii @LORDBABUINO @couzic @NEWESTERS @adispring @essenmitsosse — please review this PR in the next few days. Be sure to explicitly select |
Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files. ramda (unpkg)was missing the following properties:
|
@Harris-Miller The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
@TheHandsomeCoder @donnut @mdekrey @sbking @afharo @teves-castro @hojberg @samsonkeung @angeloocana @raynerd @moshensky @ethanresnick @deftomat @blimusiek @biern @rayhaneh @rgm @drewwyatt @jottenlips @minitesh @Krantisinh @Nemo108 @jituanlin @Philippe-mills @Saul-Mirone @Nicholaiii @LORDBABUINO @couzic @NEWESTERS @adispring @essenmitsosse Please let me know if you would like your @'s removed Additionally, let me know if you want to be added to https://github.com/ramda/types |
@Harris-Miller given that the reviews from now on are only based on bumping the package version, I'd appreciate if I'm removed from the approvers list 🤗 |
@afharo Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
@TheHandsomeCoder @donnut @mdekrey @sbking @afharo @teves-castro @hojberg @samsonkeung @angeloocana @raynerd @moshensky @ethanresnick @deftomat @blimusiek @biern @rayhaneh @rgm @drewwyatt @jottenlips @minitesh @Krantisinh @Nemo108 @jituanlin @Philippe-mills @Saul-Mirone @Nicholaiii @LORDBABUINO @couzic @NEWESTERS @adispring @essenmitsosse Sorry for the spam, I decided to do this in the other direction. I'm removing everyone except a select few. Since we moved all the type definitions to https://github.com/ramda/types, it doesn't really matter anyhow. @Nicholaiii keeping you since you've been the sole approval for the past year, also adding @kedashoe @adispring who are part of the Ramda org. Let me know if you want to be added to https://github.com/ramda/types as an approver and I'll be happy to add you over there |
Do feel free to add me to other repo. |
@Nicholaiii I added you with write access to types/ramda. And if you could approve this PR for me, please and thank you! |
@Harris-Miller: Everything looks good here. I am ready to merge this PR (at 7250033) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@TheHandsomeCoder, @donnut, @mdekrey, @sbking, @afharo, @teves-castro, @hojberg, @samsonkeung, @angeloocana, @raynerd, @moshensky, @ethanresnick, @deftomat, @blimusiek, @biern, @rayhaneh, @rgm, @drewwyatt, @jottenlips, @minitesh, @Krantisinh, @Nemo108, @jituanlin, @Philippe-mills, @Saul-Mirone, @Nicholaiii, @LORDBABUINO, @couzic, @NEWESTERS, @adispring, @essenmitsosse: you can do this too.) |
Ready to merge |
…o latest by @Harris-Miller * propEq swap param positions, update all usesages of it in tests * bump types-ramda@0.29.2 * added modifyPath to src and es folders * updated OTHER_FILES * removing afharo per request * shrinking owners list * forgot one
This MR
propEq
, as ramda@0.29.0 swapped the argument ordermodifyPath
functiontypes-ramda
to latest