New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[node] http.Agent
extends from EventEmitter
#65408
[node] http.Agent
extends from EventEmitter
#65408
Conversation
``` $ node Welcome to Node.js v16.20.0. Type ".help" for more information. > http.globalAgent instanceof events.EventEmitter true ```
@TooTallNate Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 65408,
"author": "TooTallNate",
"headCommitOid": "df04f085ed160f28b023c19ed65b9003e48e5b0d",
"mergeBaseOid": "08d18de66db9bde5f26c679a7d91f6cd109ad1ec",
"lastPushDate": "2023-05-05T09:56:04.000Z",
"lastActivityDate": "2023-05-05T21:05:45.000Z",
"mergeOfferDate": "2023-05-05T20:21:40.000Z",
"mergeRequestDate": "2023-05-05T21:05:45.000Z",
"mergeRequestUser": "TooTallNate",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "node",
"kind": "edit",
"files": [
{
"path": "types/node/http.d.ts",
"kind": "definition"
},
{
"path": "types/node/test/http.ts",
"kind": "test"
},
{
"path": "types/node/v14/http.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/test/http.ts",
"kind": "test"
},
{
"path": "types/node/v16/http.d.ts",
"kind": "definition"
},
{
"path": "types/node/v16/test/http.ts",
"kind": "test"
},
{
"path": "types/node/v18/http.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/test/http.ts",
"kind": "test"
}
],
"owners": [
"Microsoft",
"DefinitelyTyped",
"jkomyno",
"alvis",
"r3nya",
"btoueg",
"smac89",
"touffy",
"DeividasBakanas",
"eyqs",
"Hannes-Magnusson-CK",
"hoo29",
"kjin",
"ajafff",
"islishude",
"mwiktorczyk",
"mohsen1",
"n-e",
"galkin",
"parambirs",
"eps1lon",
"SimonSchick",
"ThomasdenH",
"WilcoBakker",
"wwwy3y3",
"samuela",
"kuehlein",
"bhongy",
"chyzwar",
"trivikr",
"yoursunny",
"qwelias",
"ExE-Boss",
"peterblazejewicz",
"addaleax",
"victorperin",
"ZYSzys",
"NodeJS",
"LinusU",
"wafuwafu13",
"mcollina",
"Semigradsky"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "peterblazejewicz",
"date": "2023-05-05T20:20:59.000Z",
"isMaintainer": true
},
{
"type": "approved",
"reviewer": "Semigradsky",
"date": "2023-05-05T10:21:46.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1535655868,
"ciResult": "pass"
} |
🔔 @microsoft @DefinitelyTyped @jkomyno @alvis @r3nya @btoueg @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @n-e @galkin @parambirs @eps1lon @SimonSchick @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @peterblazejewicz @addaleax @victorperin @ZYSzys @nodejs @LinusU @wafuwafu13 @mcollina @Semigradsky — please review this PR in the next few days. Be sure to explicitly select |
Part of #153. I'd like to also emit this event on the `agent` instance itself, but this is currently blocked by DefinitelyTyped/DefinitelyTyped#65408.
@TooTallNate please add these changes to |
…yTyped into node-agent-event-emitter
Ya, sure thing. Added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Part of #153. I'd like to also emit this event on the `agent` instance itself, but this is currently blocked by DefinitelyTyped/DefinitelyTyped#65408.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TooTallNate thanks!
@TooTallNate: Everything looks good here. I am ready to merge this PR (at df04f08) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@microsoft, @DefinitelyTyped, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @n-e, @galkin, @parambirs, @eps1lon, @SimonSchick, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @ZYSzys, @nodejs, @LinusU, @wafuwafu13, @mcollina, @Semigradsky: you can do this too.) |
Ready to merge |
…entEmitter` by @TooTallNate * [node] `http.Agent` extends from `EventEmitter` ``` $ node Welcome to Node.js v16.20.0. Type ".help" for more information. > http.globalAgent instanceof events.EventEmitter true ``` * Remove `/` * Add Node 18 * .
Please fill in this template.
npm test <package to test>
.Select one of these and delete the others:
If changing an existing definition: