Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[relay-runtime] Remove unneeded interface #65795

Merged
merged 1 commit into from Jun 16, 2023
Merged

Conversation

gabritto
Copy link
Contributor

Fixing errors in preparation of microsoft/TypeScript#54659.

@gabritto gabritto requested a review from alloy as a code owner June 15, 2023 23:37
@typescript-bot
Copy link
Contributor

typescript-bot commented Jun 15, 2023

@gabritto Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Only a DT maintainer can approve changes without tests

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 65795,
  "author": "gabritto",
  "headCommitOid": "ec2f0d85dcb642fed30294607c1e39938cb93033",
  "mergeBaseOid": "fce54bcb5ec1cf1373c9351051abd674f20d8920",
  "lastPushDate": "2023-06-15T23:34:18.000Z",
  "lastActivityDate": "2023-06-16T17:53:37.000Z",
  "mergeOfferDate": "2023-06-16T17:43:49.000Z",
  "mergeRequestDate": "2023-06-16T17:53:37.000Z",
  "mergeRequestUser": "gabritto",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "relay-runtime",
      "kind": "edit",
      "files": [
        {
          "path": "types/relay-runtime/lib/store/RelayStoreTypes.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "alloy",
        "maraisr",
        "morrys",
        "levibuzolic"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "sheetalkamat",
      "date": "2023-06-16T17:43:03.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "maraisr",
      "date": "2023-06-15T23:43:08.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1593847621,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Untested Change This PR does not touch tests labels Jun 15, 2023
@typescript-bot
Copy link
Contributor

Hey @gabritto,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Jun 15, 2023
@typescript-bot
Copy link
Contributor

🔔 @alloy @maraisr @morrys @levibuzolic — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

Copy link
Contributor

@maraisr maraisr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this 🍻

@DangerBotOSS
Copy link

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

relay-runtime (unpkg)

was missing the following properties:

  1. MutationTypes
  2. RangeOperations

Generated by 🚫 dangerJS against ec2f0d8

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Jun 15, 2023
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Jun 15, 2023
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Jun 16, 2023
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Author to Merge in New Pull Request Status Board Jun 16, 2023
@typescript-bot
Copy link
Contributor

@gabritto: Everything looks good here. I am ready to merge this PR (at ec2f0d8) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@alloy, @maraisr, @morrys, @levibuzolic: you can do this too.)

@gabritto
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Jun 16, 2023
@typescript-bot typescript-bot merged commit b9b8d2a into master Jun 16, 2023
2 checks passed
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Jun 19, 2023
Desplandis pushed a commit to Desplandis/DefinitelyTyped that referenced this pull request Jul 3, 2023
@jakebailey jakebailey deleted the gabritto/fixMerged branch October 19, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintainer Approved Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts). Self Merge This PR can now be self-merged by the PR author or an owner Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants